public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Laszlo Ersek (lersek@redhat.com)" <lersek@redhat.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"afish@apple.com" <afish@apple.com>
Subject: Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules
Date: Wed, 22 May 2019 01:50:16 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44F390@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8D589C@SHSMSX104.ccr.corp.intel.com>

This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. 
This change is to remove the duplicated one. 

Thanks
Liming
> -----Original Message-----
> From: Wu, Hao A
> Sent: Wednesday, May 22, 2019 9:44 AM
> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>
> Subject: RE: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Liming Gao
> > Sent: Tuesday, May 21, 2019 11:22 PM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A
> > Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc
> > to remove Network related modules
> >
> > Network related modules have been included in NetworkPkg.dsc.
> > They can be removed from MdeModulePkg.dsc.
> >
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > ---
> >  MdeModulePkg/MdeModulePkg.dsc | 19 -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index ac7111dea1..995fd805e1 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -63,11 +63,6 @@
> >    #
> >    UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
> >    UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
> > -  NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> > -  IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
> > -  UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> > -  TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> > -  DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> >
> > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL
> > ib/DxeSecurityManagementLib.inf
> >
> > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem
> > plate.inf
> >
> > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in
> > f
> > @@ -263,12 +258,8 @@
> >
> > MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo
> > cationProfileLib.inf
> >
> > MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i
> > nf
> >
> > MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided
> > SectionExtractLib.inf
> > -  MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> > -  MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
> > -  MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> >    MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> >    MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf
> > -  MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> >
> > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco
> > l.inf
> >
> > MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS
> > ectionExtractLib.inf
> >    MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
> > @@ -357,16 +348,6 @@
> >    MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> >
> > MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement
> > Dxe.inf
> >
> > -  MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> > -  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > -  MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> > -  MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > -  MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> > -  MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> > -  MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > -  MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf
> > -  MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > -
> 
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
> I will let the stewards to decide whether this can be pushed at this moment.
> 
> Best Regards,
> Hao Wu
> 
> >
> > MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen
> > tPciCfg2Pei.inf
> >    MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
> >    MdeModulePkg/Universal/PCD/Pei/Pcd.inf
> > --
> > 2.13.0.windows.1
> >
> >
> > 


  reply	other threads:[~2019-05-22  1:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 15:21 [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules Liming Gao
2019-05-22  1:44 ` [edk2-devel] " Wu, Hao A
2019-05-22  1:50   ` Liming Gao [this message]
2019-05-22  9:11     ` Laszlo Ersek
2019-05-22 11:41       ` Liming Gao
2019-05-22 14:33         ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E44F390@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox