public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg.
Date: Tue, 28 May 2019 00:38:49 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4549D3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190527011241.14916-1-eric.dong@intel.com>

Eric: 
  I have two comments. 
1. Add BoardModulePkg.dsc to cover the build for new added modules. 
2. Remove BIOS_ID_GUID macro definition in Guid/BiosId.h. There is no code to consume it. 

Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Dong, Eric
>Sent: Monday, May 27, 2019 9:13 AM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg.
>
>Add new package BoardModulePkg in Platform/Intel folder. This folder
>used to keep the board generic modules, such as Cmos, BiosId.
>
>Add Cmos and BiosId related modules to BoardModulePkg.
>
>
>Eric Dong (3):
>  Maintainers.txt: Add BoardModulePkg in Platform/Intel/ folder.
>  Platform/Intel: Add Cmos related modules to BoardModulePkg
>  Platform/Intel/BoardModulePkg: Add BiosId Module.
>
> Maintainers.txt                               |   4 +
> .../Intel/BoardModulePkg/BoardModulePkg.dec   |  38 ++
> .../BoardModulePkg/Include/Guid/BiosId.h      |  59 +++
> .../Include/Library/BiosIdLib.h               |  57 ++
> .../Include/Library/CmosAccessLib.h           | 106 ++++
> .../Include/Library/PlatformCmosAccessLib.h   |  68 +++
> .../Library/BiosIdLib/DxeBiosIdLib.c          | 175 +++++++
> .../Library/BiosIdLib/DxeBiosIdLib.inf        |  42 ++
> .../Library/BiosIdLib/PeiBiosIdLib.c          | 191 +++++++
> .../Library/BiosIdLib/PeiBiosIdLib.inf        |  42 ++
> .../Library/CmosAccessLib/CmosAccessLib.c     | 486 ++++++++++++++++++
> .../Library/CmosAccessLib/CmosAccessLib.inf   |  28 +
> .../CmosAccessLib/CmosAccessLibInternal.h     |  35 ++
> .../PlatformCmosAccessLibNull.c               |  39 ++
> .../PlatformCmosAccessLibNull.inf             |  23 +
> 15 files changed, 1393 insertions(+)
> create mode 100644 Platform/Intel/BoardModulePkg/BoardModulePkg.dec
> create mode 100644 Platform/Intel/BoardModulePkg/Include/Guid/BiosId.h
> create mode 100644
>Platform/Intel/BoardModulePkg/Include/Library/BiosIdLib.h
> create mode 100644
>Platform/Intel/BoardModulePkg/Include/Library/CmosAccessLib.h
> create mode 100644
>Platform/Intel/BoardModulePkg/Include/Library/PlatformCmosAccessLib.h
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.c
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.inf
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.c
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.inf
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.c
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLibInter
>nal.h
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor
>mCmosAccessLibNull.c
> create mode 100644
>Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor
>mCmosAccessLibNull.inf
>
>--
>2.21.0.windows.1
>
>
>


  parent reply	other threads:[~2019-05-28  0:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  1:12 [Patch 0/3] Add modules to BoardModulePkg Dong, Eric
2019-05-27  1:12 ` [Patch 1/3] [edk2-platform] Maintainers.txt: Add BoardModulePkg in Platform/Intel/ folder Dong, Eric
2019-05-27  1:12 ` [Patch 2/3] [edk2-platform] Platform/Intel: Add Cmos related modules to BoardModulePkg Dong, Eric
2019-05-27  1:12 ` [Patch 3/3] [edk2-platform] Platform/Intel/BoardModulePkg: Add BiosId Module Dong, Eric
2019-05-28  0:38 ` Liming Gao [this message]
     [not found] ` <15A2B1D15A184189.14260@groups.io>
2019-05-28  0:42   ` [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4549D3@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox