From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Mon, 27 May 2019 17:38:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 17:38:52 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 27 May 2019 17:38:52 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 27 May 2019 17:38:51 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 27 May 2019 17:38:51 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Tue, 28 May 2019 08:38:50 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Dong, Eric" Subject: Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg. Thread-Topic: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg. Thread-Index: AQHVFClQ3AWuAbfC80Sv5gmRcvzAGaZ/srAA Date: Tue, 28 May 2019 00:38:49 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4549D3@SHSMSX104.ccr.corp.intel.com> References: <20190527011241.14916-1-eric.dong@intel.com> In-Reply-To: <20190527011241.14916-1-eric.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Eric:=20 I have two comments.=20 1. Add BoardModulePkg.dsc to cover the build for new added modules.=20 2. Remove BIOS_ID_GUID macro definition in Guid/BiosId.h. There is no code= to consume it.=20 Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Dong, Eric >Sent: Monday, May 27, 2019 9:13 AM >To: devel@edk2.groups.io >Subject: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg. > >Add new package BoardModulePkg in Platform/Intel folder. This folder >used to keep the board generic modules, such as Cmos, BiosId. > >Add Cmos and BiosId related modules to BoardModulePkg. > > >Eric Dong (3): > Maintainers.txt: Add BoardModulePkg in Platform/Intel/ folder. > Platform/Intel: Add Cmos related modules to BoardModulePkg > Platform/Intel/BoardModulePkg: Add BiosId Module. > > Maintainers.txt | 4 + > .../Intel/BoardModulePkg/BoardModulePkg.dec | 38 ++ > .../BoardModulePkg/Include/Guid/BiosId.h | 59 +++ > .../Include/Library/BiosIdLib.h | 57 ++ > .../Include/Library/CmosAccessLib.h | 106 ++++ > .../Include/Library/PlatformCmosAccessLib.h | 68 +++ > .../Library/BiosIdLib/DxeBiosIdLib.c | 175 +++++++ > .../Library/BiosIdLib/DxeBiosIdLib.inf | 42 ++ > .../Library/BiosIdLib/PeiBiosIdLib.c | 191 +++++++ > .../Library/BiosIdLib/PeiBiosIdLib.inf | 42 ++ > .../Library/CmosAccessLib/CmosAccessLib.c | 486 ++++++++++++++++++ > .../Library/CmosAccessLib/CmosAccessLib.inf | 28 + > .../CmosAccessLib/CmosAccessLibInternal.h | 35 ++ > .../PlatformCmosAccessLibNull.c | 39 ++ > .../PlatformCmosAccessLibNull.inf | 23 + > 15 files changed, 1393 insertions(+) > create mode 100644 Platform/Intel/BoardModulePkg/BoardModulePkg.dec > create mode 100644 Platform/Intel/BoardModulePkg/Include/Guid/BiosId.h > create mode 100644 >Platform/Intel/BoardModulePkg/Include/Library/BiosIdLib.h > create mode 100644 >Platform/Intel/BoardModulePkg/Include/Library/CmosAccessLib.h > create mode 100644 >Platform/Intel/BoardModulePkg/Include/Library/PlatformCmosAccessLib.h > create mode 100644 >Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.c > create mode 100644 >Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.inf > create mode 100644 >Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.c > create mode 100644 >Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.inf > create mode 100644 >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.c > create mode 100644 >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf > create mode 100644 >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLibInter >nal.h > create mode 100644 >Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor >mCmosAccessLibNull.c > create mode 100644 >Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor >mCmosAccessLibNull.inf > >-- >2.21.0.windows.1 > > >