From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 27 May 2019 17:42:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 17:42:37 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 27 May 2019 17:42:38 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 27 May 2019 17:42:37 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 27 May 2019 17:42:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000; Tue, 28 May 2019 08:42:35 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg. Thread-Topic: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg. Thread-Index: AQHVFClQ3AWuAbfC80Sv5gmRcvzAGaZ/srAAgAABZ4A= Date: Tue, 28 May 2019 00:42:34 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4549E3@SHSMSX104.ccr.corp.intel.com> References: <20190527011241.14916-1-eric.dong@intel.com> <15A2B1D15A184189.14260@groups.io> In-Reply-To: <15A2B1D15A184189.14260@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Besides, please submit BZ for the change.=20 >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Tuesday, May 28, 2019 8:39 AM >To: devel@edk2.groups.io; Dong, Eric >Subject: Re: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg. > >Eric: > I have two comments. >1. Add BoardModulePkg.dsc to cover the build for new added modules. >2. Remove BIOS_ID_GUID macro definition in Guid/BiosId.h. There is no cod= e >to consume it. > >Thanks >Liming >>-----Original Message----- >>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>Dong, Eric >>Sent: Monday, May 27, 2019 9:13 AM >>To: devel@edk2.groups.io >>Subject: [edk2-devel] [Patch 0/3] Add modules to BoardModulePkg. >> >>Add new package BoardModulePkg in Platform/Intel folder. This folder >>used to keep the board generic modules, such as Cmos, BiosId. >> >>Add Cmos and BiosId related modules to BoardModulePkg. >> >> >>Eric Dong (3): >> Maintainers.txt: Add BoardModulePkg in Platform/Intel/ folder. >> Platform/Intel: Add Cmos related modules to BoardModulePkg >> Platform/Intel/BoardModulePkg: Add BiosId Module. >> >> Maintainers.txt | 4 + >> .../Intel/BoardModulePkg/BoardModulePkg.dec | 38 ++ >> .../BoardModulePkg/Include/Guid/BiosId.h | 59 +++ >> .../Include/Library/BiosIdLib.h | 57 ++ >> .../Include/Library/CmosAccessLib.h | 106 ++++ >> .../Include/Library/PlatformCmosAccessLib.h | 68 +++ >> .../Library/BiosIdLib/DxeBiosIdLib.c | 175 +++++++ >> .../Library/BiosIdLib/DxeBiosIdLib.inf | 42 ++ >> .../Library/BiosIdLib/PeiBiosIdLib.c | 191 +++++++ >> .../Library/BiosIdLib/PeiBiosIdLib.inf | 42 ++ >> .../Library/CmosAccessLib/CmosAccessLib.c | 486 ++++++++++++++++++ >> .../Library/CmosAccessLib/CmosAccessLib.inf | 28 + >> .../CmosAccessLib/CmosAccessLibInternal.h | 35 ++ >> .../PlatformCmosAccessLibNull.c | 39 ++ >> .../PlatformCmosAccessLibNull.inf | 23 + >> 15 files changed, 1393 insertions(+) >> create mode 100644 Platform/Intel/BoardModulePkg/BoardModulePkg.dec >> create mode 100644 >Platform/Intel/BoardModulePkg/Include/Guid/BiosId.h >> create mode 100644 >>Platform/Intel/BoardModulePkg/Include/Library/BiosIdLib.h >> create mode 100644 >>Platform/Intel/BoardModulePkg/Include/Library/CmosAccessLib.h >> create mode 100644 >>Platform/Intel/BoardModulePkg/Include/Library/PlatformCmosAccessLib.h >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.c >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.inf >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.c >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.inf >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.c >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLibInte >r >>nal.h >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor >>mCmosAccessLibNull.c >> create mode 100644 >>Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platfor >>mCmosAccessLibNull.inf >> >>-- >>2.21.0.windows.1 >> >> >> > > >