public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg
Date: Tue, 28 May 2019 11:44:05 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E455045@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu8E+-koUC__4FCVzO8X8at9tU2J5OuDqVkw6tEiR8MUig@mail.gmail.com>

Ard:
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 28, 2019 7:12 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Leif Lindholm <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg
> 
> On Tue, 28 May 2019 at 13:03, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > > Sent: Tuesday, May 28, 2019 6:06 PM
> > > To: edk2-devel-groups-io <devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>
> > > Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg
> > >
> > > On Tue, 28 May 2019 at 12:00, Liming Gao <liming.gao@intel.com> wrote:
> > > >
> > > > 1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have included them.
> > > > 2. Update Update RPi3 DSC/FDF to refer to Network package segment files
> > > >
> > > > These changes are required, because Network modules have been moved into NetworkPkg.
> > > >
> > >
> > > Am I understanding correctly that all platforms below are now broken
> > > due to the NetworkPkg changes?
> > >
> > Right. Before the change, I send the patch to update platform DSC/FDF to refer to Network segment files,
> > these platform DSC/FDF should not be impacted by Network module movement.
> >
> > After push Network module movement, I find I miss some cases in platform DSC/FDF.
> > So, I send this patch set to clean up the remaining issues. Sorry for the platform break.
> >
> 
> Core edk2 is broken as well:
> 
> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3562/console

Thanks for your note. I scan DSC/FDF again in edk2, and find three missing cases. 
The patches have been sent for review. 


      reply	other threads:[~2019-05-28 11:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  9:58 [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg Liming Gao
2019-05-28  9:58 ` [edk2-platform patch 1/7] BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary Network libs Liming Gao
2019-06-10  8:03   ` Ard Biesheuvel
2019-05-28  9:58 ` [edk2-platform patch 2/7] RDKQemu: Update RDKQemu.dsc " Liming Gao
2019-06-10  9:06   ` [edk2-devel] " Ard Biesheuvel
2019-05-28  9:58 ` [edk2-platform patch 3/7] Hisilicon: Update D06.dsc " Liming Gao
2019-06-10 10:49   ` Ard Biesheuvel
2019-05-28  9:58 ` [edk2-platform patch 4/7] QuarkPlatform: Update Quark dsc " Liming Gao
2019-05-28  9:58 ` [edk2-platform patch 5/7] Vlv2TbltDevicePkg: Update Platform " Liming Gao
2019-05-28 10:04   ` [edk2-devel] " Sun, Zailiang
2019-05-28  9:58 ` [edk2-platform patch 6/7] RaspberryPi: Update RPi3 DSC/FDF to refer to Network package segment files Liming Gao
2019-05-28  9:58 ` [edk2-platform patch 7/7] SoftIron: Update Overdrive1000Board.dsc to refer to new Network module path Liming Gao
2019-06-10 10:41   ` Ard Biesheuvel
2019-05-28 10:05 ` [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg Ard Biesheuvel
2019-05-28 11:03   ` Liming Gao
2019-05-28 11:11     ` Ard Biesheuvel
2019-05-28 11:44       ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E455045@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox