From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Tue, 28 May 2019 23:49:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 23:49:06 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 28 May 2019 23:49:06 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 May 2019 23:49:05 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 May 2019 23:49:05 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Wed, 29 May 2019 14:49:04 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Dong, Eric" CC: "Gao, Liming" , "Oram, Isaac W" , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules. Thread-Topic: [edk2-devel] [Patch 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules. Thread-Index: AQHVFbgrDoBBRfreyEWWYfyAYIQq2aaBk2DQ Date: Wed, 29 May 2019 06:49:03 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E456BD9@SHSMSX104.ccr.corp.intel.com> References: <20190529004754.22332-1-eric.dong@intel.com> In-Reply-To: <20190529004754.22332-1-eric.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Eric: I have some comments.=20 1. DebugFeaturePkg DEC/DSC header description should be DebugFeaturePkg in= stead of DebugAdvancedFeaturePkg 2. DebugFeaturePkg can have one gDebugFeaturePkgTokenSpaceGuid for all PCD= s . You don't need to add another gEfiUsb3DebugPortTokenSpaceGuid.=20 3. Please make PCD TokenNumber are continuous.=20 Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Dong, Eric >Sent: Wednesday, May 29, 2019 8:48 AM >To: devel@edk2.groups.io >Subject: [edk2-devel] [Patch 0/3] [edk2-platforms] Add DebugFeaturePkg to >keep debug related modules. > >Add new package in Platform/Intel/ folder to keep debug related >modules. > >Eric Dong (3): > Platform/Intel/DebugFeaturePkg: Add DebugFeaturePkg > Platform/Intel/DebugFeaturePkg: Add USB3DebugPort related modules. > Platform/Intel/DebugFeaturePkg/AcpiDebug: Change AcpiDebug module > location. > > Maintainers.txt | 4 + > .../AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 6 - > .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 - > .../AcpiDebug/AcpiDebug.asl | 0 > .../AcpiDebug/AcpiDebug.c | 0 > .../AcpiDebug/AcpiDebugDxe.inf | 8 +- > .../AcpiDebug/AcpiDebugSmm.inf | 8 +- > .../AcpiDebug/Readme.txt | 0 > .../Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 64 ++ > .../Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 98 ++ > .../Include/Library/Usb3DebugPortLib.h | 76 ++ > .../Library/Usb3DebugPortParameterLib.h | 56 ++ > .../Library/Usb3DebugPortLib/MiscServices.c | 385 ++++++++ > .../Usb3DebugPortDataTransfer.c | 892 ++++++++++++++++++ > .../Usb3DebugPortInitialize.c | 726 ++++++++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibDxe.c | 454 +++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibDxe.inf | 55 ++ > .../Usb3DebugPortLibDxeIoMmu.c | 828 ++++++++++++++++ > .../Usb3DebugPortLibDxeIoMmu.inf | 63 ++ > .../Usb3DebugPortLibInternal.h | 887 +++++++++++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibNull.c | 103 ++ > .../Usb3DebugPortLib/Usb3DebugPortLibNull.inf | 28 + > .../Usb3DebugPortLib/Usb3DebugPortLibPei.c | 236 +++++ > .../Usb3DebugPortLib/Usb3DebugPortLibPei.inf | 48 + > .../Usb3DebugPortLibPeiIoMmu.c | 440 +++++++++ > .../Usb3DebugPortLibPeiIoMmu.inf | 51 + > .../Usb3DebugPortParameterLibPcd.c | 58 ++ > .../Usb3DebugPortParameterLibPcd.inf | 31 + > 28 files changed, 5591 insertions(+), 17 deletions(-) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebug.asl (100%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebug.c (100%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebugDxe.inf (79%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebugSmm.inf (80%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/Readme.txt (100%) > create mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec > create mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > create mode 100644 >Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortLib.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortParameterL >ib.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/MiscServices.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >DataTransfer.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >Initialize.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxe.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxe.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxeIoMmu.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxeIoMmu.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibInternal.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibNull.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibNull.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPei.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPei.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPeiIoMmu.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPeiIoMmu.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/U >sb3DebugPortParameterLibPcd.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/U >sb3DebugPortParameterLibPcd.inf > >-- >2.21.0.windows.1 > > >