From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Wed, 29 May 2019 07:13:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 07:13:15 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 29 May 2019 07:13:15 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 07:13:15 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 07:13:15 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.10]) with mapi id 14.03.0415.000; Wed, 29 May 2019 22:13:13 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Rodriguez, Christian" Subject: Re: [edk2-devel] [Patch V3 0/2] BaseTools: Add a checking for Sources section in INF file [Part 0/2] Thread-Topic: [edk2-devel] [Patch V3 0/2] BaseTools: Add a checking for Sources section in INF file [Part 0/2] Thread-Index: AQHVEj6u52cG2X9CkEmW9goXGvEvc6aCLEMA Date: Wed, 29 May 2019 14:13:13 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4623F7@SHSMSX104.ccr.corp.intel.com> References: <20190524144027.9552-1-christian.rodriguez@intel.com> In-Reply-To: <20190524144027.9552-1-christian.rodriguez@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGVmNzU1NDItNDM3OS00OWM3LTg5YTctOTE2NzgyYzIxZGVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRlNjMFZtSnI1R3lSRHlITWVKdXlnMnF1TDRqZE54TWxkU256NmQxNldzRW0xTlwvZWNuUkNyRWRDWWtFclRTRkYifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Christian: I have two comments on the commit messages.=20 1. List the change version only in the cover letter. There is no V2, V3 i= n patch commit message.=20 2. Update patch commit message for this patch change. Don't use Part1, Pa= rt2.=20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ch= ristian Rodriguez > Sent: Friday, May 24, 2019 10:40 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/2] BaseTools: Add a checking for Sourc= es section in INF file [Part 0/2] >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1804 >=20 > In V3: Seperate checker and hashing into individual patches > Part 1/2: Contains checker. > Part 2/2: Contains hash feature alignment. > In V2: Enable check for all builds, move conditional to hash invalidatio= n > In the Edk2 INF spec 3.9, it states, All HII Unicode format files > must be listed in [Sources] section. Add a check to see if [Sources] > section lists all the "source" type files of a module. Performance > impact should be minimal with this patch since information is already > being fetched for Makefile purposes. All other information is already > cached in memory. No extra IO time is needed. >=20 > Christian Rodriguez (2): > BaseTools: Add a checking for Sources section in INF file [Part 1/2] > BaseTools: Add a checking for Sources section in INF file [Part 2/2] >=20 > BaseTools/Source/Python/AutoGen/AutoGen.py | 6 +- > BaseTools/Source/Python/AutoGen/GenMake.py | 44 +++++++++++++ > BaseTools/Source/Python/Common/GlobalData.py | 3 +- > BaseTools/Source/Python/build/build.py | 65 ++++++++++++-------- > 4 files changed, 91 insertions(+), 27 deletions(-) >=20 > -- > 2.19.1.windows.1 >=20 >=20 >=20