From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Wed, 29 May 2019 08:07:58 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 08:07:57 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 29 May 2019 08:07:56 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 08:07:57 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 08:07:56 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.192]) with mapi id 14.03.0415.000; Wed, 29 May 2019 23:07:55 +0800 From: "Liming Gao" To: "Gao, Zhichao" , Leif Lindholm , "devel@edk2.groups.io" CC: Bret Barkelew , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , Sean Brogan , Michael Turner Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Index: AQHVFbfnQu/yqpPNJUmrBw9819zXJ6aBbQuAgABAHgCAAIfEMA== Date: Wed, 29 May 2019 15:07:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4634AA@SHSMSX104.ccr.corp.intel.com> References: <20190529004555.45364-1-zhichao.gao@intel.com> <20190529111143.whfxiphgc3y6jap4@bivouac.eciton.net> <3CE959C139B4C44DBEA1810E3AA6F9000B7DB95D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7DB95D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjkxMGQ2N2YtZGJlOC00MzhmLThiN2ItYWRjMjg4MTM1MzQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFpWRWcrRDBhR29Cd2dkdTQrQXdWenpZcXNcL3hLTU1KeDI4bkZMK25ta21Cdk1vRURjQmJEd0IrQmFMb2ZqQ1AifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable No. Please don't touch copyright if you doesn't change the file.=20 > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, May 29, 2019 11:01 PM > To: Leif Lindholm ; devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming ; Sean Brogan ; > Michael Turner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the C= apsulePei >=20 > I just update the date of copyright. And the code in Mu project didn't ad= d its own copyright. > If it is required, I would add it for them. > And I also make some minor changes on it. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Wednesday, May 29, 2019 7:12 PM > > To: devel@edk2.groups.io; Gao, Zhichao > > Cc: Bret Barkelew ; Wang, Jian J > > ; Wu, Hao A ; Ni, Ray > > ; Zeng, Star ; Gao, Liming > > ; Sean Brogan ; > > Michael Turner > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the > > CapsulePei > > > > On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote: > > > From: Bret Barkelew > > > > If this code is from Microsoft... > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1853 > > > > > > Sperate the capsule check function from GetCapsuleDescriptors and nam= e > > > it to AreCapsulesStaged. > > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > > And optimize its to remove the duplicated code. > > > > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > Cc: Ray Ni > > > Cc: Star Zeng > > > Cc: Liming Gao > > > Cc: Sean Brogan > > > Cc: Michael Turner > > > Cc: Bret Barkelew > > > Signed-off-by: Zhichao gao > > > --- > > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 3 +- > > > .../Universal/CapsulePei/CapsulePei.inf | 3 +- > > > .../Universal/CapsulePei/UefiCapsule.c | 357 ++++++++++------= -- > > > 3 files changed, 194 insertions(+), 169 deletions(-) > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > index baf40423af..fc20dd8b92 100644 > > > --- a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > +++ b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > @@ -1,6 +1,6 @@ > > > /** @file > > > > > > -Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > reserved.
> > > +Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > +reserved.
> > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > @@ -30,6 +30,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > #include #include > > > #include > > > +#include > > > #include #include > > > "Common/CommonHeader.h" > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > index 5d43df3075..9c88b3986f 100644 > > > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > @@ -6,7 +6,7 @@ > > > # This external input must be validated carefully to avoid security > > > issue like # buffer overflow, integer overflow. > > > # > > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > reserved.
> > > +# Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > +reserved.
> > > > ...why does Intel get the copyright? > > > > / > > Leif