From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Thu, 30 May 2019 19:10:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2019 19:10:49 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 30 May 2019 19:10:49 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 30 May 2019 19:10:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.247]) with mapi id 14.03.0415.000; Fri, 31 May 2019 10:10:33 +0800 From: "Liming Gao" To: "Dong, Eric" , "devel@edk2.groups.io" Subject: Re: [Patch v2 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules. Thread-Topic: [Patch v2 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules. Thread-Index: AQHVFfDclBnFyYUFVECf6QLP3qm2GKaEf4uw Date: Fri, 31 May 2019 02:10:33 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E467173@SHSMSX104.ccr.corp.intel.com> References: <20190529073337.20780-1-eric.dong@intel.com> In-Reply-To: <20190529073337.20780-1-eric.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This version is good. Reviewed-by: Liming Gao >-----Original Message----- >From: Dong, Eric >Sent: Wednesday, May 29, 2019 3:34 PM >To: devel@edk2.groups.io >Cc: Gao, Liming >Subject: [Patch v2 0/3] [edk2-platforms] Add DebugFeaturePkg to keep >debug related modules. > >Add new package in Platform/Intel/ folder to keep debug related modules. > >V2 change: > Use one gDebugFeaturePkgTokenSpaceGuid for all PCDs in this package. > Make PCD TokenNumber continuous. > >Signed-off-by: Eric Dong >Cc: Liming Gao > >Eric Dong (3): > Platform/Intel/DebugFeaturePkg: Add DebugFeaturePkg > Platform/Intel/DebugFeaturePkg: Add USB3DebugPort related modules. > Platform/Intel/DebugFeaturePkg/AcpiDebug: Change AcpiDebug module > location. > > Maintainers.txt | 4 + > .../AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 6 - > .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 - > .../AcpiDebug/AcpiDebug.asl | 0 > .../AcpiDebug/AcpiDebug.c | 0 > .../AcpiDebug/AcpiDebugDxe.inf | 8 +- > .../AcpiDebug/AcpiDebugSmm.inf | 8 +- > .../AcpiDebug/Readme.txt | 0 > .../Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 65 ++ > .../Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 98 ++ > .../Include/Library/Usb3DebugPortLib.h | 76 ++ > .../Library/Usb3DebugPortParameterLib.h | 56 ++ > .../Library/Usb3DebugPortLib/MiscServices.c | 385 ++++++++ > .../Usb3DebugPortDataTransfer.c | 892 ++++++++++++++++++ > .../Usb3DebugPortInitialize.c | 726 ++++++++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibDxe.c | 454 +++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibDxe.inf | 55 ++ > .../Usb3DebugPortLibDxeIoMmu.c | 828 ++++++++++++++++ > .../Usb3DebugPortLibDxeIoMmu.inf | 63 ++ > .../Usb3DebugPortLibInternal.h | 887 +++++++++++++++++ > .../Usb3DebugPortLib/Usb3DebugPortLibNull.c | 103 ++ > .../Usb3DebugPortLib/Usb3DebugPortLibNull.inf | 28 + > .../Usb3DebugPortLib/Usb3DebugPortLibPei.c | 236 +++++ > .../Usb3DebugPortLib/Usb3DebugPortLibPei.inf | 48 + > .../Usb3DebugPortLibPeiIoMmu.c | 440 +++++++++ > .../Usb3DebugPortLibPeiIoMmu.inf | 51 + > .../Usb3DebugPortParameterLibPcd.c | 58 ++ > .../Usb3DebugPortParameterLibPcd.inf | 31 + > 28 files changed, 5592 insertions(+), 17 deletions(-) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebug.asl (100%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebug.c (100%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebugDxe.inf (79%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/AcpiDebugSmm.inf (80%) > rename Platform/Intel/{AdvancedFeaturePkg =3D> >DebugFeaturePkg}/AcpiDebug/Readme.txt (100%) > create mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec > create mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > create mode 100644 >Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortLib.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortParameterL >ib.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/MiscServices.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >DataTransfer.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >Initialize.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxe.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxe.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxeIoMmu.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibDxeIoMmu.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibInternal.h > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibNull.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibNull.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPei.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPei.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPeiIoMmu.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortLib/Usb3DebugPort >LibPeiIoMmu.inf > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/U >sb3DebugPortParameterLibPcd.c > create mode 100644 >Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/U >sb3DebugPortParameterLibPcd.inf > >-- >2.21.0.windows.1