public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 0/7] update ArmSoftFloatLib to latest upstream version
Date: Mon, 3 Jun 2019 00:32:40 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E468D60@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu9Ew_kj3Un1Fvt+aNUwn-EfWChc6z5ZmXoLwsexNQ09ww@mail.gmail.com>

Ard:

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
>Biesheuvel
>Sent: Saturday, June 01, 2019 12:00 AM
>To: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm
><leif.lindholm@linaro.org>
>Cc: Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>;
>Wang, Jian J <jian.j.wang@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: Re: [edk2-devel] [PATCH v3 0/7] update ArmSoftFloatLib to latest
>upstream version
>
>On Fri, 31 May 2019 at 15:09, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>>
>> On Fri, May 31, 2019 at 02:49:51PM +0200, Ard Biesheuvel wrote:
>> > Currently, our move to OpenSSL 1.1.1b is being blocked by an issue in
>> > the ARM software floating point library, which lacks some intrinsics
>> > that the ARM EABI spec defines.
>> >
>> > Since the code was in pretty sorry state, let's fix this by upgrading
>> > to the very latest version of the core library this code is based on,
>> > dated January 2018 (whereas the NetBSD fork of the old code dates back
>> > to 2002)
>>
>> It is worth mentioning that there is exactly one patch on top of 3e
>> release, and that resolves a syntax error in RICV code (currently
>> unused).
>>
>> I have a couple of really tiny comments on later patches, but many
>> thanks for unbundling this conundrum (and preventing yet anoher fork).
>>
>
>OK I have merged the following patches of this series
>
>85af0b8116f3 ArmPkg: import Berkeley Softfloat library as git submodule
>3cc57695df5a ArmPkg/ArmSoftFloatLib: switch to new version of softfloat
>library
>99243102b467 ArmPkg/ArmSoftFloatLib: remove source files that are no
>longer used
>8594c2073cdb ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble
>ArmV7Support.S
>
>which are the only ones that turn out to be required to build
>OpensslLib for ARM when using Jian latest v5 of the OpenSSL 1.1.1b
>upgrade
>
Great thanks for your effort to resolve it. 

By the way, the patch 6/7, 7/7 are still for this stable tag? They are OK to me. 
I am sure whether we still have the similar cases in MdePkg/MdeModulePkg. 
Can you submit BZ to remove those changes all in Mdekg/MdeModulePkg.

>Thanks all,
>Ard.
>
>


      parent reply	other threads:[~2019-06-03  0:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 12:49 [PATCH v3 0/7] update ArmSoftFloatLib to latest upstream version Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 1/7] ArmPkg: import Berkeley Softfloat library as git submodule Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library Ard Biesheuvel
2019-05-31 13:20   ` Leif Lindholm
2019-05-31 13:22     ` Ard Biesheuvel
2019-05-31 13:26       ` Leif Lindholm
2019-05-31 13:39         ` Ard Biesheuvel
2019-05-31 13:49           ` Leif Lindholm
2019-05-31 14:32             ` Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 3/7] ArmPkg/ArmSoftFloatLib: remove source files that are no longer used Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 4/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 5/7] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 6/7] MdeModulePkg/PeCoffImageEmulator: avoid redeclaration of typedef Ard Biesheuvel
2019-06-03  0:33   ` Liming Gao
2019-05-31 12:49 ` [PATCH v3 7/7] MdePkg: avoid redeclaration of typedefs Ard Biesheuvel
2019-06-03  0:33   ` Liming Gao
2019-05-31 13:09 ` [PATCH v3 0/7] update ArmSoftFloatLib to latest upstream version Leif Lindholm
2019-05-31 16:00   ` [edk2-devel] " Ard Biesheuvel
2019-05-31 16:21     ` Michael D Kinney
2019-05-31 19:28       ` Leif Lindholm
2019-05-31 19:31         ` Michael D Kinney
2019-06-03  0:59         ` Liming Gao
2019-06-03  6:04           ` Ard Biesheuvel
2019-06-03  0:32     ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E468D60@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox