Re: [PATCH v3 6/7] MdeModulePkg/PeCoffImageEmulator: avoid redeclaration of typedef

["Liming Gao" <liming.gao@intel.com>]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>Sent: Friday, May 31, 2019 8:50 PM
>To: devel@edk2.groups.io
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
><lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Wang, Jian J
><jian.j.wang@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Kinney,
>Michael D <michael.d.kinney@intel.com>
>Subject: [PATCH v3 6/7] MdeModulePkg/PeCoffImageEmulator: avoid
>redeclaration of typedef
>
>The usual pattern of defining a protocol in EDK2 is
>
>  typedef struct _FOO_PROTOCOL FOO_PROTOCOL;
>
>  <definitions of protocol methods referring to FOO_PROTOCOL>
>
>  struct _FOO_PROTOCOL {
>    <method 1>
>    <method 2>
>    ...
>   };
>
>However, in the definition of EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL,
>we are deviating from this for no good reason, and instead, the
>struct definition is combined with a redefinition of the first
>typedef, and this is not permitted before C11.
>
>Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>---
> MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>b/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>index 29633e9a8ed4..9ea080eefb56 100644
>--- a/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>+++ b/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>@@ -91,7 +91,7 @@ EFI_STATUS
>
> #define EDKII_PECOFF_IMAGE_EMULATOR_VERSION         0x1
>
>-typedef struct _EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL {
>+struct _EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL {
>   EDKII_PECOFF_IMAGE_EMULATOR_IS_IMAGE_SUPPORTED
>IsImageSupported;
>   EDKII_PECOFF_IMAGE_EMULATOR_REGISTER_IMAGE        RegisterImage;
>   EDKII_PECOFF_IMAGE_EMULATOR_UNREGISTER_IMAGE
>UnregisterImage;
>@@ -100,7 +100,7 @@ typedef struct
>_EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL {
>   UINT32                                            Version;
>   // The machine type implemented by the emulator
>   UINT16                                            MachineType;
>-} EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL;
>+};
>
> extern EFI_GUID gEdkiiPeCoffImageEmulatorProtocolGuid;
>
>--
>2.20.1