[Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Zhiguang Liu]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1686

The bug reporter wish to diaplay nothing as the CPU is virtual

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
 MdeModulePkg/Application/UiApp/FrontPage.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c b/MdeModulePkg/Application/UiApp/FrontPage.c
index 4b95cccb5c..fded763406 100644
--- a/MdeModulePkg/Application/UiApp/FrontPage.c
+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
@@ -621,11 +621,6 @@ UpdateFrontPageBannerStrings (
         HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
         FreePool (NewString);
 
-        ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString);
-        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
-        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
-        FreePool (NewString);
-
         FoundCpu = TRUE;
       }
     }
-- 
2.21.0.windows.1

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ni, Ray]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Monday, June 3, 2019 2:45 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current
> speed
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1686
> 
> The bug reporter wish to diaplay nothing as the CPU is virtual
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  MdeModulePkg/Application/UiApp/FrontPage.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
> b/MdeModulePkg/Application/UiApp/FrontPage.c
> index 4b95cccb5c..fded763406 100644
> --- a/MdeModulePkg/Application/UiApp/FrontPage.c
> +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
> @@ -621,11 +621,6 @@ UpdateFrontPageBannerStrings (
>          HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
>          FreePool (NewString);
> 
> -        ConvertProcessorToString(Type4Record->CurrentSpeed, 6,
> &NewString);
> -        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
> -        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
> -        FreePool (NewString);
> -
>          FoundCpu = TRUE;
>        }
>      }
> --
> 2.21.0.windows.1
> 
> 
> 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ni, Ray]

Zhiguang,
I made a mistake here.
I thought you changed the EmulatorPkg to not display the CPU speed
but actually what you changed impacts all platforms.
With this change, OVMF cannot show the CPU speed either.

Can you please roll back this changes (if it was pushed in)?

To close the Bugzilla, I think you need to find out other ways that only
impact EmulatorPkg. Or does it really matter to show a 1234Hz in
Emulator UI?

Sorry I didn't give the comments earlier.

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Monday, June 3, 2019 2:52 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Zhiguang Liu
> > Sent: Monday, June 3, 2019 2:45 PM
> > To: devel@edk2.groups.io
> > Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1686
> >
> > The bug reporter wish to diaplay nothing as the CPU is virtual
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> >  MdeModulePkg/Application/UiApp/FrontPage.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
> > b/MdeModulePkg/Application/UiApp/FrontPage.c
> > index 4b95cccb5c..fded763406 100644
> > --- a/MdeModulePkg/Application/UiApp/FrontPage.c
> > +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
> > @@ -621,11 +621,6 @@ UpdateFrontPageBannerStrings (
> >          HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> > (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
> >          FreePool (NewString);
> >
> > -        ConvertProcessorToString(Type4Record->CurrentSpeed, 6,
> > &NewString);
> > -        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
> > -        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> > (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
> > -        FreePool (NewString);
> > -
> >          FoundCpu = TRUE;
> >        }
> >      }
> > --
> > 2.21.0.windows.1
> >
> >
> >
> 
> 
> 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ard Biesheuvel]

On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni@intel.com> wrote:
>
> Zhiguang,
> I made a mistake here.
> I thought you changed the EmulatorPkg to not display the CPU speed
> but actually what you changed impacts all platforms.
> With this change, OVMF cannot show the CPU speed either.
>
> Can you please roll back this changes (if it was pushed in)?
>

OK, this patch mentions EmulatorPkg in the commit log but actually
modifies MdeModulePkg, and it was pushed during the hard freeze.

Seriously, how did this happen? I would expect everyone with commit
rights to the repository to be aware of the stable tag rules and
release cadence.

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Liming Gao]

Ard:

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> Sent: Tuesday, June 4, 2019 7:53 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
> <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> 
> On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni@intel.com> wrote:
> >
> > Zhiguang,
> > I made a mistake here.
> > I thought you changed the EmulatorPkg to not display the CPU speed
> > but actually what you changed impacts all platforms.
> > With this change, OVMF cannot show the CPU speed either.
> >
> > Can you please roll back this changes (if it was pushed in)?
> >
> 
> OK, this patch mentions EmulatorPkg in the commit log but actually
> modifies MdeModulePkg, and it was pushed during the hard freeze.
> 
> Seriously, how did this happen? I would expect everyone with commit
> rights to the repository to be aware of the stable tag rules and
> release cadence.

This patch is like a bug fix. But, this patch changes the code in MdeModulePkg. 
It requires MdeModulePkg package maintainer and reviewer to review it. 
And, it impacts the different platforms. So, I also prefer to roll back this change. 

> 
> 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ard Biesheuvel]

On Tue, 4 Jun 2019 at 15:40, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> > Sent: Tuesday, June 4, 2019 7:53 PM
> > To: edk2-devel-groups-io <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
> > <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> >
> > On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni@intel.com> wrote:
> > >
> > > Zhiguang,
> > > I made a mistake here.
> > > I thought you changed the EmulatorPkg to not display the CPU speed
> > > but actually what you changed impacts all platforms.
> > > With this change, OVMF cannot show the CPU speed either.
> > >
> > > Can you please roll back this changes (if it was pushed in)?
> > >
> >
> > OK, this patch mentions EmulatorPkg in the commit log but actually
> > modifies MdeModulePkg, and it was pushed during the hard freeze.
> >
> > Seriously, how did this happen? I would expect everyone with commit
> > rights to the repository to be aware of the stable tag rules and
> > release cadence.
>
> This patch is like a bug fix.

How so? Why does it qualify as a bug fix that can be applied during
the hard freeze period?

> But, this patch changes the code in MdeModulePkg.
> It requires MdeModulePkg package maintainer and reviewer to review it.
> And, it impacts the different platforms. So, I also prefer to roll back this change.
>

Agreed.


> >
> > 
>

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Liming Gao]

Ard:

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> Sent: Tuesday, June 4, 2019 9:42 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Laszlo Ersek <lersek@redhat.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Andrew Fish <afish@apple.com>
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> 
> On Tue, 4 Jun 2019 at 15:40, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > Ard:
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> > > Sent: Tuesday, June 4, 2019 7:53 PM
> > > To: edk2-devel-groups-io <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
> > > <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> > >
> > > On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni@intel.com> wrote:
> > > >
> > > > Zhiguang,
> > > > I made a mistake here.
> > > > I thought you changed the EmulatorPkg to not display the CPU speed
> > > > but actually what you changed impacts all platforms.
> > > > With this change, OVMF cannot show the CPU speed either.
> > > >
> > > > Can you please roll back this changes (if it was pushed in)?
> > > >
> > >
> > > OK, this patch mentions EmulatorPkg in the commit log but actually
> > > modifies MdeModulePkg, and it was pushed during the hard freeze.
> > >
> > > Seriously, how did this happen? I would expect everyone with commit
> > > rights to the repository to be aware of the stable tag rules and
> > > release cadence.
> >
> > This patch is like a bug fix.
> 
> How so? Why does it qualify as a bug fix that can be applied during
> the hard freeze period?

There is no definition now. Some discussion is related to this topic.
https://edk2.groups.io/g/devel/message/41276?p=,,,20,0,0,0::Created,,edk2-stable201905,20,2,20,31653140

> 
> > But, this patch changes the code in MdeModulePkg.
> > It requires MdeModulePkg package maintainer and reviewer to review it.
> > And, it impacts the different platforms. So, I also prefer to roll back this change.
> >
> 
> Agreed.
> 
> 
> > >
> > >
> >
> 
> 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ni, Ray]

Hi everyone,

Hao pushed the patch because:
1. it's a bug fix
2. it got a R-b.
I don't think it's his fault.

For #1, it's gap in process.
For #2, it's my fault. Because even the patch title says EmulatorPkg but the patch itself changes MdeModulePkg, I am still the person who can approve changes in both packages.

In Maintainers.txt:
R: Ray Ni <ray.ni@intel.com>
  (especially for Bus, Universal/Console, Universal/Disk,
   Universal/BdsDxe and related libraries, header files)

The UiApp actually is not in the "especially" part, but the word "especially"
means I can also R-b to other components. In fact, I am not quite qualified on
the other components, e.g.: UiApp.
So I propose to assign clear reviewers for each components in MdeModulePkg.
What do you think?

Thanks,
Ray

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Laszlo Ersek]

On 06/05/19 03:10, Ni, Ray wrote:
> Hi everyone,
> 
> Hao pushed the patch because:
> 1. it's a bug fix
> 2. it got a R-b.
> I don't think it's his fault.
> 
> For #1, it's gap in process.
> For #2, it's my fault. Because even the patch title says EmulatorPkg but the patch itself changes MdeModulePkg, I am still the person who can approve changes in both packages.
> 
> In Maintainers.txt:
> R: Ray Ni <ray.ni@intel.com>
>   (especially for Bus, Universal/Console, Universal/Disk,
>    Universal/BdsDxe and related libraries, header files)
> 
> The UiApp actually is not in the "especially" part, but the word "especially"
> means I can also R-b to other components. In fact, I am not quite qualified on
> the other components, e.g.: UiApp.
> So I propose to assign clear reviewers for each components in MdeModulePkg.
> What do you think?

Fully agreed. MdeModulePkg is huge and we should have fine-grained
maintainership assignments.

Thanks
Laszlo

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Zeng, Star]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 5, 2019 4:03 PM
> To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>;
> ard.biesheuvel@linaro.org; Leif Lindholm <leif.lindholm@linaro.org>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Andrew Fish <afish@apple.com>
> Cc: devel@edk2.groups.io
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> On 06/05/19 03:10, Ni, Ray wrote:
> > Hi everyone,
> >
> > Hao pushed the patch because:
> > 1. it's a bug fix
> > 2. it got a R-b.
> > I don't think it's his fault.
> >
> > For #1, it's gap in process.
> > For #2, it's my fault. Because even the patch title says EmulatorPkg but the
> patch itself changes MdeModulePkg, I am still the person who can approve
> changes in both packages.
> >
> > In Maintainers.txt:
> > R: Ray Ni <ray.ni@intel.com>
> >   (especially for Bus, Universal/Console, Universal/Disk,
> >    Universal/BdsDxe and related libraries, header files)
> >
> > The UiApp actually is not in the "especially" part, but the word "especially"
> > means I can also R-b to other components. In fact, I am not quite
> > qualified on the other components, e.g.: UiApp.
> > So I propose to assign clear reviewers for each components in
> MdeModulePkg.
> > What do you think?
> 
> Fully agreed. MdeModulePkg is huge and we should have fine-grained
> maintainership assignments.

I also agree.

> 
> Thanks
> Laszlo
> 
> 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Wu, Hao A]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zeng, Star
> Sent: Wednesday, June 05, 2019 10:31 PM
> To: devel@edk2.groups.io; lersek@redhat.com; Ni, Ray; Gao, Liming;
> ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael D; Liu, Zhiguang;
> Justen, Jordan L; Andrew Fish
> Cc: Zeng, Star
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Laszlo Ersek
> > Sent: Wednesday, June 5, 2019 4:03 PM
> > To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>;
> > ard.biesheuvel@linaro.org; Leif Lindholm <leif.lindholm@linaro.org>;
> Kinney,
> > Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> > Andrew Fish <afish@apple.com>
> > Cc: devel@edk2.groups.io
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > On 06/05/19 03:10, Ni, Ray wrote:
> > > Hi everyone,
> > >
> > > Hao pushed the patch because:
> > > 1. it's a bug fix
> > > 2. it got a R-b.
> > > I don't think it's his fault.
> > >
> > > For #1, it's gap in process.
> > > For #2, it's my fault. Because even the patch title says EmulatorPkg but
> the
> > patch itself changes MdeModulePkg, I am still the person who can approve
> > changes in both packages.
> > >
> > > In Maintainers.txt:
> > > R: Ray Ni <ray.ni@intel.com>
> > >   (especially for Bus, Universal/Console, Universal/Disk,
> > >    Universal/BdsDxe and related libraries, header files)
> > >
> > > The UiApp actually is not in the "especially" part, but the word
> "especially"
> > > means I can also R-b to other components. In fact, I am not quite
> > > qualified on the other components, e.g.: UiApp.
> > > So I propose to assign clear reviewers for each components in
> > MdeModulePkg.
> > > What do you think?
> >
> > Fully agreed. MdeModulePkg is huge and we should have fine-grained
> > maintainership assignments.
> 
> I also agree.

Thanks all.

For the review ownership refinement in the MdeModulePkg, how about the
below steps:

1. Work out a major feature list for the MdeModulePkg
2. Call for owners for every item in the list.


A quick and coarse list of major features can be:

(Just a draft, some key features may be missing or some listed features
may not be considered as major ones. Feedbacks are welcomed.)

Acpi
Bds
Capsule
Compress
Console
Core (PeiCore, DxeCore, PiSmmCore and etc.)
Device (peripheral & storage)
Disk
HII
LockBox
Memory
PCD
PCI bus
Reset
S3
SMBIOS
SMM
Status Code
UI
Variable
Misc (all the components that do not fit in the above items)


Any feedbacks/suggestions for such proposal?

Best Regards,
Hao Wu

> 
> >
> > Thanks
> > Laszlo
> >
> >
> 
> 
> 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Yao, Jiewen]

Good list.

What does "memory" mean ? MemoryTest ?

How about put "LockBox" into "S3"?

How about list "EBC" as standalone component?


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Monday, June 10, 2019 2:02 PM
> To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>;
> lersek@redhat.com; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Zeng, Star
> > Sent: Wednesday, June 05, 2019 10:31 PM
> > To: devel@edk2.groups.io; lersek@redhat.com; Ni, Ray; Gao, Liming;
> > ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael D; Liu,
> Zhiguang;
> > Justen, Jordan L; Andrew Fish
> > Cc: Zeng, Star
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> > > Laszlo Ersek
> > > Sent: Wednesday, June 5, 2019 4:03 PM
> > > To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>;
> > > ard.biesheuvel@linaro.org; Leif Lindholm <leif.lindholm@linaro.org>;
> > Kinney,
> > > Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> > > Andrew Fish <afish@apple.com>
> > > Cc: devel@edk2.groups.io
> > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > > current speed
> > >
> > > On 06/05/19 03:10, Ni, Ray wrote:
> > > > Hi everyone,
> > > >
> > > > Hao pushed the patch because:
> > > > 1. it's a bug fix
> > > > 2. it got a R-b.
> > > > I don't think it's his fault.
> > > >
> > > > For #1, it's gap in process.
> > > > For #2, it's my fault. Because even the patch title says EmulatorPkg but
> > the
> > > patch itself changes MdeModulePkg, I am still the person who can
> approve
> > > changes in both packages.
> > > >
> > > > In Maintainers.txt:
> > > > R: Ray Ni <ray.ni@intel.com>
> > > >   (especially for Bus, Universal/Console, Universal/Disk,
> > > >    Universal/BdsDxe and related libraries, header files)
> > > >
> > > > The UiApp actually is not in the "especially" part, but the word
> > "especially"
> > > > means I can also R-b to other components. In fact, I am not quite
> > > > qualified on the other components, e.g.: UiApp.
> > > > So I propose to assign clear reviewers for each components in
> > > MdeModulePkg.
> > > > What do you think?
> > >
> > > Fully agreed. MdeModulePkg is huge and we should have fine-grained
> > > maintainership assignments.
> >
> > I also agree.
> 
> Thanks all.
> 
> For the review ownership refinement in the MdeModulePkg, how about the
> below steps:
> 
> 1. Work out a major feature list for the MdeModulePkg
> 2. Call for owners for every item in the list.
> 
> 
> A quick and coarse list of major features can be:
> 
> (Just a draft, some key features may be missing or some listed features
> may not be considered as major ones. Feedbacks are welcomed.)
> 
> Acpi
> Bds
> Capsule
> Compress
> Console
> Core (PeiCore, DxeCore, PiSmmCore and etc.)
> Device (peripheral & storage)
> Disk
> HII
> LockBox
> Memory
> PCD
> PCI bus
> Reset
> S3
> SMBIOS
> SMM
> Status Code
> UI
> Variable
> Misc (all the components that do not fit in the above items)
> 
> 
> Any feedbacks/suggestions for such proposal?
> 
> Best Regards,
> Hao Wu
> 
> >
> > >
> > > Thanks
> > > Laszlo
> > >
> > >
> >
> >
> >
> 
> 
> 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Wu, Hao A]

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Monday, June 10, 2019 2:13 PM
> To: devel@edk2.groups.io; Wu, Hao A; Zeng, Star; lersek@redhat.com; Ni,
> Ray; Gao, Liming; ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael
> D; Liu, Zhiguang; Justen, Jordan L; Andrew Fish
> Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> Good list.

Thanks Jiewen,

> 
> What does "memory" mean ? MemoryTest ?

Not only MemoryTest, I was intended to count components like memory
allocation, memory profile (contents within MdeModulePkg/Core/Pei/Memory &
MdeModulePkg/Core/Dxe/Mem) and etc. into this category as well.

But I am not sure if such classification makes sense.

> 
> How about put "LockBox" into "S3"?

Agree.

> 
> How about list "EBC" as standalone component?

Agree. Thanks for the reminder.

Best Regards,
Hao Wu

> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Monday, June 10, 2019 2:02 PM
> > To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>;
> > lersek@redhat.com; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> > <leif.lindholm@linaro.org>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > <afish@apple.com>
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> > > Zeng, Star
> > > Sent: Wednesday, June 05, 2019 10:31 PM
> > > To: devel@edk2.groups.io; lersek@redhat.com; Ni, Ray; Gao, Liming;
> > > ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael D; Liu,
> > Zhiguang;
> > > Justen, Jordan L; Andrew Fish
> > > Cc: Zeng, Star
> > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > > current speed
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > Of
> > > > Laszlo Ersek
> > > > Sent: Wednesday, June 5, 2019 4:03 PM
> > > > To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>;
> > > > ard.biesheuvel@linaro.org; Leif Lindholm <leif.lindholm@linaro.org>;
> > > Kinney,
> > > > Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > > <zhiguang.liu@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>;
> > > > Andrew Fish <afish@apple.com>
> > > > Cc: devel@edk2.groups.io
> > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > > > current speed
> > > >
> > > > On 06/05/19 03:10, Ni, Ray wrote:
> > > > > Hi everyone,
> > > > >
> > > > > Hao pushed the patch because:
> > > > > 1. it's a bug fix
> > > > > 2. it got a R-b.
> > > > > I don't think it's his fault.
> > > > >
> > > > > For #1, it's gap in process.
> > > > > For #2, it's my fault. Because even the patch title says EmulatorPkg
> but
> > > the
> > > > patch itself changes MdeModulePkg, I am still the person who can
> > approve
> > > > changes in both packages.
> > > > >
> > > > > In Maintainers.txt:
> > > > > R: Ray Ni <ray.ni@intel.com>
> > > > >   (especially for Bus, Universal/Console, Universal/Disk,
> > > > >    Universal/BdsDxe and related libraries, header files)
> > > > >
> > > > > The UiApp actually is not in the "especially" part, but the word
> > > "especially"
> > > > > means I can also R-b to other components. In fact, I am not quite
> > > > > qualified on the other components, e.g.: UiApp.
> > > > > So I propose to assign clear reviewers for each components in
> > > > MdeModulePkg.
> > > > > What do you think?
> > > >
> > > > Fully agreed. MdeModulePkg is huge and we should have fine-grained
> > > > maintainership assignments.
> > >
> > > I also agree.
> >
> > Thanks all.
> >
> > For the review ownership refinement in the MdeModulePkg, how about
> the
> > below steps:
> >
> > 1. Work out a major feature list for the MdeModulePkg
> > 2. Call for owners for every item in the list.
> >
> >
> > A quick and coarse list of major features can be:
> >
> > (Just a draft, some key features may be missing or some listed features
> > may not be considered as major ones. Feedbacks are welcomed.)
> >
> > Acpi
> > Bds
> > Capsule
> > Compress
> > Console
> > Core (PeiCore, DxeCore, PiSmmCore and etc.)
> > Device (peripheral & storage)
> > Disk
> > HII
> > LockBox
> > Memory
> > PCD
> > PCI bus
> > Reset
> > S3
> > SMBIOS
> > SMM
> > Status Code
> > UI
> > Variable
> > Misc (all the components that do not fit in the above items)
> >
> >
> > Any feedbacks/suggestions for such proposal?
> >
> > Best Regards,
> > Hao Wu
> >
> > >
> > > >
> > > > Thanks
> > > > Laszlo
> > > >
> > > >
> > >
> > >
> > >
> >
> >
> > 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ni, Ray]

Hao,
Can you please list the detailed sub-directories/modules/libraries for each major feature, including those that are not covered by the major features? This avoid misunderstanding and is also needed by the Maintainers.txt.

Thanks,
Ray


> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, June 10, 2019 2:20 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Zeng, Star
> <star.zeng@intel.com>; lersek@redhat.com; Ni, Ray <ray.ni@intel.com>;
> Gao, Liming <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif
> Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>
> Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> > -----Original Message-----
> > From: Yao, Jiewen
> > Sent: Monday, June 10, 2019 2:13 PM
> > To: devel@edk2.groups.io; Wu, Hao A; Zeng, Star; lersek@redhat.com;
> > Ni, Ray; Gao, Liming; ard.biesheuvel@linaro.org; Leif Lindholm;
> > Kinney, Michael D; Liu, Zhiguang; Justen, Jordan L; Andrew Fish
> > Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the
> > cpu current speed
> >
> > Good list.
> 
> Thanks Jiewen,
> 
> >
> > What does "memory" mean ? MemoryTest ?
> 
> Not only MemoryTest, I was intended to count components like memory
> allocation, memory profile (contents within
> MdeModulePkg/Core/Pei/Memory &
> MdeModulePkg/Core/Dxe/Mem) and etc. into this category as well.
> 
> But I am not sure if such classification makes sense.
> 
> >
> > How about put "LockBox" into "S3"?
> 
> Agree.
> 
> >
> > How about list "EBC" as standalone component?
> 
> Agree. Thanks for the reminder.
> 
> Best Regards,
> Hao Wu
> 
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Wu, Hao A
> > > Sent: Monday, June 10, 2019 2:02 PM
> > > To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>;
> > > lersek@redhat.com; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> > > <leif.lindholm@linaro.org>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > <zhiguang.liu@intel.com>; Justen, Jordan L
> > > <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the
> > > cpu current speed
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > Of
> > > > Zeng, Star
> > > > Sent: Wednesday, June 05, 2019 10:31 PM
> > > > To: devel@edk2.groups.io; lersek@redhat.com; Ni, Ray; Gao, Liming;
> > > > ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael D; Liu,
> > > Zhiguang;
> > > > Justen, Jordan L; Andrew Fish
> > > > Cc: Zeng, Star
> > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay
> > > > the cpu current speed
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > > > Behalf
> > > Of
> > > > > Laszlo Ersek
> > > > > Sent: Wednesday, June 5, 2019 4:03 PM
> > > > > To: Ni, Ray <ray.ni@intel.com>; Gao, Liming
> > > > > <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> > > > > <leif.lindholm@linaro.org>;
> > > > Kinney,
> > > > > Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > > > <zhiguang.liu@intel.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>;
> > > > > Andrew Fish <afish@apple.com>
> > > > > Cc: devel@edk2.groups.io
> > > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay
> > > > > the cpu current speed
> > > > >
> > > > > On 06/05/19 03:10, Ni, Ray wrote:
> > > > > > Hi everyone,
> > > > > >
> > > > > > Hao pushed the patch because:
> > > > > > 1. it's a bug fix
> > > > > > 2. it got a R-b.
> > > > > > I don't think it's his fault.
> > > > > >
> > > > > > For #1, it's gap in process.
> > > > > > For #2, it's my fault. Because even the patch title says
> > > > > > EmulatorPkg
> > but
> > > > the
> > > > > patch itself changes MdeModulePkg, I am still the person who can
> > > approve
> > > > > changes in both packages.
> > > > > >
> > > > > > In Maintainers.txt:
> > > > > > R: Ray Ni <ray.ni@intel.com>
> > > > > >   (especially for Bus, Universal/Console, Universal/Disk,
> > > > > >    Universal/BdsDxe and related libraries, header files)
> > > > > >
> > > > > > The UiApp actually is not in the "especially" part, but the
> > > > > > word
> > > > "especially"
> > > > > > means I can also R-b to other components. In fact, I am not
> > > > > > quite qualified on the other components, e.g.: UiApp.
> > > > > > So I propose to assign clear reviewers for each components in
> > > > > MdeModulePkg.
> > > > > > What do you think?
> > > > >
> > > > > Fully agreed. MdeModulePkg is huge and we should have
> > > > > fine-grained maintainership assignments.
> > > >
> > > > I also agree.
> > >
> > > Thanks all.
> > >
> > > For the review ownership refinement in the MdeModulePkg, how about
> > the
> > > below steps:
> > >
> > > 1. Work out a major feature list for the MdeModulePkg 2. Call for
> > > owners for every item in the list.
> > >
> > >
> > > A quick and coarse list of major features can be:
> > >
> > > (Just a draft, some key features may be missing or some listed
> > > features may not be considered as major ones. Feedbacks are
> > > welcomed.)
> > >
> > > Acpi
> > > Bds
> > > Capsule
> > > Compress
> > > Console
> > > Core (PeiCore, DxeCore, PiSmmCore and etc.) Device (peripheral &
> > > storage) Disk HII LockBox Memory PCD PCI bus Reset
> > > S3
> > > SMBIOS
> > > SMM
> > > Status Code
> > > UI
> > > Variable
> > > Misc (all the components that do not fit in the above items)
> > >
> > >
> > > Any feedbacks/suggestions for such proposal?
> > >
> > > Best Regards,
> > > Hao Wu
> > >
> > > >
> > > > >
> > > > > Thanks
> > > > > Laszlo
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > >
> > >
> > > 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Wu, Hao A]

> -----Original Message-----
> From: Ni, Ray
> Sent: Monday, June 10, 2019 3:16 PM
> To: Wu, Hao A; Yao, Jiewen; devel@edk2.groups.io; Zeng, Star;
> lersek@redhat.com; Gao, Liming; ard.biesheuvel@linaro.org; Leif Lindholm;
> Kinney, Michael D; Liu, Zhiguang; Justen, Jordan L; Andrew Fish
> Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> Hao,
> Can you please list the detailed sub-directories/modules/libraries for each
> major feature, including those that are not covered by the major features?
> This avoid misunderstanding and is also needed by the Maintainers.txt.

Hello Ray,

Okay. I can do that.

But I would like to collect some feedbacks on significant missing feature
in the list or some suggestion on the granularity of the feature first
before your request.

How does it sound to you?

Best Regards,
Hao Wu

> 
> Thanks,
> Ray
> 
> 
> > -----Original Message-----
> > From: Wu, Hao A
> > Sent: Monday, June 10, 2019 2:20 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Zeng,
> Star
> > <star.zeng@intel.com>; lersek@redhat.com; Ni, Ray <ray.ni@intel.com>;
> > Gao, Liming <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif
> > Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > <afish@apple.com>
> > Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > > -----Original Message-----
> > > From: Yao, Jiewen
> > > Sent: Monday, June 10, 2019 2:13 PM
> > > To: devel@edk2.groups.io; Wu, Hao A; Zeng, Star; lersek@redhat.com;
> > > Ni, Ray; Gao, Liming; ard.biesheuvel@linaro.org; Leif Lindholm;
> > > Kinney, Michael D; Liu, Zhiguang; Justen, Jordan L; Andrew Fish
> > > Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the
> > > cpu current speed
> > >
> > > Good list.
> >
> > Thanks Jiewen,
> >
> > >
> > > What does "memory" mean ? MemoryTest ?
> >
> > Not only MemoryTest, I was intended to count components like memory
> > allocation, memory profile (contents within
> > MdeModulePkg/Core/Pei/Memory &
> > MdeModulePkg/Core/Dxe/Mem) and etc. into this category as well.
> >
> > But I am not sure if such classification makes sense.
> >
> > >
> > > How about put "LockBox" into "S3"?
> >
> > Agree.
> >
> > >
> > > How about list "EBC" as standalone component?
> >
> > Agree. Thanks for the reminder.
> >
> > Best Regards,
> > Hao Wu
> >
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Wu, Hao A
> > > > Sent: Monday, June 10, 2019 2:02 PM
> > > > To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>;
> > > > lersek@redhat.com; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> > > > <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> > > > <leif.lindholm@linaro.org>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > > <zhiguang.liu@intel.com>; Justen, Jordan L
> > > > <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the
> > > > cpu current speed
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> Behalf
> > > Of
> > > > > Zeng, Star
> > > > > Sent: Wednesday, June 05, 2019 10:31 PM
> > > > > To: devel@edk2.groups.io; lersek@redhat.com; Ni, Ray; Gao, Liming;
> > > > > ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael D; Liu,
> > > > Zhiguang;
> > > > > Justen, Jordan L; Andrew Fish
> > > > > Cc: Zeng, Star
> > > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay
> > > > > the cpu current speed
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > > > > Behalf
> > > > Of
> > > > > > Laszlo Ersek
> > > > > > Sent: Wednesday, June 5, 2019 4:03 PM
> > > > > > To: Ni, Ray <ray.ni@intel.com>; Gao, Liming
> > > > > > <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> > > > > > <leif.lindholm@linaro.org>;
> > > > > Kinney,
> > > > > > Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > > > > <zhiguang.liu@intel.com>; Justen, Jordan L
> > > <jordan.l.justen@intel.com>;
> > > > > > Andrew Fish <afish@apple.com>
> > > > > > Cc: devel@edk2.groups.io
> > > > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay
> > > > > > the cpu current speed
> > > > > >
> > > > > > On 06/05/19 03:10, Ni, Ray wrote:
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > Hao pushed the patch because:
> > > > > > > 1. it's a bug fix
> > > > > > > 2. it got a R-b.
> > > > > > > I don't think it's his fault.
> > > > > > >
> > > > > > > For #1, it's gap in process.
> > > > > > > For #2, it's my fault. Because even the patch title says
> > > > > > > EmulatorPkg
> > > but
> > > > > the
> > > > > > patch itself changes MdeModulePkg, I am still the person who can
> > > > approve
> > > > > > changes in both packages.
> > > > > > >
> > > > > > > In Maintainers.txt:
> > > > > > > R: Ray Ni <ray.ni@intel.com>
> > > > > > >   (especially for Bus, Universal/Console, Universal/Disk,
> > > > > > >    Universal/BdsDxe and related libraries, header files)
> > > > > > >
> > > > > > > The UiApp actually is not in the "especially" part, but the
> > > > > > > word
> > > > > "especially"
> > > > > > > means I can also R-b to other components. In fact, I am not
> > > > > > > quite qualified on the other components, e.g.: UiApp.
> > > > > > > So I propose to assign clear reviewers for each components in
> > > > > > MdeModulePkg.
> > > > > > > What do you think?
> > > > > >
> > > > > > Fully agreed. MdeModulePkg is huge and we should have
> > > > > > fine-grained maintainership assignments.
> > > > >
> > > > > I also agree.
> > > >
> > > > Thanks all.
> > > >
> > > > For the review ownership refinement in the MdeModulePkg, how
> about
> > > the
> > > > below steps:
> > > >
> > > > 1. Work out a major feature list for the MdeModulePkg 2. Call for
> > > > owners for every item in the list.
> > > >
> > > >
> > > > A quick and coarse list of major features can be:
> > > >
> > > > (Just a draft, some key features may be missing or some listed
> > > > features may not be considered as major ones. Feedbacks are
> > > > welcomed.)
> > > >
> > > > Acpi
> > > > Bds
> > > > Capsule
> > > > Compress
> > > > Console
> > > > Core (PeiCore, DxeCore, PiSmmCore and etc.) Device (peripheral &
> > > > storage) Disk HII LockBox Memory PCD PCI bus Reset
> > > > S3
> > > > SMBIOS
> > > > SMM
> > > > Status Code
> > > > UI
> > > > Variable
> > > > Misc (all the components that do not fit in the above items)
> > > >
> > > >
> > > > Any feedbacks/suggestions for such proposal?
> > > >
> > > > Best Regards,
> > > > Hao Wu
> > > >
> > > > >
> > > > > >
> > > > > > Thanks
> > > > > > Laszlo
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > 

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ni, Ray]

> > Hao,
> > Can you please list the detailed sub-directories/modules/libraries for
> > each major feature, including those that are not covered by the major
> features?
> > This avoid misunderstanding and is also needed by the Maintainers.txt.
> 
> Hello Ray,
> 
> Okay. I can do that.
> 
> But I would like to collect some feedbacks on significant missing feature in
> the list or some suggestion on the granularity of the feature first before your
> request.

I am ok.

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ard Biesheuvel]

On Mon, 10 Jun 2019 at 09:33, Ni, Ray <ray.ni@intel.com> wrote:
>
> > > Hao,
> > > Can you please list the detailed sub-directories/modules/libraries for
> > > each major feature, including those that are not covered by the major
> > features?
> > > This avoid misunderstanding and is also needed by the Maintainers.txt.
> >
> > Hello Ray,
> >
> > Okay. I can do that.
> >
> > But I would like to collect some feedbacks on significant missing feature in
> > the list or some suggestion on the granularity of the feature first before your
> > request.
>
> I am ok.
>

That sounds like a good idea.

But currrently, this discussion is taking place in the context of the
thread '[edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
current speed' which may not be of interest to everybody. So could you
please start a new [RFC] thread with the proposed subdivision, and
keep the same people on cc? Thanks.

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Wu, Hao A]

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Monday, June 10, 2019 3:37 PM
> To: Ni, Ray
> Cc: Wu, Hao A; Yao, Jiewen; devel@edk2.groups.io; Zeng, Star;
> lersek@redhat.com; Gao, Liming; Leif Lindholm; Kinney, Michael D; Liu,
> Zhiguang; Justen, Jordan L; Andrew Fish
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> On Mon, 10 Jun 2019 at 09:33, Ni, Ray <ray.ni@intel.com> wrote:
> >
> > > > Hao,
> > > > Can you please list the detailed sub-directories/modules/libraries for
> > > > each major feature, including those that are not covered by the major
> > > features?
> > > > This avoid misunderstanding and is also needed by the Maintainers.txt.
> > >
> > > Hello Ray,
> > >
> > > Okay. I can do that.
> > >
> > > But I would like to collect some feedbacks on significant missing feature in
> > > the list or some suggestion on the granularity of the feature first before
> your
> > > request.
> >
> > I am ok.
> >
> 
> That sounds like a good idea.
> 
> But currrently, this discussion is taking place in the context of the
> thread '[edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed' which may not be of interest to everybody. So could you
> please start a new [RFC] thread with the proposed subdivision, and
> keep the same people on cc? Thanks.

Thanks, done by:
https://edk2.groups.io/g/devel/message/42080

Best Regards,
Hao Wu

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Ard Biesheuvel]

On Mon, 10 Jun 2019 at 10:07, Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> > -----Original Message-----
> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > Sent: Monday, June 10, 2019 3:37 PM
> > To: Ni, Ray
> > Cc: Wu, Hao A; Yao, Jiewen; devel@edk2.groups.io; Zeng, Star;
> > lersek@redhat.com; Gao, Liming; Leif Lindholm; Kinney, Michael D; Liu,
> > Zhiguang; Justen, Jordan L; Andrew Fish
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > On Mon, 10 Jun 2019 at 09:33, Ni, Ray <ray.ni@intel.com> wrote:
> > >
> > > > > Hao,
> > > > > Can you please list the detailed sub-directories/modules/libraries for
> > > > > each major feature, including those that are not covered by the major
> > > > features?
> > > > > This avoid misunderstanding and is also needed by the Maintainers.txt.
> > > >
> > > > Hello Ray,
> > > >
> > > > Okay. I can do that.
> > > >
> > > > But I would like to collect some feedbacks on significant missing feature in
> > > > the list or some suggestion on the granularity of the feature first before
> > your
> > > > request.
> > >
> > > I am ok.
> > >
> >
> > That sounds like a good idea.
> >
> > But currrently, this discussion is taking place in the context of the
> > thread '[edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed' which may not be of interest to everybody. So could you
> > please start a new [RFC] thread with the proposed subdivision, and
> > keep the same people on cc? Thanks.
>
> Thanks, done by:
> https://edk2.groups.io/g/devel/message/42080
>

Thank you.

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Laszlo Ersek]

On 06/10/19 09:16, Ni, Ray wrote:
> Hao,
> Can you please list the detailed sub-directories/modules/libraries for each major feature, including those that are not covered by the major features? This avoid misunderstanding and is also needed by the Maintainers.txt.

I agree. Every module INF file needs an assigned maintainer that can be
determined mechanically.

Currently, there are 224 INF files under MdeModulePkg. We need to
provide a list that covers each one of these INF files by pathname.
Wildcards are fine to use of course.

Thanks
Laszlo

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

[Yao, Jiewen]

Thanks. Got it.

I would use term - "MemoryManagement". :-)

Thank you
Yao Jiewen

> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, June 10, 2019 2:20 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Zeng, Star
> <star.zeng@intel.com>; lersek@redhat.com; Ni, Ray <ray.ni@intel.com>;
> Gao, Liming <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif
> Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>
> Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> > -----Original Message-----
> > From: Yao, Jiewen
> > Sent: Monday, June 10, 2019 2:13 PM
> > To: devel@edk2.groups.io; Wu, Hao A; Zeng, Star; lersek@redhat.com; Ni,
> > Ray; Gao, Liming; ard.biesheuvel@linaro.org; Leif Lindholm; Kinney,
> Michael
> > D; Liu, Zhiguang; Justen, Jordan L; Andrew Fish
> > Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > Good list.
> 
> Thanks Jiewen,
> 
> >
> > What does "memory" mean ? MemoryTest ?
> 
> Not only MemoryTest, I was intended to count components like memory
> allocation, memory profile (contents within
> MdeModulePkg/Core/Pei/Memory &
> MdeModulePkg/Core/Dxe/Mem) and etc. into this category as well.
> 
> But I am not sure if such classification makes sense.
> 
> >
> > How about put "LockBox" into "S3"?
> 
> Agree.
> 
> >
> > How about list "EBC" as standalone component?
> 
> Agree. Thanks for the reminder.
> 
> Best Regards,
> Hao Wu
> 
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> > > Wu, Hao A
> > > Sent: Monday, June 10, 2019 2:02 PM
> > > To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>;
> > > lersek@redhat.com; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> > > <leif.lindholm@linaro.org>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > > Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > > <afish@apple.com>
> > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > > current speed
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > Of
> > > > Zeng, Star
> > > > Sent: Wednesday, June 05, 2019 10:31 PM
> > > > To: devel@edk2.groups.io; lersek@redhat.com; Ni, Ray; Gao, Liming;
> > > > ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael D; Liu,
> > > Zhiguang;
> > > > Justen, Jordan L; Andrew Fish
> > > > Cc: Zeng, Star
> > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > > > current speed
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> Behalf
> > > Of
> > > > > Laszlo Ersek
> > > > > Sent: Wednesday, June 5, 2019 4:03 PM
> > > > > To: Ni, Ray <ray.ni@intel.com>; Gao, Liming
> <liming.gao@intel.com>;
> > > > > ard.biesheuvel@linaro.org; Leif Lindholm <leif.lindholm@linaro.org>;
> > > > Kinney,
> > > > > Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > > > <zhiguang.liu@intel.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>;
> > > > > Andrew Fish <afish@apple.com>
> > > > > Cc: devel@edk2.groups.io
> > > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the
> cpu
> > > > > current speed
> > > > >
> > > > > On 06/05/19 03:10, Ni, Ray wrote:
> > > > > > Hi everyone,
> > > > > >
> > > > > > Hao pushed the patch because:
> > > > > > 1. it's a bug fix
> > > > > > 2. it got a R-b.
> > > > > > I don't think it's his fault.
> > > > > >
> > > > > > For #1, it's gap in process.
> > > > > > For #2, it's my fault. Because even the patch title says EmulatorPkg
> > but
> > > > the
> > > > > patch itself changes MdeModulePkg, I am still the person who can
> > > approve
> > > > > changes in both packages.
> > > > > >
> > > > > > In Maintainers.txt:
> > > > > > R: Ray Ni <ray.ni@intel.com>
> > > > > >   (especially for Bus, Universal/Console, Universal/Disk,
> > > > > >    Universal/BdsDxe and related libraries, header files)
> > > > > >
> > > > > > The UiApp actually is not in the "especially" part, but the word
> > > > "especially"
> > > > > > means I can also R-b to other components. In fact, I am not quite
> > > > > > qualified on the other components, e.g.: UiApp.
> > > > > > So I propose to assign clear reviewers for each components in
> > > > > MdeModulePkg.
> > > > > > What do you think?
> > > > >
> > > > > Fully agreed. MdeModulePkg is huge and we should have fine-grained
> > > > > maintainership assignments.
> > > >
> > > > I also agree.
> > >
> > > Thanks all.
> > >
> > > For the review ownership refinement in the MdeModulePkg, how about
> > the
> > > below steps:
> > >
> > > 1. Work out a major feature list for the MdeModulePkg
> > > 2. Call for owners for every item in the list.
> > >
> > >
> > > A quick and coarse list of major features can be:
> > >
> > > (Just a draft, some key features may be missing or some listed features
> > > may not be considered as major ones. Feedbacks are welcomed.)
> > >
> > > Acpi
> > > Bds
> > > Capsule
> > > Compress
> > > Console
> > > Core (PeiCore, DxeCore, PiSmmCore and etc.)
> > > Device (peripheral & storage)
> > > Disk
> > > HII
> > > LockBox
> > > Memory
> > > PCD
> > > PCI bus
> > > Reset
> > > S3
> > > SMBIOS
> > > SMM
> > > Status Code
> > > UI
> > > Variable
> > > Misc (all the components that do not fit in the above items)
> > >
> > >
> > > Any feedbacks/suggestions for such proposal?
> > >
> > > Best Regards,
> > > Hao Wu
> > >
> > > >
> > > > >
> > > > > Thanks
> > > > > Laszlo
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >