Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

["Liming Gao" <liming.gao@intel.com>]

Ard:

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> Sent: Tuesday, June 4, 2019 9:42 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Laszlo Ersek <lersek@redhat.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Andrew Fish <afish@apple.com>
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> 
> On Tue, 4 Jun 2019 at 15:40, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > Ard:
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> > > Sent: Tuesday, June 4, 2019 7:53 PM
> > > To: edk2-devel-groups-io <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
> > > <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
> > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
> > >
> > > On Tue, 4 Jun 2019 at 10:50, Ni, Ray <ray.ni@intel.com> wrote:
> > > >
> > > > Zhiguang,
> > > > I made a mistake here.
> > > > I thought you changed the EmulatorPkg to not display the CPU speed
> > > > but actually what you changed impacts all platforms.
> > > > With this change, OVMF cannot show the CPU speed either.
> > > >
> > > > Can you please roll back this changes (if it was pushed in)?
> > > >
> > >
> > > OK, this patch mentions EmulatorPkg in the commit log but actually
> > > modifies MdeModulePkg, and it was pushed during the hard freeze.
> > >
> > > Seriously, how did this happen? I would expect everyone with commit
> > > rights to the repository to be aware of the stable tag rules and
> > > release cadence.
> >
> > This patch is like a bug fix.
> 
> How so? Why does it qualify as a bug fix that can be applied during
> the hard freeze period?

There is no definition now. Some discussion is related to this topic.
https://edk2.groups.io/g/devel/message/41276?p=,,,20,0,0,0::Created,,edk2-stable201905,20,2,20,31653140

> 
> > But, this patch changes the code in MdeModulePkg.
> > It requires MdeModulePkg package maintainer and reviewer to review it.
> > And, it impacts the different platforms. So, I also prefer to roll back this change.
> >
> 
> Agreed.
> 
> 
> > >
> > >
> >
> 
>