From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Tue, 04 Jun 2019 17:22:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 17:22:47 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 04 Jun 2019 17:22:47 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 17:22:47 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 17:22:46 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.98]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 08:22:45 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Wang, Jian J" CC: "Bi, Dandan" , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure Thread-Topic: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure Thread-Index: AQHVGxsfVn/vWXl+ikabG//GVustZqaMM1rw Date: Wed, 5 Jun 2019 00:22:43 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46BCDD@SHSMSX104.ccr.corp.intel.com> References: <20190604211844.4424-1-jian.j.wang@intel.com> In-Reply-To: <20190604211844.4424-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Wang, Jian J >Sent: Wednesday, June 05, 2019 5:19 AM >To: devel@edk2.groups.io >Cc: Bi, Dandan ; Lu, XiaoyuX >Subject: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build fail= ure > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1878 > >This issue is specific to VS2017 which tries to resolve symbol referenced >by a symbol not really referenced eventually. > >ossl_init_load_crypto_strings >-> err_load_crypto_strings_int (not really referenced) >-> ERR_load_OSSL_STORE_strings > >Because OPENSSL_NO_ERR and OPENSSL_NO_AUTOERRINIT are not defined >by >default, err_load_crypto_strings_int() will not be actually referenced >by ossl_init_load_crypto_strings(). > >Since err_load_crypto_strings_int() is not actually referenced at all, >the fix can be done simply by removing crypto/err/err_all.c from build. > >Cc: Dandan Bi >Cc: Xiaoyu Lu >Signed-off-by: Jian J Wang >--- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 - > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 - > 2 files changed, 2 deletions(-) > >diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf >b/CryptoPkg/Library/OpensslLib/OpensslLib.inf >index 378fa6588e..5a2424fc16 100644 >--- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf >+++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf >@@ -218,7 +218,6 @@ > $(OPENSSL_PATH)/crypto/dso/dso_win32.c > $(OPENSSL_PATH)/crypto/ebcdic.c > $(OPENSSL_PATH)/crypto/err/err.c >- $(OPENSSL_PATH)/crypto/err/err_all.c > $(OPENSSL_PATH)/crypto/err/err_prn.c > $(OPENSSL_PATH)/crypto/evp/bio_b64.c > $(OPENSSL_PATH)/crypto/evp/bio_enc.c >diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >index 24d3d96459..588da4c040 100644 >--- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >+++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >@@ -218,7 +218,6 @@ > $(OPENSSL_PATH)/crypto/dso/dso_win32.c > $(OPENSSL_PATH)/crypto/ebcdic.c > $(OPENSSL_PATH)/crypto/err/err.c >- $(OPENSSL_PATH)/crypto/err/err_all.c > $(OPENSSL_PATH)/crypto/err/err_prn.c > $(OPENSSL_PATH)/crypto/evp/bio_b64.c > $(OPENSSL_PATH)/crypto/evp/bio_enc.c >-- >2.17.1.windows.2 > > >