public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"
Date: Wed, 5 Jun 2019 00:23:16 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46BCEC@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190604185843.22059-1-lersek@redhat.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Wednesday, June 05, 2019 2:59 AM
>To: edk2-devel-groups-io <devel@edk2.groups.io>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Wu, Hao A
><hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
><liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
><star.zeng@intel.com>
>Subject: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg:
>don't display the cpu current speed"
>
>This reverts commit 7cea4d71a8a87a93924a07ab32348332f5881ef9.
>
>Said commit was not suitable for pushing during the edk2-stable201905 hard
>feature freeze; it was pushed only by mistake. The subject line referenced
>EmulatorPkg, but the patch changed MdeModulePkg/UiApp, regressing the
>display of the CPU speed from SMBIOS in multiple platforms.
>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Hao A Wu <hao.a.wu@intel.com>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1877
>Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>---
>
>Notes:
>    Repo:   https://github.com/lersek/edk2.git
>    Branch: revert_cpu_speed_hide
>
> MdeModulePkg/Application/UiApp/FrontPage.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
>b/MdeModulePkg/Application/UiApp/FrontPage.c
>index fded7634062a..4b95cccb5cf5 100644
>--- a/MdeModulePkg/Application/UiApp/FrontPage.c
>+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
>@@ -621,6 +621,11 @@ UpdateFrontPageBannerStrings (
>         HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
>(STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
>         FreePool (NewString);
>
>+        ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString);
>+        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
>+        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
>(STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
>+        FreePool (NewString);
>+
>         FoundCpu = TRUE;
>       }
>     }
>--
>2.19.1.3.g30247aa5d201
>
>
>-=-=-=-=-=-=
>Groups.io Links: You receive all messages sent to this group.
>
>View/Reply Online (#41886): https://edk2.groups.io/g/devel/message/41886
>Mute This Topic: https://groups.io/mt/31929712/1759384
>Group Owner: devel+owner@edk2.groups.io
>Unsubscribe: https://edk2.groups.io/g/devel/unsub  [liming.gao@intel.com]
>-=-=-=-=-=-=


  reply	other threads:[~2019-06-05  0:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 18:58 [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed" Laszlo Ersek
2019-06-05  0:23 ` Liming Gao [this message]
2019-06-05  8:12   ` [edk2-devel] " Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E46BCEC@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox