From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Tue, 04 Jun 2019 17:23:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 17:23:20 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 04 Jun 2019 17:23:19 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 17:23:19 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 17:23:19 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.10]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 08:23:17 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: Ard Biesheuvel , "Wu, Hao A" , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed" Thread-Topic: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed" Thread-Index: AQHVGweOSTA70GF/9UixH7blR3HkTaaMM6nQ Date: Wed, 5 Jun 2019 00:23:16 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46BCEC@SHSMSX104.ccr.corp.intel.com> References: <20190604185843.22059-1-lersek@redhat.com> In-Reply-To: <20190604185843.22059-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Wednesday, June 05, 2019 2:59 AM >To: edk2-devel-groups-io >Cc: Ard Biesheuvel ; Wu, Hao A >; Wang, Jian J ; Gao, Liming >; Ni, Ray ; Zeng, Star > >Subject: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: >don't display the cpu current speed" > >This reverts commit 7cea4d71a8a87a93924a07ab32348332f5881ef9. > >Said commit was not suitable for pushing during the edk2-stable201905 hard >feature freeze; it was pushed only by mistake. The subject line referenced >EmulatorPkg, but the patch changed MdeModulePkg/UiApp, regressing the >display of the CPU speed from SMBIOS in multiple platforms. > >Cc: Ard Biesheuvel >Cc: Hao A Wu >Cc: Jian J Wang >Cc: Liming Gao >Cc: Ray Ni >Cc: Star Zeng >Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1877 >Signed-off-by: Laszlo Ersek >--- > >Notes: > Repo: https://github.com/lersek/edk2.git > Branch: revert_cpu_speed_hide > > MdeModulePkg/Application/UiApp/FrontPage.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c >b/MdeModulePkg/Application/UiApp/FrontPage.c >index fded7634062a..4b95cccb5cf5 100644 >--- a/MdeModulePkg/Application/UiApp/FrontPage.c >+++ b/MdeModulePkg/Application/UiApp/FrontPage.c >@@ -621,6 +621,11 @@ UpdateFrontPageBannerStrings ( > HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN >(STR_FRONT_PAGE_CPU_MODEL), NewString, NULL); > FreePool (NewString); > >+ ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString= ); >+ UiCustomizeFrontPageBanner (2, FALSE, &NewString); >+ HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN >(STR_FRONT_PAGE_CPU_SPEED), NewString, NULL); >+ FreePool (NewString); >+ > FoundCpu =3D TRUE; > } > } >-- >2.19.1.3.g30247aa5d201 > > >-=3D-=3D-=3D-=3D-=3D-=3D >Groups.io Links: You receive all messages sent to this group. > >View/Reply Online (#41886): https://edk2.groups.io/g/devel/message/41886 >Mute This Topic: https://groups.io/mt/31929712/1759384 >Group Owner: devel+owner@edk2.groups.io >Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] >-=3D-=3D-=3D-=3D-=3D-=3D