public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"Ma, Maurice" <maurice.ma@intel.com>,
	"Laszlo Ersek" <lersek@redhat.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Dong, Guo" <guo.dong@intel.com>,
	"You, Benjamin" <benjamin.you@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
Date: Wed, 5 Jun 2019 07:35:27 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C13C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu9NvTwTUJ=VXPGdrcS3RUYKqhLPY1ez-MW0NjuG9DN7Xw@mail.gmail.com>

Ard:

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> Sent: Wednesday, June 5, 2019 2:25 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Ma, Maurice <maurice.ma@intel.com>; Laszlo Ersek <lersek@redhat.com>; Leif
> Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
> 
> On Fri, 31 May 2019 at 01:06, Ma, Maurice <maurice.ma@intel.com> wrote:
> >
> > Reviewed-by: Maurice Ma <maurice.ma@intel.com>
> >
> 
> This patch has now been pushed, while I don't think it is a bugfix,
> and we are in the middle of the hard freeze period.

Seemly, not every person well knows the hard feature freeze period for 201905 stable tag.
201905 stable tag period is deferred than original plan. So, some people may not notice it.

I can prepare the patch to roll back it for 201905 stable tag. 

> 
> 
> > > -----Original Message-----
> > > From: Dong, Guo
> > > Sent: Thursday, May 30, 2019 2:52
> > > To: devel@edk2.groups.io
> > > Cc: Ma, Maurice <maurice.ma@intel.com>; You, Benjamin
> > > <benjamin.you@intel.com>; Dong, Guo <guo.dong@intel.com>
> > > Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
> > >
> > > Since legacy PIC 8259 driver would be removed from edk2, update UEFI payload
> > > to remove 8259 driver.
> > > If required, bootloader could disable 8259.
> > >
> > > Signed-off-by: Guo Dong <guo.dong@intel.com>
> > > ---
> > >  UefiPayloadPkg/UefiPayloadPkg.fdf        | 1 -
> > >  UefiPayloadPkg/UefiPayloadPkgIa32.dsc    | 1 -
> > >  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
> > >  3 files changed, 3 deletions(-)
> > >
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > index ce3b34999b..4cd88a3f85 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > @@ -104,7 +104,6 @@ INF
> > > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> > >  INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > >  INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >  INF
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > -INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > >  INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > >  INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > >  INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > index 5b6ed36e9c..11cf17ca06 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > @@ -432,7 +432,6 @@
> > >    UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > >    MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > -  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > index d57b5241dc..5b7994a62c 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > @@ -433,7 +433,6 @@
> > >    UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > >    MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > -  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > --
> > > 2.16.2.windows.1
> >
> >
> >
> >
> 
> 


      reply	other threads:[~2019-06-05  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 18:52 [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver Guo Dong
2019-05-30 23:05 ` Ma, Maurice
2019-06-05  6:24   ` Ard Biesheuvel
2019-06-05  7:35     ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E46C13C@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox