* [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
@ 2019-05-29 18:52 Guo Dong
2019-05-30 23:05 ` Ma, Maurice
0 siblings, 1 reply; 4+ messages in thread
From: Guo Dong @ 2019-05-29 18:52 UTC (permalink / raw)
To: devel; +Cc: maurice.ma, benjamin.you, guo.dong
Since legacy PIC 8259 driver would be removed from edk2,
update UEFI payload to remove 8259 driver.
If required, bootloader could disable 8259.
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.fdf | 1 -
UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 -
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
3 files changed, 3 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index ce3b34999b..4cd88a3f85 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -104,7 +104,6 @@ INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
-INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index 5b6ed36e9c..11cf17ca06 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -432,7 +432,6 @@
UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
- PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
index d57b5241dc..5b7994a62c 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
@@ -433,7 +433,6 @@
UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
- PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
2019-05-29 18:52 [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver Guo Dong
@ 2019-05-30 23:05 ` Ma, Maurice
2019-06-05 6:24 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Ma, Maurice @ 2019-05-30 23:05 UTC (permalink / raw)
To: Dong, Guo, devel@edk2.groups.io; +Cc: You, Benjamin
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
Regards,
Maurice
> -----Original Message-----
> From: Dong, Guo
> Sent: Thursday, May 30, 2019 2:52
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; You, Benjamin
> <benjamin.you@intel.com>; Dong, Guo <guo.dong@intel.com>
> Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
>
> Since legacy PIC 8259 driver would be removed from edk2, update UEFI payload
> to remove 8259 driver.
> If required, bootloader could disable 8259.
>
> Signed-off-by: Guo Dong <guo.dong@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkg.fdf | 1 -
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 -
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index ce3b34999b..4cd88a3f85 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -104,7 +104,6 @@ INF
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> INF
> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> xe.inf
> -INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index 5b6ed36e9c..11cf17ca06 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -432,7 +432,6 @@
> UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>
> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> xe.inf
> - PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index d57b5241dc..5b7994a62c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -433,7 +433,6 @@
> UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>
> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> xe.inf
> - PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
2019-05-30 23:05 ` Ma, Maurice
@ 2019-06-05 6:24 ` Ard Biesheuvel
2019-06-05 7:35 ` Liming Gao
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2019-06-05 6:24 UTC (permalink / raw)
To: edk2-devel-groups-io, Maurice Ma, Laszlo Ersek, Leif Lindholm,
Gao, Liming, Kinney, Michael D
Cc: Dong, Guo, You, Benjamin
On Fri, 31 May 2019 at 01:06, Ma, Maurice <maurice.ma@intel.com> wrote:
>
> Reviewed-by: Maurice Ma <maurice.ma@intel.com>
>
This patch has now been pushed, while I don't think it is a bugfix,
and we are in the middle of the hard freeze period.
> > -----Original Message-----
> > From: Dong, Guo
> > Sent: Thursday, May 30, 2019 2:52
> > To: devel@edk2.groups.io
> > Cc: Ma, Maurice <maurice.ma@intel.com>; You, Benjamin
> > <benjamin.you@intel.com>; Dong, Guo <guo.dong@intel.com>
> > Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
> >
> > Since legacy PIC 8259 driver would be removed from edk2, update UEFI payload
> > to remove 8259 driver.
> > If required, bootloader could disable 8259.
> >
> > Signed-off-by: Guo Dong <guo.dong@intel.com>
> > ---
> > UefiPayloadPkg/UefiPayloadPkg.fdf | 1 -
> > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 -
> > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > index ce3b34999b..4cd88a3f85 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > @@ -104,7 +104,6 @@ INF
> > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> > INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > INF
> > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > xe.inf
> > -INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > index 5b6ed36e9c..11cf17ca06 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > @@ -432,7 +432,6 @@
> > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> >
> > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > xe.inf
> > - PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > index d57b5241dc..5b7994a62c 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > @@ -433,7 +433,6 @@
> > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> >
> > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > xe.inf
> > - PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > --
> > 2.16.2.windows.1
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
2019-06-05 6:24 ` Ard Biesheuvel
@ 2019-06-05 7:35 ` Liming Gao
0 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2019-06-05 7:35 UTC (permalink / raw)
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org, Ma, Maurice,
Laszlo Ersek, Leif Lindholm, Kinney, Michael D
Cc: Dong, Guo, You, Benjamin, Gao, Liming
Ard:
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard Biesheuvel
> Sent: Wednesday, June 5, 2019 2:25 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Ma, Maurice <maurice.ma@intel.com>; Laszlo Ersek <lersek@redhat.com>; Leif
> Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
>
> On Fri, 31 May 2019 at 01:06, Ma, Maurice <maurice.ma@intel.com> wrote:
> >
> > Reviewed-by: Maurice Ma <maurice.ma@intel.com>
> >
>
> This patch has now been pushed, while I don't think it is a bugfix,
> and we are in the middle of the hard freeze period.
Seemly, not every person well knows the hard feature freeze period for 201905 stable tag.
201905 stable tag period is deferred than original plan. So, some people may not notice it.
I can prepare the patch to roll back it for 201905 stable tag.
>
>
> > > -----Original Message-----
> > > From: Dong, Guo
> > > Sent: Thursday, May 30, 2019 2:52
> > > To: devel@edk2.groups.io
> > > Cc: Ma, Maurice <maurice.ma@intel.com>; You, Benjamin
> > > <benjamin.you@intel.com>; Dong, Guo <guo.dong@intel.com>
> > > Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
> > >
> > > Since legacy PIC 8259 driver would be removed from edk2, update UEFI payload
> > > to remove 8259 driver.
> > > If required, bootloader could disable 8259.
> > >
> > > Signed-off-by: Guo Dong <guo.dong@intel.com>
> > > ---
> > > UefiPayloadPkg/UefiPayloadPkg.fdf | 1 -
> > > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 -
> > > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
> > > 3 files changed, 3 deletions(-)
> > >
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > index ce3b34999b..4cd88a3f85 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > @@ -104,7 +104,6 @@ INF
> > > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> > > INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > > INF
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > -INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > index 5b6ed36e9c..11cf17ca06 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > @@ -432,7 +432,6 @@
> > > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > - PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > index d57b5241dc..5b7994a62c 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > @@ -433,7 +433,6 @@
> > > UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > - PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > --
> > > 2.16.2.windows.1
> >
> >
> >
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-05 7:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 18:52 [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver Guo Dong
2019-05-30 23:05 ` Ma, Maurice
2019-06-05 6:24 ` Ard Biesheuvel
2019-06-05 7:35 ` Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox