From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 05 Jun 2019 00:56:14 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 00:56:13 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 05 Jun 2019 00:56:13 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Jun 2019 00:56:13 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Jun 2019 00:56:12 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.187]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 15:56:10 +0800 From: "Liming Gao" To: "Lu, XiaoyuX" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem Thread-Topic: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem Thread-Index: AQHVG19PQyx+GkN+oUK1k7ap2DC1gqaMjrsg//+FpgCAAJUWQP//e/UAgACGvyD//33IAAAQ7FfA Date: Wed, 5 Jun 2019 07:56:10 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C1AF@SHSMSX104.ccr.corp.intel.com> References: <1559712295-891-1-git-send-email-xiaoyux.lu@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C045@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C123@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C157@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2ZjOWE4ZDQtYTY3Yi00YTAxLTljNmQtOTU0Yzg3MDZmOTk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDhvTE5vTm1nVklXZSsxMEgyZDNYVHRxUW9tZHJVT3BMTVdFZ0FMU1FZeHZoWVROcW5QRE9penNFV2hTeTZFRiJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That good enough. Reviewed-by: Liming Gao Thanks Liming > -----Original Message----- > From: Lu, XiaoyuX > Sent: Wednesday, June 5, 2019 3:51 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Bi, Dandan ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLA= NG38 IA32 build problem >=20 > Yes I verify them. >=20 > build -p OvmfPkg/OvmfPkgX64.dsc -a X64 -t CLANG38 > and > build -p OvmfPkg/OvmfPkgIA32.dsc -a IA32 -t CLANG38 >=20 > with qemu-system-x86_64 >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Wednesday, June 5, 2019 3:37 PM > > To: Lu, XiaoyuX ; devel@edk2.groups.io > > Cc: Bi, Dandan ; Wang, Jian J > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix > > CLANG38 IA32 build problem > > > > Do you cover IA32 & X64 arch both, and verify Ovmf boot? > > > > > -----Original Message----- > > > From: Lu, XiaoyuX > > > Sent: Wednesday, June 5, 2019 3:35 PM > > > To: Gao, Liming ; devel@edk2.groups.io > > > Cc: Bi, Dandan ; Wang, Jian J > > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix > > CLANG38 IA32 build problem > > > > > > Liming, > > > > > > > -----Original Message----- > > > > From: Gao, Liming > > > > Sent: Wednesday, June 5, 2019 3:28 PM > > > > To: Lu, XiaoyuX ; devel@edk2.groups.io > > > > Cc: Bi, Dandan ; Wang, Jian J > > > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: F= ix > > > > CLANG38 IA32 build problem > > > > > > > > Xiaoyu: > > > > > > > > > -----Original Message----- > > > > > From: Lu, XiaoyuX > > > > > Sent: Wednesday, June 5, 2019 2:34 PM > > > > > To: Gao, Liming ; devel@edk2.groups.io > > > > > Cc: Bi, Dandan ; Wang, Jian J > > > > > > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib:= Fix > > > > CLANG38 IA32 build problem > > > > > > > > > > Hi Liming, > > > > > > > > > > > -----Original Message----- > > > > > > From: Gao, Liming > > > > > > Sent: Wednesday, June 5, 2019 1:57 PM > > > > > > To: devel@edk2.groups.io; Lu, XiaoyuX > > > > > > Cc: Bi, Dandan ; Wang, Jian J > > > > > > > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLi= b: Fix > > > > > > CLANG38 IA32 build problem > > > > > > > > > > > > Xiaoyu: > > > > > > > > > > > > >-----Original Message----- > > > > > > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On > > Behalf > > > > Of > > > > > > >Xiaoyu Lu > > > > > > >Sent: Wednesday, June 05, 2019 1:25 PM > > > > > > >To: devel@edk2.groups.io > > > > > > >Cc: Lu, XiaoyuX ; Bi, Dandan > > > > > > ; > > > > > > >Wang, Jian J > > > > > > >Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: = Fix > > > > CLANG38 > > > > > > >IA32 build problem > > > > > > > > > > > > > >When use clang-3.8 to build the NetworkPkg, compiler optimiza= tion > > > > > > >may use memcpy for memory copy. For example: > > > > > > > > > > > > > > CryptoPkg/Library/OpensslLib/openssl/ssl/ssl_rsa.c:918: unde= fined > > > > > > > reference to `memcpy'` > > > > > > > > > > > > > >Compiler optimization is sophisticated, but we can work aroun= d it > > > > > > >use __attribute__((__used__)) to informs the compiler that sy= mbol > > > > > > >should be retained in the object file, even if it may be > > > > > > >unreferenced. > > > > > > > > > > > > > >Cc: Jian J Wang > > > > > > >Cc: Dandan Bi > > > > > > >Signed-off-by: Xiaoyu Lu > > > > > > >--- > > > > > > > CryptoPkg/Library/IntrinsicLib/CopyMem.c | 13 +++++++++++++ > > > > > > > 1 file changed, 13 insertions(+) > > > > > > > > > > > > > >diff --git a/CryptoPkg/Library/IntrinsicLib/CopyMem.c > > > > > > >b/CryptoPkg/Library/IntrinsicLib/CopyMem.c > > > > > > >index e29b4918d200..7faf5a34d8c1 100644 > > > > > > >--- a/CryptoPkg/Library/IntrinsicLib/CopyMem.c > > > > > > >+++ b/CryptoPkg/Library/IntrinsicLib/CopyMem.c > > > > > > >@@ -10,8 +10,21 @@ SPDX-License-Identifier: BSD-2-Clause-Pate= nt > > > > > > > #include > > > > > > > #include > > > > > > > > > > > > > >+#if defined(__clang__) && !defined(__APPLE__) > > > > > > > > > > > > So, this change is only for CLANG tool chain. > > > > > > > > > > > > >+ > > > > > > >+/* Copies bytes between buffers */ > > > > > > >+static __attribute__((__used__)) > > > > > > > > > > > > What purpose for static? > > > > > > > > > > > > > > > > Because I want __memcpy only use in this file scope. > > > > > > > > > > > >+void * __memcpy (void *dest, const void *src, unsigned int c= ount) > > > > > > >+{ > > > > > > >+ return CopyMem (dest, src, (UINTN)count); > > > > > > >+} > > > > > > >+__attribute__((__alias__("__memcpy"))) > > > > > > >+void * memcpy (void *dest, const void *src, unsigned int cou= nt); > > > > > > > > > > > > __memcpy is IA32 Intrinsic API, memcpy is X64 Intrinsic API, r= ight? > > > > > > > > > > > > > > > > __memcpy isn't IA32 Intrinsic API, only memcpy is intrinsic API = for > > both > > > > IA32 and X64. > > > > > > > > > > The reason I alias memcpy and use __attribute__((__used__)) is l= et > > > > compiler retain symbol in object file, > > > > > So it can link correct. > > > > > > > > > > Is this correct? > > > > > > > > > > > > > Make sense. What test have been done by you? Build pass and Boot > > pass? > > > > > > > > > > Build pass and BaseCryptLib functions test pass. > > > I don't test http boot. > > > > > > Thanks, > > > Xiaoyu > > > > > > > > > Thanks > > > > > > Liming > > > > > > > > > > > >+ > > > > > > >+#else > > > > > > > /* Copies bytes between buffers */ > > > > > > > void * memcpy (void *dest, const void *src, unsigned int cou= nt) > > > > > > > { > > > > > > > return CopyMem (dest, src, (UINTN)count); > > > > > > > } > > > > > > >+#endif > > > > > > >-- > > > > > > >2.7.4 > > > > > > > > > > > > > > > > > > > > >