From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 05 Jun 2019 01:23:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 01:23:50 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 05 Jun 2019 01:23:50 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Jun 2019 01:23:50 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Jun 2019 01:23:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.120]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 16:23:48 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , "Wang, Jian J" CC: "Bi, Dandan" , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure Thread-Topic: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure Thread-Index: AQHVGxsfVn/vWXl+ikabG//GVustZqaMM1rwgACGWTA= Date: Wed, 5 Jun 2019 08:23:48 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C25D@SHSMSX104.ccr.corp.intel.com> References: <20190604211844.4424-1-jian.j.wang@intel.com> <15A525952F820008.28502@groups.io> In-Reply-To: <15A525952F820008.28502@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzZiZmIxOGYtMTAzNC00YjI2LWEwZWEtNzE4NmM5NjE5YzZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZitqS1VMek9JT2Y3MlFWWHAyeFk4Z0p5aDh0SjJyUlRHVE42SVJKR1ZlSGgwSFVLU3B4RzZxd081UDMxNkltRSJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push @0a1b13fd4d2210e2c379ace4fd961fb80126b7e9 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Li= ming Gao > Sent: Wednesday, June 5, 2019 8:23 AM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Bi, Dandan ; Lu, XiaoyuX > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build= failure >=20 > Reviewed-by: Liming Gao >=20 > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Wang, Jian J > >Sent: Wednesday, June 05, 2019 5:19 AM > >To: devel@edk2.groups.io > >Cc: Bi, Dandan ; Lu, XiaoyuX > >Subject: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build fa= ilure > > > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1878 > > > >This issue is specific to VS2017 which tries to resolve symbol referenc= ed > >by a symbol not really referenced eventually. > > > >ossl_init_load_crypto_strings > >-> err_load_crypto_strings_int (not really referenced) > >-> ERR_load_OSSL_STORE_strings > > > >Because OPENSSL_NO_ERR and OPENSSL_NO_AUTOERRINIT are not defined > >by > >default, err_load_crypto_strings_int() will not be actually referenced > >by ossl_init_load_crypto_strings(). > > > >Since err_load_crypto_strings_int() is not actually referenced at all, > >the fix can be done simply by removing crypto/err/err_all.c from build. > > > >Cc: Dandan Bi > >Cc: Xiaoyu Lu > >Signed-off-by: Jian J Wang > >--- > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 - > > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 - > > 2 files changed, 2 deletions(-) > > > >diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >index 378fa6588e..5a2424fc16 100644 > >--- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >+++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >@@ -218,7 +218,6 @@ > > $(OPENSSL_PATH)/crypto/dso/dso_win32.c > > $(OPENSSL_PATH)/crypto/ebcdic.c > > $(OPENSSL_PATH)/crypto/err/err.c > >- $(OPENSSL_PATH)/crypto/err/err_all.c > > $(OPENSSL_PATH)/crypto/err/err_prn.c > > $(OPENSSL_PATH)/crypto/evp/bio_b64.c > > $(OPENSSL_PATH)/crypto/evp/bio_enc.c > >diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >index 24d3d96459..588da4c040 100644 > >--- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >+++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >@@ -218,7 +218,6 @@ > > $(OPENSSL_PATH)/crypto/dso/dso_win32.c > > $(OPENSSL_PATH)/crypto/ebcdic.c > > $(OPENSSL_PATH)/crypto/err/err.c > >- $(OPENSSL_PATH)/crypto/err/err_all.c > > $(OPENSSL_PATH)/crypto/err/err_prn.c > > $(OPENSSL_PATH)/crypto/evp/bio_b64.c > > $(OPENSSL_PATH)/crypto/evp/bio_enc.c > >-- > >2.17.1.windows.2 > > > > > > >=20 >=20 >=20