From: "Liming Gao" <liming.gao@intel.com>
To: "Wang, Jian J" <jian.j.wang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library
Date: Thu, 6 Jun 2019 04:44:52 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C9E6@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190606025717.6232-1-jian.j.wang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Wang, Jian J
> Sent: Thursday, June 6, 2019 10:57 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library
>
> CryptoPkg\Library\Include\CrtLibSupport.h maps strxxxx interfaces to
> edk2 PrintLib interfaces but related module inf file don't claim the
> use of it. This will cause unresolved symbol issue with VS2017 build
> which has enabled strict symbol check. This patch resolves the problem
> by adding PrintLib to inf files.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 +
> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index 5a2424fc16..5f36edeeef 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -562,6 +562,7 @@
> BaseLib
> DebugLib
> TimerLib
> + PrintLib
>
> [LibraryClasses.ARM]
> ArmSoftFloatLib
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> index 588da4c040..de05cac931 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> @@ -518,6 +518,7 @@
> BaseLib
> DebugLib
> TimerLib
> + PrintLib
>
> [LibraryClasses.ARM]
> ArmSoftFloatLib
> --
> 2.17.1.windows.2
prev parent reply other threads:[~2019-06-06 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 2:57 [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library Wang, Jian J
2019-06-06 4:44 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E46C9E6@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox