From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 05 Jun 2019 21:44:56 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 21:44:55 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 05 Jun 2019 21:44:55 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Jun 2019 21:44:55 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Jun 2019 21:44:54 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.120]) with mapi id 14.03.0415.000; Thu, 6 Jun 2019 12:44:53 +0800 From: "Liming Gao" To: "Wang, Jian J" , "devel@edk2.groups.io" CC: "Bi, Dandan" Subject: Re: [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library Thread-Topic: [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library Thread-Index: AQHVHBOQ0B9jWV2OP02MDaj6VhF+W6aODBQQ Date: Thu, 6 Jun 2019 04:44:52 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C9E6@SHSMSX104.ccr.corp.intel.com> References: <20190606025717.6232-1-jian.j.wang@intel.com> In-Reply-To: <20190606025717.6232-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzIwNTdjYzctYWUzNi00ODRkLThlZmMtMTMwYjk3YmZiZDk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM1ZmTXJcL0htb2psWEJldmVqSUwyeGFESVdvT2x2VVdQNU0zWkVVeE4yeEVXQTBiN2xKbVpUNHNkaW9RWkQxR3MifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Wang, Jian J > Sent: Thursday, June 6, 2019 10:57 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Bi, Dandan > Subject: [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing = library >=20 > CryptoPkg\Library\Include\CrtLibSupport.h maps strxxxx interfaces to > edk2 PrintLib interfaces but related module inf file don't claim the > use of it. This will cause unresolved symbol issue with VS2017 build > which has enabled strict symbol check. This patch resolves the problem > by adding PrintLib to inf files. >=20 > Cc: Liming Gao > Cc: Dandan Bi > Signed-off-by: Jian J Wang > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 + > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Libr= ary/OpensslLib/OpensslLib.inf > index 5a2424fc16..5f36edeeef 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -562,6 +562,7 @@ > BaseLib > DebugLib > TimerLib > + PrintLib >=20 > [LibraryClasses.ARM] > ArmSoftFloatLib > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPk= g/Library/OpensslLib/OpensslLibCrypto.inf > index 588da4c040..de05cac931 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -518,6 +518,7 @@ > BaseLib > DebugLib > TimerLib > + PrintLib >=20 > [LibraryClasses.ARM] > ArmSoftFloatLib > -- > 2.17.1.windows.2