From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Sun, 09 Jun 2019 17:33:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 17:33:32 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 09 Jun 2019 17:33:32 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 17:33:32 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 17:33:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.192]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 08:33:30 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "pete@akeo.ie" CC: "ard.biesheuvel@linaro.org" , "leif.lindholm@linaro.org" Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2 2/2] RaspberryPi/RPi3: Update DSC/FDF to use NetworkPkg DSC/FDF Thread-Topic: [edk2-devel] [edk2-platforms: PATCH v2 2/2] RaspberryPi/RPi3: Update DSC/FDF to use NetworkPkg DSC/FDF Thread-Index: AQHVHULan+p8rohXx0G5zUeYfNLP26aUDGDQ Date: Mon, 10 Jun 2019 00:33:29 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46D76F@SHSMSX104.ccr.corp.intel.com> References: <20190607150751.11840-1-pete@akeo.ie> <20190607150751.11840-3-pete@akeo.ie> In-Reply-To: <20190607150751.11840-3-pete@akeo.ie> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pete: The change is good. Reviewed-by: Liming Gao In fact, I send this patch before. https://edk2.groups.io/g/devel/messag= e/41480?p=3D,,,20,0,0,0::Created,,Network,20,2,0,31819937 But, I don't get the response. Then, I think this platform is out of ma= intain.=20 Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Pete Batard >Sent: Friday, June 07, 2019 11:08 PM >To: devel@edk2.groups.io >Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org >Subject: [edk2-devel] [edk2-platforms: PATCH v2 2/2] RaspberryPi/RPi3: >Update DSC/FDF to use NetworkPkg DSC/FDF > >This patch updates the platform DSC/FDF files to use the include fragment >files provided by NetworkPkg. > >Signed-off-by: Pete Batard >--- > Platform/RaspberryPi/RPi3/RPi3.dsc | 31 ++++++++------------ > Platform/RaspberryPi/RPi3/RPi3.fdf | 11 +------ > 2 files changed, 13 insertions(+), 29 deletions(-) > >diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >b/Platform/RaspberryPi/RPi3/RPi3.dsc >index 85b954b060f1..fe883eac96ba 100644 >--- a/Platform/RaspberryPi/RPi3/RPi3.dsc >+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >@@ -25,6 +25,12 @@ [Defines] > SKUID_IDENTIFIER =3D DEFAULT > FLASH_DEFINITION =3D >Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > >+ # >+ # Network definition >+ # >+ DEFINE NETWORK_TLS_ENABLE =3D FALSE >+ DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE >+ > # > # Defines for default states. These can be changed on the command lin= e. > # -D FLAG=3DVALUE >@@ -85,12 +91,6 @@ [LibraryClasses.common] > # use the accelerated BaseMemoryLibOptDxe by default, overrides for >SEC/PEI below > >BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibO >ptDxe.inf > >- # Networking Requirements >- NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf >- DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf >- UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf >- IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf >- > # > # It is not possible to prevent the ARM compiler from inserting calls = to >intrinsic functions. > # This library provides the instrinsic functions such a compiler may g= enerate >calls to. >@@ -117,6 +117,11 @@ [LibraryClasses.common] > >PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlat >formHookLibNull.inf > >SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortL >ib16550.inf > >+ # Cryptographic libraries >+ IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf >+ BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >+ OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf >+ > # > # Uncomment (and comment out the next line) For RealView Debugger. The >Standard IO window > # in the debugger will show load and unload commands for symbols. You = can >cut and paste this >@@ -140,11 +145,8 @@ [LibraryClasses.common] > # Secure Boot dependencies > # > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE >- IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf >- OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > >TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpm >MeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.in= f >- BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf >tree > >PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.in >f >@@ -588,16 +590,7 @@ [Components.common] > # > # Networking stack > # >- MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf >- MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf >- MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf >- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf >- MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf >- MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf >- MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf >- MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf >- NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf >- NetworkPkg/TcpDxe/TcpDxe.inf >+!include NetworkPkg/Network.dsc.inc > > # > # RNG >diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf >b/Platform/RaspberryPi/RPi3/RPi3.fdf >index 6be7c23af467..c7c3f7a2ab8c 100644 >--- a/Platform/RaspberryPi/RPi3/RPi3.fdf >+++ b/Platform/RaspberryPi/RPi3/RPi3.fdf >@@ -265,16 +265,7 @@ [FV.FvMain] > # > # Networking stack > # >- INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf >- INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf >- INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf >- INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf >- INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf >- INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf >- INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf >- INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf >- INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf >- INF NetworkPkg/TcpDxe/TcpDxe.inf >+!include NetworkPkg/Network.fdf.inc > > # > # RNG >-- >2.21.0.windows.1 > > >