Re: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.

["Liming Gao" <liming.gao@intel.com>]

Wei:

>-----Original Message-----
>From: Wu, Hao A
>Sent: Wednesday, June 12, 2019 3:48 PM
>To: devel@edk2.groups.io; Xu, Wei6 <wei6.xu@intel.com>
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
>Subject: RE: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In
>CapsuleOnDisk Mode Ppi definition.
>
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Xu,
>> Wei6
>> Sent: Wednesday, June 05, 2019 11:42 PM
>> To: devel@edk2.groups.io
>> Cc: Kinney, Michael D; Gao, Liming; Zhang, Chao B; Xu, Wei6
>> Subject: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk
>> Mode Ppi definition.
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852
>>
>> This PPI indicates current boot mode is capsule on disk mode.
>>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Chao B Zhang <chao.b.zhang@intel.com>
>> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
>> ---
>>  MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 ++++++++-
>>  MdePkg/MdePkg.dec                       | 3 +++
>>  2 files changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/MdePkg/Include/Ppi/BootInRecoveryMode.h
>> b/MdePkg/Include/Ppi/BootInRecoveryMode.h
>> index ae40744d9b..71b0ca8586 100644
>> --- a/MdePkg/Include/Ppi/BootInRecoveryMode.h
>> +++ b/MdePkg/Include/Ppi/BootInRecoveryMode.h
>> @@ -1,10 +1,10 @@
>>  /** @file
>>    This PPI is installed by the platform PEIM to designate that a recovery boot
>>    is in progress.
>>
>> -  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>> +  Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
>>    SPDX-License-Identifier: BSD-2-Clause-Patent
>>
>>    @par Revision Reference:
>>    This PPI is introduced in PI Version 1.0.
>>
>> @@ -19,6 +19,13 @@
>>    }
>>
>>
>>  extern EFI_GUID gEfiPeiBootInRecoveryModePpiGuid;
>>
>> +#define EFI_PEI_BOOT_IN_CAPSULE_ON_DISK_MODE_PPI \
>> +  { \
>> +    0xb08a11e4, 0xe2b7, 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf,
>> 0xd1 } \
>> +  }
>> +
>> +extern EFI_GUID gEfiPeiBootInCapsuleOnDiskModePpiGuid;
>> +
>
>Hello all,
>
>One question, the above PPI will be added in the next PI spec, right?
>Since I cannot find this definition within the PI 1.7 spec.
>

If this is not defined in PI spec, it belongs to edk2 implementation related PPI. 
For this feature, I suggest to add It into MdeModulePkg with Edkii prefix. 

>Best Regards,
>Hao Wu
>
>>  #endif
>> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
>> index 6c563375ee..ec02b8c7c7 100644
>> --- a/MdePkg/MdePkg.dec
>> +++ b/MdePkg/MdePkg.dec
>> @@ -790,10 +790,13 @@
>>    gEfiPeiMemoryDiscoveredPpiGuid = {0xf894643d, 0xc449, 0x42d1, {0x8e,
>> 0xa8, 0x85, 0xbd, 0xd8, 0xc6, 0x5b, 0xde } }
>>
>>    ## Include/Ppi/BootInRecoveryMode.h
>>    gEfiPeiBootInRecoveryModePpiGuid = { 0x17ee496a, 0xd8e4, 0x4b9a,
>{0x94,
>> 0xd1, 0xce, 0x82, 0x72, 0x30, 0x8, 0x50 } }
>>
>> +  ## Include/Ppi/BootInRecoveryMode.h
>> +  gEfiPeiBootInCapsuleOnDiskModePpiGuid = { 0xb08a11e4, 0xe2b7,
>0x4b75,
>> { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1 } }
>> +
>>    ## Include/Ppi/EndOfPeiPhase.h
>>    gEfiEndOfPeiSignalPpiGuid = {0x605EA650, 0xC65C, 0x42e1, {0xBA, 0x80,
>> 0x91, 0xA5, 0x2A, 0xB6, 0x18, 0xC6 } }
>>
>>    ## Include/Ppi/Reset.h
>>    gEfiPeiResetPpiGuid = { 0xef398d58, 0x9dfd, 0x4103, {0xbf, 0x94, 0x78,
>0xc6,
>> 0xf4, 0xfe, 0x71, 0x2f } }
>> --
>> 2.16.2.windows.1
>>
>>
>>