From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Wed, 12 Jun 2019 01:28:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 01:28:31 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 12 Jun 2019 01:28:31 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Jun 2019 01:28:30 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Jun 2019 01:28:30 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.246]) with mapi id 14.03.0439.000; Wed, 12 Jun 2019 16:28:28 +0800 From: "Liming Gao" To: "Wu, Hao A" , "devel@edk2.groups.io" , "Xu, Wei6" CC: "Kinney, Michael D" , "Zhang, Chao B" Subject: Re: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition. Thread-Topic: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition. Thread-Index: AQHVG7VItyS/HMaQOkuzi2mY4dNDg6aXKM4AgACQ4VA= Date: Wed, 12 Jun 2019 08:28:28 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E47C8FC@SHSMSX104.ccr.corp.intel.com> References: <20190605154203.11012-1-wei6.xu@intel.com> <20190605154203.11012-2-wei6.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Wei: >-----Original Message----- >From: Wu, Hao A >Sent: Wednesday, June 12, 2019 3:48 PM >To: devel@edk2.groups.io; Xu, Wei6 >Cc: Kinney, Michael D ; Gao, Liming >; Zhang, Chao B >Subject: RE: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In >CapsuleOnDisk Mode Ppi definition. > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Xu, >> Wei6 >> Sent: Wednesday, June 05, 2019 11:42 PM >> To: devel@edk2.groups.io >> Cc: Kinney, Michael D; Gao, Liming; Zhang, Chao B; Xu, Wei6 >> Subject: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDi= sk >> Mode Ppi definition. >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1852 >> >> This PPI indicates current boot mode is capsule on disk mode. >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Chao B Zhang >> Signed-off-by: Wei6 Xu >> --- >> MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 ++++++++- >> MdePkg/MdePkg.dec | 3 +++ >> 2 files changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Include/Ppi/BootInRecoveryMode.h >> b/MdePkg/Include/Ppi/BootInRecoveryMode.h >> index ae40744d9b..71b0ca8586 100644 >> --- a/MdePkg/Include/Ppi/BootInRecoveryMode.h >> +++ b/MdePkg/Include/Ppi/BootInRecoveryMode.h >> @@ -1,10 +1,10 @@ >> /** @file >> This PPI is installed by the platform PEIM to designate that a recov= ery boot >> is in progress. >> >> - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. >> + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved. >> SPDX-License-Identifier: BSD-2-Clause-Patent >> >> @par Revision Reference: >> This PPI is introduced in PI Version 1.0. >> >> @@ -19,6 +19,13 @@ >> } >> >> >> extern EFI_GUID gEfiPeiBootInRecoveryModePpiGuid; >> >> +#define EFI_PEI_BOOT_IN_CAPSULE_ON_DISK_MODE_PPI \ >> + { \ >> + 0xb08a11e4, 0xe2b7, 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0= xbf, >> 0xd1 } \ >> + } >> + >> +extern EFI_GUID gEfiPeiBootInCapsuleOnDiskModePpiGuid; >> + > >Hello all, > >One question, the above PPI will be added in the next PI spec, right? >Since I cannot find this definition within the PI 1.7 spec. > If this is not defined in PI spec, it belongs to edk2 implementation relat= ed PPI.=20 For this feature, I suggest to add It into MdeModulePkg with Edkii prefix.= = =20 >Best Regards, >Hao Wu > >> #endif >> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >> index 6c563375ee..ec02b8c7c7 100644 >> --- a/MdePkg/MdePkg.dec >> +++ b/MdePkg/MdePkg.dec >> @@ -790,10 +790,13 @@ >> gEfiPeiMemoryDiscoveredPpiGuid =3D {0xf894643d, 0xc449, 0x42d1, {0x8= e, >> 0xa8, 0x85, 0xbd, 0xd8, 0xc6, 0x5b, 0xde } } >> >> ## Include/Ppi/BootInRecoveryMode.h >> gEfiPeiBootInRecoveryModePpiGuid =3D { 0x17ee496a, 0xd8e4, 0x4b9a, >{0x94, >> 0xd1, 0xce, 0x82, 0x72, 0x30, 0x8, 0x50 } } >> >> + ## Include/Ppi/BootInRecoveryMode.h >> + gEfiPeiBootInCapsuleOnDiskModePpiGuid =3D { 0xb08a11e4, 0xe2b7, >0x4b75, >> { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1 } } >> + >> ## Include/Ppi/EndOfPeiPhase.h >> gEfiEndOfPeiSignalPpiGuid =3D {0x605EA650, 0xC65C, 0x42e1, {0xBA, 0x= 80, >> 0x91, 0xA5, 0x2A, 0xB6, 0x18, 0xC6 } } >> >> ## Include/Ppi/Reset.h >> gEfiPeiResetPpiGuid =3D { 0xef398d58, 0x9dfd, 0x4103, {0xbf, 0x94, 0= x78, >0xc6, >> 0xf4, 0xfe, 0x71, 0x2f } } >> -- >> 2.16.2.windows.1 >> >> >>=20