Re: [edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add UserInterfaceFeaturePkg

["Liming Gao" <liming.gao@intel.com>]

Ard:

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
>Biesheuvel
>Sent: Tuesday, June 18, 2019 1:07 AM
>To: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Bi, Dandan
><dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming
><liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: Re: [edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add
>UserInterfaceFeaturePkg
>
>On Mon, 17 Jun 2019 at 18:48, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>>
>> Hi Dandan,
>>
>> On Mon, Jun 17, 2019 at 02:51:45PM +0800, Dandan Bi wrote:
>> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545
>> >
>> > Add new package UserInterfaceFeaturePkg in Platform/Intel/
>> > folder. It will keep UI related modules in this package.
>> >
>> > We plan add UserAuthentication modules in Platform/Intel.
>> > Firstly we add a new package UserInterfaceFeaturePkg where
>> > add the UserAuthentication modules into.
>> > Package name follows the discussion in:
>> > https://edk2.groups.io/g/devel/message/42286
>> >
>> > Cc: Eric Dong <eric.dong@intel.com>
>> > Cc: Liming Gao <liming.gao@intel.com>
>> > Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>> > ---
>> >  Maintainers.txt                               |  4 ++++
>> >  .../UserInterfaceFeaturePkg.dec               | 19 +++++++++++++++
>> >  .../UserInterfaceFeaturePkg.dsc               | 23 +++++++++++++++++++
>> >  3 files changed, 46 insertions(+)
>> >  create mode 100644
>Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec
>> >  create mode 100644
>Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
>> >
>> > diff --git a/Maintainers.txt b/Maintainers.txt
>> > index cb9e15e880..c55a285fa1 100644
>> > --- a/Maintainers.txt
>> > +++ b/Maintainers.txt
>> > @@ -71,10 +71,14 @@ R: Liming Gao <liming.gao@intel.com>
>> >
>> >  Platform/Intel/DebugFeaturePkg
>> >  M: Eric Dong <eric.dong@intel.com>
>> >  R: Liming Gao <liming.gao@intel.com>
>> >
>> > +Platform/Intel/UserInterfaceFeaturePkg
>> > +M: Dandan Bi <dandan.bi@intel.com>
>> > +R: Liming Gao <liming.gao@intel.com>
>> > +
>>
>> Could you please cc all of the top-level maintainers (me, Ard and
>> Mike) when modifying Maintainers.txt?
>> Once the GetMaintainer.py we'll be able to do all of this more cleanly.
>>
>> I'm not saying you need all of our Reviewed-by:, but I'd like to not
>> miss when new maintainerships are being added.
>>

Yes. Top level Maintainers.txt needs to CC more people for review. 

>
>What is Intel specific about these user interface features? Do they
>belong in Platform/Intel?
>

Now, the added features are used in Intel platform. If other platform has the same 
usage case, they can be moved to more common place later.

Thanks
Liming
>