From: "Liming Gao" <liming.gao@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type
Date: Tue, 18 Jun 2019 05:19:25 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E482D03@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <ED077930C258884BBCB450DB737E662259E714AF@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Dong, Eric
>Sent: Tuesday, June 18, 2019 9:40 AM
>To: devel@edk2.groups.io; Bi, Dandan <dandan.bi@intel.com>
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: RE: [edk2-devel] [edk2-platforms] [patch]
>Platform/Intel/DebugFeaturePkg: Update PCD type
>
>Reviewed-by: Eric Dong <eric.dong@intel.com>
>
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Dandan Bi
>> Sent: Monday, June 17, 2019 1:45 PM
>> To: devel@edk2.groups.io
>> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
>> Subject: [edk2-devel] [edk2-platforms] [patch]
>> Platform/Intel/DebugFeaturePkg: Update PCD type
>>
>> Add PcdAcpiDebugEnable and PcdAcpiDebugBufferSize into following
>section
>> which platform can customize the type by itself.
>> [PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>> ---
>> Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
>> b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
>> index 7389d36a57..37ebe6da4d 100644
>> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
>> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec
>> @@ -49,10 +49,11 @@ [PcdsFixedAtBuild]
>> ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes space.
>>
>> gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortDeviceIndex|0x5A|
>> UINT8|0x00000007
>> ## This PCD sepcifies the start index in CMOS, it will occupy 1 bytes space.
>>
>>
>gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortFunctionIndex|0x5B
>> |UINT8|0x00000008
>>
>> +[PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>> ## This PCD specifies AcpiDebug feature is enable/disable.
>>
>>
>gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugEnable|FALSE|BOOLEAN|
>> 0x00000009
>> ## This PCD specifies AcpiDebug buffer size.
>>
>>
>gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize|0x10000|UINT
>> 32|0x0000000A
>>
>> --
>> 2.18.0.windows.1
>>
>>
>>
prev parent reply other threads:[~2019-06-18 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 5:44 [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type Dandan Bi
2019-06-18 1:40 ` [edk2-devel] " Dong, Eric
2019-06-18 5:19 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E482D03@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox