From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Mon, 17 Jun 2019 22:19:29 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 22:19:29 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 17 Jun 2019 22:19:29 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 22:19:29 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 22:19:28 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0439.000; Tue, 18 Jun 2019 13:19:26 +0800 From: "Liming Gao" To: "Dong, Eric" , "devel@edk2.groups.io" , "Bi, Dandan" Subject: Re: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type Thread-Topic: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type Thread-Index: AQHVJM/O+YaXjFwc8U6qMTWVn+CRkqagHcQAgADDY5A= Date: Tue, 18 Jun 2019 05:19:25 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E482D03@SHSMSX104.ccr.corp.intel.com> References: <20190617054442.36192-1-dandan.bi@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Dong, Eric >Sent: Tuesday, June 18, 2019 9:40 AM >To: devel@edk2.groups.io; Bi, Dandan >Cc: Gao, Liming >Subject: RE: [edk2-devel] [edk2-platforms] [patch] >Platform/Intel/DebugFeaturePkg: Update PCD type > >Reviewed-by: Eric Dong > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Dandan Bi >> Sent: Monday, June 17, 2019 1:45 PM >> To: devel@edk2.groups.io >> Cc: Dong, Eric ; Gao, Liming >> Subject: [edk2-devel] [edk2-platforms] [patch] >> Platform/Intel/DebugFeaturePkg: Update PCD type >> >> Add PcdAcpiDebugEnable and PcdAcpiDebugBufferSize into following >section >> which platform can customize the type by itself. >> [PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] >> >> Cc: Eric Dong >> Cc: Liming Gao >> Signed-off-by: Dandan Bi >> --- >> Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec >> b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec >> index 7389d36a57..37ebe6da4d 100644 >> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec >> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec >> @@ -49,10 +49,11 @@ [PcdsFixedAtBuild] >> ## This PCD sepcifies the start index in CMOS, it will occupy 1 byte= s space. >> >> gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortDeviceIndex|0x5A| >> UINT8|0x00000007 >> ## This PCD sepcifies the start index in CMOS, it will occupy 1 byte= s space. >> >> >gDebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortFunctionIndex|0x5B >> |UINT8|0x00000008 >> >> +[PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] >> ## This PCD specifies AcpiDebug feature is enable/disable. >> >> >gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugEnable|FALSE|BOOLEAN| >> 0x00000009 >> ## This PCD specifies AcpiDebug buffer size. >> >> >gDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize|0x10000|UINT >> 32|0x0000000A >> >> -- >> 2.18.0.windows.1 >> >> >>=20