From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Tue, 18 Jun 2019 06:26:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2019 06:26:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,389,1557212400"; d="scan'208";a="161745858" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 18 Jun 2019 06:26:50 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Jun 2019 06:26:49 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Jun 2019 06:26:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Tue, 18 Jun 2019 21:26:47 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "rebecca@bluestop.org" , "Fan, ZhijuX" CC: "Feng, Bob C" , "Zhang, Shenglei" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId Thread-Topic: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId Thread-Index: AdUk+vLr4sxSnH91SPaTu3pqAnspYAAAZ6qAADbW5mA= Date: Tue, 18 Jun 2019 13:26:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4831BF@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDYwMDg0MTQtNjEzYy00NmE5LWJlNTMtOGE3NGE2MmU5ODg3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNGcyQ0xhdFBiR2xpakw5a3VZaEdRbGVHenFabnhwQUFCdlNcL2h1b3dINnRONTk5cmNhS01OdHNHVkRKdU9nT1YifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Rebecca: Thanks for your report. Now, pylama is not the requirement for BaseTools= python script. Patch contributor can base on the report to fix the critica= l issue.=20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of re= becca@bluestop.org > Sent: Tuesday, June 18, 2019 3:05 AM > To: devel@edk2.groups.io; Fan, ZhijuX > Cc: Gao, Liming ; Feng, Bob C ; Zhang, Shenglei ; Kinney, > Michael D > Subject: Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool= GenBiosId >=20 > On 2019-06-17 04:54, Fan, ZhijuX wrote: > > GenBiosId is a tool to generate the BIOS ID binary file which uses > > the data from the configuration file. > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1846 >=20 >=20 > pylama (https://github.com/klen/pylama) reports the following issues: >=20 >=20 > bcran@photon:~/workspace/edk2/BaseTools/Source/Python/GenBiosId % pylama= . > GenBiosId.py:1:1: E266 too many leading '#' for block comment [pycodesty= le] > GenBiosId.py:19:1: E722 do not use bare 'except' [pycodestyle] > GenBiosId.py:21:1: W0401 'from Common.BuildToolError import *' used; > unable to detect undefined names [pyflakes] > GenBiosId.py:22:1: W0401 'from Common.Misc import *' used; unable to > detect undefined names [pyflakes] > GenBiosId.py:23:1: W0401 'from Common.DataType import *' used; unable to > detect undefined names [pyflakes] > GenBiosId.py:24:1: W0611 'Common.BuildVersion.gBUILD_VERSION' imported > but unused [pyflakes] > GenBiosId.py:34:80: E501 line too long (82 > 79 characters) [pycodestyle= ] > GenBiosId.py:38:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:38:28: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:38:43: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:39:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:39:28: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:39:43: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:40:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:40:21: E201 whitespace after '{' [pycodestyle] > GenBiosId.py:40:29: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:40:44: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:17: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:28: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:43: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:41:44: E231 missing whitespace after ':' [pycodestyle] > GenBiosId.py:42:20: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:42:31: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:42:50: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:43:20: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:43:31: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:43:48: E203 whitespace before ':' [pycodestyle] > GenBiosId.py:49:80: E501 line too long (83 > 79 characters) [pycodestyle= ] > GenBiosId.py:53:1: E302 expected 2 blank lines, found 1 [pycodestyle] > GenBiosId.py:53:1: C901 'Main' is too complex (17) [mccabe] > GenBiosId.py:55:80: E501 line too long (90 > 79 characters) [pycodestyle= ] > GenBiosId.py:57:80: E501 line too long (81 > 79 characters) [pycodestyle= ] > GenBiosId.py:59:80: E501 line too long (102 > 79 characters) [pycodestyl= e] > GenBiosId.py:60:80: E501 line too long (97 > 79 characters) [pycodestyle= ] > GenBiosId.py:61:80: E501 line too long (110 > 79 characters) [pycodestyl= e] > GenBiosId.py:65:80: E501 line too long (86 > 79 characters) [pycodestyle= ] > GenBiosId.py:65:28: E225 missing whitespace around operator [pycodestyle= ] > GenBiosId.py:66:1: W0401 'OPTION_MISSING may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:68:1: W0401 'OPTION_MISSING may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:69:1: W0401 'FatalError may be undefined, or defined from > star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:69:1: W0612 local variable 'X' is assigned to but never > used [pyflakes] > GenBiosId.py:75:80: E501 line too long (86 > 79 characters) [pycodestyle= ] > GenBiosId.py:75:1: W0401 'FILE_NOT_FOUND may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:80:80: E501 line too long (93 > 79 characters) [pycodestyle= ] > GenBiosId.py:80:1: W0401 'FORMAT_NOT_SUPPORTED may be undefined, or > defined from star imports: Common.BuildToolError, Common.DataType, > Common.Misc' [pyflakes] > GenBiosId.py:85:80: E501 line too long (93 > 79 characters) [pycodestyle= ] > GenBiosId.py:85:1: W0401 'FORMAT_INVALID may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:88:80: E501 line too long (92 > 79 characters) [pycodestyle= ] > GenBiosId.py:88:1: W0401 'FORMAT_INVALID may be undefined, or defined > from star imports: Common.BuildToolError, Common.DataType, Common.Misc' > [pyflakes] > GenBiosId.py:91:80: E501 line too long (101 > 79 characters) [pycodestyl= e] > GenBiosId.py:91:1: W0401 'FORMAT_UNKNOWN_ERROR may be undefined, or > defined from star imports: Common.BuildToolError, Common.DataType, > Common.Misc' [pyflakes] > GenBiosId.py:95:80: E501 line too long (173 > 79 characters) [pycodestyl= e] > GenBiosId.py:96:80: E501 line too long (111 > 79 characters) [pycodestyl= e] > GenBiosId.py:96:14: E127 continuation line over-indented for visual > indent [pycodestyle] > GenBiosId.py:114:1: E305 expected 2 blank lines after class or function > definition, found 1 [pycodestyle] > GenBiosId.py:116:5: E266 too many leading '#' for block comment > [pycodestyle] > GenBiosId.py:117:24: E701 multiple statements on one line (colon) > [pycodestyle] >=20 >=20 >=20