From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 18 Jun 2019 07:06:30 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2019 07:06:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,389,1557212400"; d="scan'208";a="160068332" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 18 Jun 2019 07:06:30 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Jun 2019 07:06:30 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Jun 2019 07:06:29 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000; Tue, 18 Jun 2019 22:06:27 +0800 From: "Liming Gao" To: "Feng, Bob C" , "Zhang, Shenglei" , "devel@edk2.groups.io" Subject: Re: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo Thread-Topic: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo Thread-Index: AQHVIBWzwoUhp7ltrEiJMtIef+eGz6afGXQAgAJjgvA= Date: Tue, 18 Jun 2019 14:06:27 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E483219@SHSMSX104.ccr.corp.intel.com> References: <20190611052240.17152-1-shenglei.zhang@intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16015281E@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16015281E@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmQxZWQwYWQtZDI1Zi00YWQ0LTkzYWQtZDIzNTA2YjI0NWNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK09tNEtqK0tBd0xWdndMWGZvS3VSdlB5QkI3V0hHaDFLdEQ3Tkg4WTdPQzE4NWp0OGtYRjVnRVNwRVRMYXlwZSJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob: I think these two C tools are only verified for IA32 and X64 arch OS. The= y may not work on ARM or AARCH64 OS. Once they are added into BaseTools C M= akefile, they may cause compile failure on ARM or AARCH64 OS. So, I suggest= to move them into edk2-platforms/Platform/Intel/Tools directory first.=20 Thanks Liming > -----Original Message----- > From: Feng, Bob C > Sent: Monday, June 17, 2019 5:35 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo >=20 > Adding FMMT, FCE to BaseTools is fine for me. >=20 > The patch is good to me. > Reviewed-by: Bob Feng >=20 > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, June 11, 2019 1:23 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo >=20 > REF:FMMT(https://bugzilla.tianocore.org/show_bug.cgi?id=3D1847) > FCE(https://bugzilla.tianocore.org/show_bug.cgi?id=3D1848) >=20 > Changes are committed in forked repository: > https://github.com/shenglei10/edk2/commits/movetool >=20 > FCE & FMMT tools are in https://firmware.intel.com/develop > Intel UEFI tools and utilities. Now, this patch moves them to edk2 repo B= aseTools directory. Besides, this patch updates their license header > to BSD-2-Clause-Patent, and does some bug fixes. >=20 > Cc: Bob Feng > Cc: Liming Gao > Shenglei Zhang (3): > BaseTools/BfmLib: Add BfmLib to edk2/master > BaseTools/FCE: Add FCE tool to edk2/master > BaseTools/FMMT: Add a new tool FMMT >=20 > BaseTools/Source/C/BfmLib/BfmLib.c | 4355 +++++++++++ > BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 +++ > BaseTools/Source/C/FCE/BinaryCreate.c | 216 + > BaseTools/Source/C/FCE/BinaryParse.c | 1326 ++++ > BaseTools/Source/C/FCE/Common.c | 2183 ++++++ > BaseTools/Source/C/FCE/Expression.c | 2367 ++++++ > BaseTools/Source/C/FCE/Fce.c | 6449 +++++++++++++++++ > BaseTools/Source/C/FCE/IfrParse.c | 4836 ++++++++++++ > .../Source/C/FCE/MonotonicBasedVariable.c | 874 +++ > BaseTools/Source/C/FCE/TimeBasedVariable.c | 878 +++ > BaseTools/Source/C/FCE/Variable.c | 1091 +++ > .../Source/C/FMMT/FirmwareModuleManagement.c | 2559 +++++++ > BaseTools/Source/C/FMMT/FmmtLib.c | 5051 +++++++++++++ > BaseTools/Source/C/FMMT/Rebase.c | 846 +++ > BaseTools/BinWrappers/PosixLike/BfmLib | 29 + > BaseTools/BinWrappers/PosixLike/FCE | 29 + > BaseTools/BinWrappers/PosixLike/FMMT | 29 + > BaseTools/Source/C/BfmLib/BinFileManager.h | 439 ++ > BaseTools/Source/C/BfmLib/GNUmakefile | 15 + > BaseTools/Source/C/BfmLib/Makefile | 17 + > BaseTools/Source/C/FCE/BinaryCreate.h | 157 + > BaseTools/Source/C/FCE/BinaryParse.h | 187 + > BaseTools/Source/C/FCE/Common.h | 999 +++ > BaseTools/Source/C/FCE/Fce.h | 447 ++ > BaseTools/Source/C/FCE/GNUmakefile | 55 + > BaseTools/Source/C/FCE/IfrParse.h | 789 ++ > BaseTools/Source/C/FCE/Makefile | 19 + > .../Source/C/FCE/MonotonicBasedVariable.h | 162 + > BaseTools/Source/C/FCE/TimeBasedVariable.h | 166 + > BaseTools/Source/C/FCE/Variable.h | 154 + > BaseTools/Source/C/FCE/VariableCommon.h | 55 + > .../Source/C/FMMT/FirmwareModuleManagement.h | 479 ++ > BaseTools/Source/C/FMMT/FmmtConf.ini | 6 + > BaseTools/Source/C/FMMT/GNUmakefile | 16 + > BaseTools/Source/C/FMMT/Makefile | 17 + > BaseTools/Source/C/FMMT/Rebase.h | 31 + > BaseTools/Source/C/GNUmakefile | 5 +- > BaseTools/Source/C/Makefile | 5 +- > 38 files changed, 38360 insertions(+), 2 deletions(-) create mode 10064= 4 BaseTools/Source/C/BfmLib/BfmLib.c > create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c > create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c > create mode 100644 BaseTools/Source/C/FCE/BinaryParse.c > create mode 100644 BaseTools/Source/C/FCE/Common.c create mode 100644 B= aseTools/Source/C/FCE/Expression.c > create mode 100644 BaseTools/Source/C/FCE/Fce.c create mode 100644 Base= Tools/Source/C/FCE/IfrParse.c create mode 100644 > BaseTools/Source/C/FCE/MonotonicBasedVariable.c > create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c > create mode 100644 BaseTools/Source/C/FCE/Variable.c create mode 100644 > BaseTools/Source/C/FMMT/FirmwareModuleManagement.c > create mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c create mode 100644= BaseTools/Source/C/FMMT/Rebase.c create mode > 100755 BaseTools/BinWrappers/PosixLike/BfmLib > create mode 100755 BaseTools/BinWrappers/PosixLike/FCE > create mode 100755 BaseTools/BinWrappers/PosixLike/FMMT > create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h > create mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile > create mode 100644 BaseTools/Source/C/BfmLib/Makefile > create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h > create mode 100644 BaseTools/Source/C/FCE/BinaryParse.h > create mode 100644 BaseTools/Source/C/FCE/Common.h create mode 100644 B= aseTools/Source/C/FCE/Fce.h create mode 100644 > BaseTools/Source/C/FCE/GNUmakefile > create mode 100644 BaseTools/Source/C/FCE/IfrParse.h create mode 100644= BaseTools/Source/C/FCE/Makefile create mode 100644 > BaseTools/Source/C/FCE/MonotonicBasedVariable.h > create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h > create mode 100644 BaseTools/Source/C/FCE/Variable.h create mode 100644= BaseTools/Source/C/FCE/VariableCommon.h > create mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h > create mode 100644 BaseTools/Source/C/FMMT/FmmtConf.ini > create mode 100644 BaseTools/Source/C/FMMT/GNUmakefile > create mode 100644 BaseTools/Source/C/FMMT/Makefile create mode 100644 = BaseTools/Source/C/FMMT/Rebase.h >=20 > -- > 2.18.0.windows.1