From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Thu, 20 Jun 2019 18:24:10 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 18:24:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,398,1557212400"; d="scan'208";a="154304437" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 20 Jun 2019 18:24:09 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Jun 2019 18:24:09 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Jun 2019 18:24:05 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000; Fri, 21 Jun 2019 09:24:02 +0800 From: "Liming Gao" To: Krzysztof Koch , "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sami Mujawar , nd Subject: Re: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT Thread-Topic: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT Thread-Index: AQHVIU06cqZ8IldPXUi2ww9xSM5imaaZffGAgAqoKYCAATdB0A== Date: Fri, 21 Jun 2019 01:24:02 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E487EA8@SHSMSX104.ccr.corp.intel.com> References: <20190612141046.30168-1-krzysztof.koch@arm.com> <20190612141046.30168-2-krzysztof.koch@arm.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E480763@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjk2MDZkMmUtOWVlZS00YTgzLTg4MmQtNWM1YjIxZGNmY2RiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOXpUTW13R0N5VzdZb20yQytXSUhQZ1kyUkFlQjE3MEdBUlhcLysxVDZxUkxUMWs5Z3ZiVk5IcHhib3VqOWpNNlEifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push @425d8d487fe20e76281fd7da074592508d03f9c0 > -----Original Message----- > From: Krzysztof Koch [mailto:Krzysztof.Koch@arm.com] > Sent: Thursday, June 20, 2019 10:50 PM > To: Gao, Liming ; Kinney, Michael D ; devel@edk2.groups.io > Cc: Sami Mujawar ; nd > Subject: RE: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator A= ffinity Structure definitions to SRAT >=20 > Hi, >=20 > Do you need any help from me to get this patch merged? >=20 > Kind regards, >=20 > Krzysztof >=20 > -----Original Message----- > From: Gao, Liming > Sent: Thursday, June 13, 2019 13:05 > To: devel@edk2.groups.io; Krzysztof Koch > Cc: Carsey, Jaben ; Ni, Ray ; = Gao, Zhichao ; Kinney, Michael D > ; Sami Mujawar ; Matte= o Carlini ; Stephanie > Hughes-Fitt ; nd > Subject: RE: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator A= ffinity Structure definitions to SRAT >=20 > Reviewed-by: Liming Gao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Krzysztof Koch > > Sent: Wednesday, June 12, 2019 10:11 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray > > ; Gao, Zhichao ; Kinney, > > Michael D ; Gao, Liming > > ; Sami.Mujawar@arm.com; Matteo.Carlini@arm.com; > > Stephanie.Hughes-Fitt@arm.com; nd@arm.com > > Subject: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator > > Affinity Structure definitions to SRAT > > > > Add Generic Initiator Affinity Structure to the list of recognised > > System Resource Affinity Table (SRAT) structure types. > > > > Add definitions for Device Handle Types inside the Generic Initiator > > Affinity Structure. > > > > References: > > - ACPI 6.3 January 2019, Table 5-78 > > > > Signed-off-by: Krzysztof Koch > > --- > > > > Changes can be seen at: > > https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1 > > > > Notes: > > v1: > > - define the SRAT Generic Initiator Affinity Struct type [Krzyszto= f] > > - define the SRAT Device Handle Types [Krzysztof] > > > > MdePkg/Include/IndustryStandard/Acpi63.h | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h > > b/MdePkg/Include/IndustryStandard/Acpi63.h > > index > > a8e011579ffcf070ecdfd2c6726a16d1afd65891..eca1f9357b70f10887e680ff13c9 > > 7c0beab3600b 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi63.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi63.h > > @@ -639,7 +639,7 @@ typedef struct { > > > > // > > // SRAT structure types. > > -// All other values between 0x05 an 0xFF are reserved and > > +// All other values between 0x06 an 0xFF are reserved and > > // will be ignored by OSPM. > > // > > #define EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC_SAPIC_AFFINITY 0x00 @@ > > -647,6 +647,7 @@ typedef struct { > > #define EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC_AFFINITY 0x02 > > #define EFI_ACPI_6_3_GICC_AFFINITY 0x03 > > #define EFI_ACPI_6_3_GIC_ITS_AFFINITY 0x04 > > +#define EFI_ACPI_6_3_GENERIC_INITIATOR_AFFINITY 0x05 > > > > /// > > /// Processor Local APIC/SAPIC Affinity Structure Definition @@ > > -733,6 +734,14 @@ typedef struct { > > UINT32 ItsId; > > } EFI_ACPI_6_3_GIC_ITS_AFFINITY_STRUCTURE; > > > > +// > > +// Generic Initiator Affinity Structure Device Handle Types // All > > +other values between 0x02 an 0xFF are reserved and // will be ignored > > +by OSPM. > > +// > > +#define EFI_ACPI_6_3_ACPI_DEVICE_HANDLE 0x00 > > +#define EFI_ACPI_6_3_PCI_DEVICE_HANDLE 0x01 > > + > > /// > > /// Device Handle - ACPI > > /// > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > > > >=20