From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Sun, 23 Jun 2019 20:17:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jun 2019 20:17:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,410,1557212400"; d="scan'208";a="359424785" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 23 Jun 2019 20:17:15 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 23 Jun 2019 20:17:15 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Mon, 24 Jun 2019 11:17:13 +0800 From: "Liming Gao" To: "Fan, ZhijuX" , "devel@edk2.groups.io" CC: "Feng, Bob C" Subject: Re: [PATCH] BaseTools:Linux changes the way the latest version is judged Thread-Topic: [PATCH] BaseTools:Linux changes the way the latest version is judged Thread-Index: AdUn2a1I5GjkZ+HKSWepRU50T/llRwCYZdHg Date: Mon, 24 Jun 2019 03:17:13 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48B2DA@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmE3NjQ1ZTEtMzZjMS00NTBiLThhNmEtMDQyODI3ZTNhOWY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9QUTNPMlAreEJiM1VNblNWemFGUUZVWWlYaFhPSUgxTmlHVytcL2V6cHRHZTROaHRrMnpmUzYzTjlOQTNKUStrIn0= dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhiju: The change is good. What test have you done? Thanks Liming > -----Original Message----- > From: Fan, ZhijuX > Sent: Friday, June 21, 2019 10:33 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] BaseTools:Linux changes the way the latest version is ju= dged >=20 > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1929 >=20 > Some Linux servers do not have BC installed,so errors occur. > So the judgment was changed to avoid this error. >=20 > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Zhiju.Fan > --- > edksetup.sh | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/edksetup.sh b/edksetup.sh > index c7b2e1e201..0723e7b85a 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -122,8 +122,7 @@ function SetupPython3() > export PYTHON_COMMAND=3D$python > continue > fi > - ret=3D`echo "$origin_version < $python_version" |bc` > - if [ "$ret" -eq 1 ]; then > + if [ "$origin_version" \< "$python_version" ]; then > origin_version=3D$python_version > export PYTHON_COMMAND=3D$python > fi > @@ -165,8 +164,7 @@ function SetupPython() > export PYTHON_COMMAND=3D$python > continue > fi > - ret=3D`echo "$origin_version < $python_version" |bc` > - if [ "$ret" -eq 1 ]; then > + if [ "$origin_version" \< "$python_version" ]; then > origin_version=3D$python_version > export PYTHON_COMMAND=3D$python > fi > -- > 2.14.1.windows.1