From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Tue, 25 Jun 2019 08:20:43 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 08:20:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,416,1557212400"; d="scan'208";a="360429387" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 25 Jun 2019 08:20:42 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 08:20:42 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 25 Jun 2019 08:20:42 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 25 Jun 2019 08:20:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000; Tue, 25 Jun 2019 23:20:40 +0800 From: "Liming Gao" To: "Yao, Jiewen" , "devel@edk2.groups.io" , "Zhang, Shenglei" , "ard.biesheuvel@linaro.org" , "leif.lindholm@linaro.org" CC: "Feng, Bob C" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen Thread-Topic: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen Thread-Index: AQHVJ9Bq/SuxWAzriEKuSGcQ32Wot6ak24YAgACHA9D//4wggIAHdxQQ//+FQYCAAJUF4A== Date: Tue, 25 Jun 2019 15:20:39 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48D2F4@SHSMSX104.ccr.corp.intel.com> References: <20190621012643.9352-1-shenglei.zhang@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6C30A2@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48803E@SHSMSX104.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6C355E@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48D1AA@SHSMSX104.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6CC44F@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F6CC44F@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTkxNTA5ZGYtNjkwMi00NzJmLWI3MTYtN2E1NWVhNzA2YjhjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNXB4YldqazJpbTlUd3FhcE1HbmpGN05HNFdBNmwyUis1SGgxN2QraG15a0VUYkcxQUtIXC9nTHVoNVFwYkgzYzQifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen: Thanks Liming > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, June 25, 2019 10:15 PM > To: Gao, Liming ; devel@edk2.groups.io; Zhang, She= nglei ; ard.biesheuvel@linaro.org; > leif.lindholm@linaro.org > Cc: Feng, Bob C > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE a= nd FitGen >=20 > Thanks Liming. >=20 > I would treat that as *a general help request* to validate the BaseTool = update on ARM/AARCH64 Linux OS. >=20 Yes. This is a help request.=20 > If we can have Ard or any other ARM person to help validate a new base t= ool patch, that will be great. >=20 > In this case, it is about the new added FCE or FMMT. > In the future, maybe we have other C-tool update. >=20 > Should we add them to CC list in any tool patch? >=20 FCE and FMMT are new tools with lots of source code. If they meet with the= compile failure, it may take more effort to fix them.=20 So, I want to verify them before submit the patches. If the code change is= not big, the developer can fix the error quickly=20 after the code is submitted. That's also fine to verify the change after s= ubmit.=20 Thanks Liming >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Tuesday, June 25, 2019 10:09 PM > > To: Yao, Jiewen ; devel@edk2.groups.io; Zhang, > > Shenglei ; ard.biesheuvel@linaro.org; > > leif.lindholm@linaro.org > > Cc: Feng, Bob C > > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE > > and FitGen > > > > Jiewen: > > For FCE/FMMT C tools, I only compile them on X64 Linux OS. I don't > > compile them on ARM or AARCH64 Linux OS for ARM native build. Now, > > edk2 BaseTools C tools top level Makefile supports ARM, AARCH64, IA32 = and > > X64. If they don't pass build on ARM native Linux OS, this change will= bring > > the break for some user. If we can avoid the break, I agree to add the= m into > > edk2 BaseTools. > > > > Ard: > > I have no ARM or AARCH64 Linux OS. Could you help compile FCE/FMMT > > tools in ARM or AARCH64 Linux OS? These patches are in > > https://github.com/shenglei10/edk2/commits/movetool. After pick those > > patches, you just need to type make in BaseTools directory and compile= all C > > tools. FCE/FMMT are common tools to update FD/FV image binaries. FMMT > > is a tool to enable removal, addition and replacement of FFS files in = FD > > image binaries. FCE is a tool to retrieve and change HII configuration= data as > > the default NV variable in Firmware Device(*.fd) files. They are used = in post > > build step to replace FFS or insert the default NV storage in FD image= . > > > > Thanks > > Liming > > > -----Original Message----- > > > From: Yao, Jiewen > > > Sent: Friday, June 21, 2019 11:34 AM > > > To: Gao, Liming ; devel@edk2.groups.io; Zhang, > > Shenglei > > > Cc: Feng, Bob C > > > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT F= CE > > and FitGen > > > > > > Sorry, I missed the first mail. > > > I saw there is no V2 tag in this series, so I think it is the first = mail. My > > apology. > > > > > > I have no concern on FitGen - it is Intel only. You can check in at = first. > > > FMMT/FCE is common. I think BaseTools is more proper place. > > > > > > "It is not validated" - it seems a weird justification to me. > > > Or does it mean, for any future feature Intel/ARM people contribute,= we > > should treat Platform package as the first choice, just because the > > > it is cross validated? > > > > > > May I understand more on the rule we have today on what goes to EDK2 > > repo and what goes to EDK2-PLATFORM repo? > > > > > > Thank you > > > Yao Jiewen > > > > > > > > > > -----Original Message----- > > > > From: Gao, Liming > > > > Sent: Friday, June 21, 2019 10:31 AM > > > > To: Yao, Jiewen ; devel@edk2.groups.io; Zhan= g, > > > > Shenglei > > > > Cc: Feng, Bob C > > > > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT= FCE > > > > and FitGen > > > > > > > > Jiewen: > > > > I give the comments > > > > > > https://edk2.groups.io/g/devel/message/42545?p=3D,,,20,0,0,0::Created,= ,FM > > > > MT,20,2,0,32013143 for the patch BaseTools/FCE: Add a tool FCE > > > > > > > > I give new proposal https://edk2.groups.io/g/devel/message/42546 > > for > > > > those tools. > > > > > > > > Thanks > > > > Liming > > > > > -----Original Message----- > > > > > From: Yao, Jiewen > > > > > Sent: Friday, June 21, 2019 10:26 AM > > > > > To: devel@edk2.groups.io; Zhang, Shenglei > > > > > > > Cc: Feng, Bob C ; Gao, Liming > > > > ; Yao, Jiewen > > > > > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FM= MT > > FCE > > > > and FitGen > > > > > > > > > > HI > > > > > I saw some conflict: > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > BaseTools/FCE: Add a tool FCE > > > > > Add FMMT and FCE into Platform/Intel/Tools. > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > > > > > > I agree that FitGet goes to Intel silicon. > > > > > > > > > > Should we put both FCE/FMMT to BaseTools? > > > > > > > > > > Thank you > > > > > Yao Jiewen > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On > > Behalf > > > > Of > > > > > > Zhang, Shenglei > > > > > > Sent: Friday, June 21, 2019 9:27 AM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > > > > > > > Subject: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT= FCE > > and > > > > > > FitGen > > > > > > > > > > > > Add FMMT and FCE into Platform/Intel/Tools. > > > > > > Add FitGen into Silicon/Intel/Tools. > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1847 > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1848 > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1849 > > > > > > > > > > > > Cc: Bob Feng > > > > > > Cc: Liming Gao > > > > > > Shenglei Zhang (6): > > > > > > Platform/Tools: Add a tool FMMT > > > > > > Platform/Tools: Add a tool BfmLib > > > > > > BaseTools/FCE: Add a tool FCE > > > > > > Platform/Tools: Add top level Makefile and GNUMakefile > > > > > > Silicon/Tools: Add a tool FitGen > > > > > > Silicon/Tools: Add top level Makefile and GNUMakefile > > > > > > > > > > > > Platform/Intel/Tools/BfmLib/BfmLib.c | 4355 > > +++++++++++ > > > > > > Platform/Intel/Tools/BfmLib/BinFileManager.c | 1024 +++ > > > > > > Platform/Intel/Tools/BfmLib/BinFileManager.h | 439 ++ > > > > > > Platform/Intel/Tools/BfmLib/GNUmakefile | 15 + > > > > > > Platform/Intel/Tools/BfmLib/Makefile | 17 + > > > > > > Platform/Intel/Tools/FCE/BinaryCreate.c | 216 + > > > > > > Platform/Intel/Tools/FCE/BinaryCreate.h | 157 + > > > > > > Platform/Intel/Tools/FCE/BinaryParse.c | 1326 ++++ > > > > > > Platform/Intel/Tools/FCE/BinaryParse.h | 187 + > > > > > > Platform/Intel/Tools/FCE/Common.c | 2183 ++++++ > > > > > > Platform/Intel/Tools/FCE/Common.h | 999 +++ > > > > > > Platform/Intel/Tools/FCE/Expression.c | 2367 ++++++ > > > > > > Platform/Intel/Tools/FCE/Fce.c | 6449 > > > > > > +++++++++++++++++ > > > > > > Platform/Intel/Tools/FCE/Fce.h | 447 ++ > > > > > > Platform/Intel/Tools/FCE/GNUmakefile | 22 + > > > > > > Platform/Intel/Tools/FCE/IfrParse.c | 4836 > > ++++++++++++ > > > > > > Platform/Intel/Tools/FCE/IfrParse.h | 789 ++ > > > > > > Platform/Intel/Tools/FCE/Makefile | 19 + > > > > > > .../Intel/Tools/FCE/MonotonicBasedVariable.c | 874 +++ > > > > > > .../Intel/Tools/FCE/MonotonicBasedVariable.h | 162 + > > > > > > Platform/Intel/Tools/FCE/TimeBasedVariable.c | 878 +++ > > > > > > Platform/Intel/Tools/FCE/TimeBasedVariable.h | 166 + > > > > > > Platform/Intel/Tools/FCE/Variable.c | 1091 +++ > > > > > > Platform/Intel/Tools/FCE/Variable.h | 154 + > > > > > > Platform/Intel/Tools/FCE/VariableCommon.h | 55 + > > > > > > .../Tools/FMMT/FirmwareModuleManagement.c | 2559 > > +++++++ > > > > > > .../Tools/FMMT/FirmwareModuleManagement.h | 479 ++ > > > > > > Platform/Intel/Tools/FMMT/FmmtConf.ini | 6 + > > > > > > Platform/Intel/Tools/FMMT/FmmtLib.c | 5051 > > > > > > +++++++++++++ > > > > > > Platform/Intel/Tools/FMMT/GNUmakefile | 16 + > > > > > > Platform/Intel/Tools/FMMT/Makefile | 17 + > > > > > > Platform/Intel/Tools/FMMT/Rebase.c | 846 +++ > > > > > > Platform/Intel/Tools/FMMT/Rebase.h | 31 + > > > > > > Platform/Intel/Tools/GNUmakefile | 30 + > > > > > > Platform/Intel/Tools/Makefile | 33 + > > > > > > Silicon/Intel/Tools/FitGen/FitGen.c | 3137 ++++++++ > > > > > > Silicon/Intel/Tools/FitGen/FitGen.h | 48 + > > > > > > Silicon/Intel/Tools/FitGen/GNUmakefile | 16 + > > > > > > Silicon/Intel/Tools/FitGen/Makefile | 17 + > > > > > > Silicon/Intel/Tools/GNUmakefile | 34 + > > > > > > Silicon/Intel/Tools/Makefile | 31 + > > > > > > 41 files changed, 41578 insertions(+) > > > > > > create mode 100644 Platform/Intel/Tools/BfmLib/BfmLib.c > > > > > > create mode 100644 > > Platform/Intel/Tools/BfmLib/BinFileManager.c > > > > > > create mode 100644 > > Platform/Intel/Tools/BfmLib/BinFileManager.h > > > > > > create mode 100644 Platform/Intel/Tools/BfmLib/GNUmakefile > > > > > > create mode 100644 Platform/Intel/Tools/BfmLib/Makefile > > > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryCreate.c > > > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryCreate.h > > > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryParse.c > > > > > > create mode 100644 Platform/Intel/Tools/FCE/BinaryParse.h > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Common.c > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Common.h > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Expression.c > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Fce.c > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Fce.h > > > > > > create mode 100644 Platform/Intel/Tools/FCE/GNUmakefile > > > > > > create mode 100644 Platform/Intel/Tools/FCE/IfrParse.c > > > > > > create mode 100644 Platform/Intel/Tools/FCE/IfrParse.h > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Makefile > > > > > > create mode 100644 > > > > Platform/Intel/Tools/FCE/MonotonicBasedVariable.c > > > > > > create mode 100644 > > > > Platform/Intel/Tools/FCE/MonotonicBasedVariable.h > > > > > > create mode 100644 > > Platform/Intel/Tools/FCE/TimeBasedVariable.c > > > > > > create mode 100644 > > Platform/Intel/Tools/FCE/TimeBasedVariable.h > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Variable.c > > > > > > create mode 100644 Platform/Intel/Tools/FCE/Variable.h > > > > > > create mode 100644 Platform/Intel/Tools/FCE/VariableCommon.h > > > > > > create mode 100644 > > > > > > Platform/Intel/Tools/FMMT/FirmwareModuleManagement.c > > > > > > create mode 100644 > > > > > > Platform/Intel/Tools/FMMT/FirmwareModuleManagement.h > > > > > > create mode 100644 Platform/Intel/Tools/FMMT/FmmtConf.ini > > > > > > create mode 100644 Platform/Intel/Tools/FMMT/FmmtLib.c > > > > > > create mode 100644 Platform/Intel/Tools/FMMT/GNUmakefile > > > > > > create mode 100644 Platform/Intel/Tools/FMMT/Makefile > > > > > > create mode 100644 Platform/Intel/Tools/FMMT/Rebase.c > > > > > > create mode 100644 Platform/Intel/Tools/FMMT/Rebase.h > > > > > > create mode 100644 Platform/Intel/Tools/GNUmakefile > > > > > > create mode 100644 Platform/Intel/Tools/Makefile > > > > > > create mode 100644 Silicon/Intel/Tools/FitGen/FitGen.c > > > > > > create mode 100644 Silicon/Intel/Tools/FitGen/FitGen.h > > > > > > create mode 100644 Silicon/Intel/Tools/FitGen/GNUmakefile > > > > > > create mode 100644 Silicon/Intel/Tools/FitGen/Makefile > > > > > > create mode 100644 Silicon/Intel/Tools/GNUmakefile > > > > > > create mode 100644 Silicon/Intel/Tools/Makefile > > > > > > > > > > > > -- > > > > > > 2.18.0.windows.1 > > > > > > > > > > > > > > > > > >=20