Re: [edk2-platform patch 6/6] Silicon\Tools: Add top level Makefile and GNUMakefile

["Liming Gao" <liming.gao@intel.com>]

Shenglei:
  See my comments. 

Thanks
Liming
>-----Original Message-----
>From: Zhang, Shenglei
>Sent: Friday, June 21, 2019 9:27 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [edk2-platform patch 6/6] Silicon\Tools: Add top level Makefile and
>GNUMakefile
>
>Add FitGen into Makefile and GNUMakefile.
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> Silicon/Intel/Tools/GNUmakefile | 34
>+++++++++++++++++++++++++++++++++
> Silicon/Intel/Tools/Makefile    | 31 ++++++++++++++++++++++++++++++
> 2 files changed, 65 insertions(+)
> create mode 100644 Silicon/Intel/Tools/GNUmakefile
> create mode 100644 Silicon/Intel/Tools/Makefile
>
>diff --git a/Silicon/Intel/Tools/GNUmakefile
>b/Silicon/Intel/Tools/GNUmakefile
>new file mode 100644
>index 0000000000..77cfc62250
>--- /dev/null
>+++ b/Silicon/Intel/Tools/GNUmakefile
>@@ -0,0 +1,34 @@
>+## @file
>+#  GNUmakefile for building C utilities.
>+#
>+#  Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
>+#  This software and associated documentation (if any) is furnished
>+#  under a license and may only be used or copied in accordance
>+#  with the terms of the license. Except as permitted by such
>+#  license, no part of this software or documentation may be
>+#  reproduced, stored in a retrieval system, or transmitted in any
>+#  form or by any means without the express written consent of
>+#  Intel Corporation.
>+#
>+##

Please update license for BSD + Patent. 

Thanks
Liming

>+
>+MAKEROOT = $(EDK_TOOLS_PATH)/Source/C
>+
>+APPLICATIONS = \
>+  FitGen \
>+
>+SUBDIRS := $(APPLICATIONS)
>+
>+$(APPLICATIONS): $(MAKEROOT)/bin
>+
>+.PHONY: subdirs $(SUBDIRS)
>+subdirs: $(SUBDIRS)
>+$(SUBDIRS):
>+    $(MAKE) -C $@
>+
>+.PHONY: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
>+$(patsubst %,%-clean,$(sort $(SUBDIRS))):
>+    -$(MAKE) -C $(@:-clean=) clean
>+
>+clean: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
>+
>diff --git a/Silicon/Intel/Tools/Makefile b/Silicon/Intel/Tools/Makefile
>new file mode 100644
>index 0000000000..e52c95b7b5
>--- /dev/null
>+++ b/Silicon/Intel/Tools/Makefile
>@@ -0,0 +1,31 @@
>+## @file
>+#  makefile for building C utilities.
>+#
>+#  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>+#  SPDX-License-Identifier: BSD-2-Clause-Patent
>+#
>+##
>+
>+!INCLUDE $(EDK_TOOLS_PATH)\Source\C\Makefiles\ms.common
>+
>+APPLICATIONS = \
>+  FitGen \
>+
>+all: $(APPLICATIONS)
>+    @echo.
>+    @echo ######################
>+    @echo # Build executables
>+    @echo ######################
>+    @if not exist $(BIN_PATH) mkdir $(BIN_PATH)
>+    @$(EDK_TOOLS_PATH)\Source\C\Makefiles\NmakeSubdirs.bat all $**
>+
>+.PHONY: clean
>+clean: $(APPLICATIONS)
>+  @$(EDK_TOOLS_PATH)\Source\C\Makefiles\NmakeSubdirs.bat clean $**
>+
>+.PHONY: cleanall
>+cleanall: $(APPLICATIONS)
>+  @$(EDK_TOOLS_PATH)\Source\C\Makefiles\NmakeSubdirs.bat cleanall
>$**
>+
>+!INCLUDE $(EDK_TOOLS_PATH)\Source\C\Makefiles\ms.rule
>+
>--
>2.18.0.windows.1