From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by groups.io with SMTP; Wed, 26 Jun 2019 00:15:02 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 00:15:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,418,1557212400"; 
   d="scan'208";a="164259977"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga003.jf.intel.com with ESMTP; 26 Jun 2019 00:15:00 -0700
Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 26 Jun 2019 00:15:00 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 26 Jun 2019 00:15:00 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000;
 Wed, 26 Jun 2019 15:14:58 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-platform patch v2] Silicon/Tools: Add top level Makefile and GNUMakefile
Thread-Topic: [edk2-platform patch v2] Silicon/Tools: Add top level Makefile
 and GNUMakefile
Thread-Index: AQHVK9B4J6bKVyud90GJ5a7bxp0Gv6atheqQ
Date: Wed, 26 Jun 2019 07:14:58 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48D8D6@SHSMSX104.ccr.corp.intel.com>
References: <20190626033641.4288-1-shenglei.zhang@intel.com>
In-Reply-To: <20190626033641.4288-1-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

Please remove V2 in the commit message.=20

>-----Original Message-----
>From: Zhang, Shenglei
>Sent: Wednesday, June 26, 2019 11:37 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [edk2-platform patch v2] Silicon/Tools: Add top level Makefile an=
d
>GNUMakefile
>
>Add FitGen into Makefile and GNUMakefile.
>
>v2: Update the license in GNUmakefile.
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> Silicon/Intel/Tools/GNUmakefile | 28 ++++++++++++++++++++++++++++
> Silicon/Intel/Tools/Makefile    | 31 +++++++++++++++++++++++++++++++
> 2 files changed, 59 insertions(+)
> create mode 100644 Silicon/Intel/Tools/GNUmakefile
> create mode 100644 Silicon/Intel/Tools/Makefile
>
>diff --git a/Silicon/Intel/Tools/GNUmakefile
>b/Silicon/Intel/Tools/GNUmakefile
>new file mode 100644
>index 0000000000..20abf148b5
>--- /dev/null
>+++ b/Silicon/Intel/Tools/GNUmakefile
>@@ -0,0 +1,28 @@
>+## @file
>+#  GNUmakefile for building C utilities.
>+#
>+#  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>+#  SPDX-License-Identifier: BSD-2-Clause-Patent
>+#
>+##
>+
>+MAKEROOT =3D $(EDK_TOOLS_PATH)/Source/C
>+
>+APPLICATIONS =3D \
>+  FitGen \
>+
>+SUBDIRS :=3D $(APPLICATIONS)
>+
>+$(APPLICATIONS): $(MAKEROOT)/bin
>+
>+.PHONY: subdirs $(SUBDIRS)
>+subdirs: $(SUBDIRS)
>+$(SUBDIRS):
>+    $(MAKE) -C $@
>+
>+.PHONY: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
>+$(patsubst %,%-clean,$(sort $(SUBDIRS))):
>+    -$(MAKE) -C $(@:-clean=3D) clean
>+
>+clean: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
>+
>diff --git a/Silicon/Intel/Tools/Makefile b/Silicon/Intel/Tools/Makefile
>new file mode 100644
>index 0000000000..e52c95b7b5
>--- /dev/null
>+++ b/Silicon/Intel/Tools/Makefile
>@@ -0,0 +1,31 @@
>+## @file
>+#  makefile for building C utilities.
>+#
>+#  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>+#  SPDX-License-Identifier: BSD-2-Clause-Patent
>+#
>+##
>+
>+!INCLUDE $(EDK_TOOLS_PATH)\Source\C\Makefiles\ms.common
>+
>+APPLICATIONS =3D \
>+  FitGen \
>+
>+all: $(APPLICATIONS)
>+    @echo.
>+    @echo ######################
>+    @echo # Build executables
>+    @echo ######################
>+    @if not exist $(BIN_PATH) mkdir $(BIN_PATH)
>+    @$(EDK_TOOLS_PATH)\Source\C\Makefiles\NmakeSubdirs.bat all $**
>+
>+.PHONY: clean
>+clean: $(APPLICATIONS)
>+  @$(EDK_TOOLS_PATH)\Source\C\Makefiles\NmakeSubdirs.bat clean $**
>+
>+.PHONY: cleanall
>+cleanall: $(APPLICATIONS)
>+  @$(EDK_TOOLS_PATH)\Source\C\Makefiles\NmakeSubdirs.bat cleanall
>$**
>+
>+!INCLUDE $(EDK_TOOLS_PATH)\Source\C\Makefiles\ms.rule
>+
>--
>2.18.0.windows.1