From: "Liming Gao" <liming.gao@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
"rebecca@bluestop.org" <rebecca@bluestop.org>
Subject: Re: [PATCH V2] BaseTools:Linux changes the way the latest version is judged
Date: Wed, 26 Jun 2019 07:27:17 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48D90F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF84C3C@SHSMSX101.ccr.corp.intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Wednesday, June 26, 2019 12:50 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>; rebecca@bluestop.org
>Subject: [PATCH V2] BaseTools:Linux changes the way the latest version is
>judged
>
>Some Linux servers do not have BC installed,so errors occur.
>So the judgment was changed to avoid this error.
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
>Change "\<" to "<" and add as two "[]"
>
> edksetup.sh | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/edksetup.sh b/edksetup.sh
>index c7b2e1e201..0723e7b85a 100755
>--- a/edksetup.sh
>+++ b/edksetup.sh
>@@ -122,8 +122,7 @@ function SetupPython3()
> export PYTHON_COMMAND=$python
> continue
> fi
>- ret=`echo "$origin_version < $python_version" |bc`
>- if [ "$ret" -eq 1 ]; then
>+ if [[ "$origin_version" < "$python_version" ]]; then
> origin_version=$python_version
> export PYTHON_COMMAND=$python
> fi
>@@ -165,8 +164,7 @@ function SetupPython()
> export PYTHON_COMMAND=$python
> continue
> fi
>- ret=`echo "$origin_version < $python_version" |bc`
>- if [ "$ret" -eq 1 ]; then
>+ if [[ "$origin_version" < "$python_version" ]]; then
> origin_version=$python_version
> export PYTHON_COMMAND=$python
> fi
>--
>2.14.1.windows.1
prev parent reply other threads:[~2019-06-26 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 4:49 [PATCH V2] BaseTools:Linux changes the way the latest version is judged Fan, ZhijuX
2019-06-26 7:27 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E48D90F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox