[PATCH V2] BaseTools:Linux changes the way the latest version is judged

[PATCH V2] BaseTools:Linux changes the way the latest version is judged

[Fan, ZhijuX]

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

Some Linux servers do not have BC installed,so errors occur.
So the judgment was changed to avoid this error.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
Change "\<" to "<" and add as two "[]"

 edksetup.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/edksetup.sh b/edksetup.sh
index c7b2e1e201..0723e7b85a 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -122,8 +122,7 @@ function SetupPython3()
         export PYTHON_COMMAND=$python
         continue
       fi
-      ret=`echo "$origin_version < $python_version" |bc`
-      if [ "$ret" -eq 1 ]; then
+      if [[ "$origin_version" < "$python_version" ]]; then
         origin_version=$python_version
         export PYTHON_COMMAND=$python
       fi
@@ -165,8 +164,7 @@ function SetupPython()
         export PYTHON_COMMAND=$python
         continue
       fi
-      ret=`echo "$origin_version < $python_version" |bc`
-      if [ "$ret" -eq 1 ]; then
+      if [[ "$origin_version" < "$python_version" ]]; then
         origin_version=$python_version
         export PYTHON_COMMAND=$python
       fi
-- 
2.14.1.windows.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 3764 bytes --]

Re: [PATCH V2] BaseTools:Linux changes the way the latest version is judged

[Liming Gao]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Wednesday, June 26, 2019 12:50 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>; rebecca@bluestop.org
>Subject: [PATCH V2] BaseTools:Linux changes the way the latest version is
>judged
>
>Some Linux servers do not have BC installed,so errors occur.
>So the judgment was changed to avoid this error.
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
>Change "\<" to "<" and add as two "[]"
>
> edksetup.sh | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/edksetup.sh b/edksetup.sh
>index c7b2e1e201..0723e7b85a 100755
>--- a/edksetup.sh
>+++ b/edksetup.sh
>@@ -122,8 +122,7 @@ function SetupPython3()
>         export PYTHON_COMMAND=$python
>         continue
>       fi
>-      ret=`echo "$origin_version < $python_version" |bc`
>-      if [ "$ret" -eq 1 ]; then
>+      if [[ "$origin_version" < "$python_version" ]]; then
>         origin_version=$python_version
>         export PYTHON_COMMAND=$python
>       fi
>@@ -165,8 +164,7 @@ function SetupPython()
>         export PYTHON_COMMAND=$python
>         continue
>       fi
>-      ret=`echo "$origin_version < $python_version" |bc`
>-      if [ "$ret" -eq 1 ]; then
>+      if [[ "$origin_version" < "$python_version" ]]; then
>         origin_version=$python_version
>         export PYTHON_COMMAND=$python
>       fi
>--
>2.14.1.windows.1