From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by groups.io with SMTP; Wed, 26 Jun 2019 00:27:21 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 00:27:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,419,1557212400"; 
   d="scan'208";a="360216810"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga005.fm.intel.com with ESMTP; 26 Jun 2019 00:27:19 -0700
Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 26 Jun 2019 00:27:19 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 26 Jun 2019 00:27:19 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000;
 Wed, 26 Jun 2019 15:27:17 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Feng, Bob C" <bob.c.feng@intel.com>, "rebecca@bluestop.org"
	<rebecca@bluestop.org>
Subject: Re: [PATCH V2] BaseTools:Linux changes the way the latest version is judged
Thread-Topic: [PATCH V2] BaseTools:Linux changes the way the latest version
 is judged
Thread-Index: AdUr2kCxvuNMFWbzTPS/3VcXtp3e8gAFlEzw
Date: Wed, 26 Jun 2019 07:27:17 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48D90F@SHSMSX104.ccr.corp.intel.com>
References: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF84C3C@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF84C3C@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Wednesday, June 26, 2019 12:50 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>; rebecca@bluestop.org
>Subject: [PATCH V2] BaseTools:Linux changes the way the latest version is
>judged
>
>Some Linux servers do not have BC installed,so errors occur.
>So the judgment was changed to avoid this error.
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
>Change "\<" to "<" and add as two "[]"
>
> edksetup.sh | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/edksetup.sh b/edksetup.sh
>index c7b2e1e201..0723e7b85a 100755
>--- a/edksetup.sh
>+++ b/edksetup.sh
>@@ -122,8 +122,7 @@ function SetupPython3()
>         export PYTHON_COMMAND=3D$python
>         continue
>       fi
>-      ret=3D`echo "$origin_version < $python_version" |bc`
>-      if [ "$ret" -eq 1 ]; then
>+      if [[ "$origin_version" < "$python_version" ]]; then
>         origin_version=3D$python_version
>         export PYTHON_COMMAND=3D$python
>       fi
>@@ -165,8 +164,7 @@ function SetupPython()
>         export PYTHON_COMMAND=3D$python
>         continue
>       fi
>-      ret=3D`echo "$origin_version < $python_version" |bc`
>-      if [ "$ret" -eq 1 ]; then
>+      if [[ "$origin_version" < "$python_version" ]]; then
>         origin_version=3D$python_version
>         export PYTHON_COMMAND=3D$python
>       fi
>--
>2.14.1.windows.1