From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 27 Jun 2019 00:37:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 00:37:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,423,1557212400"; d="scan'208";a="170335254" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jun 2019 00:37:34 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 00:37:34 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 00:37:34 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 15:37:32 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "rebecca@bluestop.org" , "Feng, Bob C" , "Fan, ZhijuX" Subject: Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3 Thread-Topic: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3 Thread-Index: AQHVLD/1xN3+N0A9OUCcHNTqoldQhqavHa2Q Date: Thu, 27 Jun 2019 07:37:32 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E3D7@SHSMSX104.ccr.corp.intel.com> References: <20190626165456.63388-1-rebecca@bluestop.org> In-Reply-To: <20190626165456.63388-1-rebecca@bluestop.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWIzMmY3NjktNjc5Ny00OGVkLWJiYWMtZDYyYjhjZmEzNjAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWlcrTGpNcnhLcThPWGh6a2NLeTF0dTNHYmFzblBsSW8zaVE4TktueHhUWklDWGtOaUlab09cL2dVK0I0cHBlNm8ifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable So, this is just indentation update. There is no functionality impact. What= test have you done? Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of reb= ecca@bluestop.org > Sent: Thursday, June 27, 2019 12:55 AM > To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming= ; Fan, ZhijuX > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3 >=20 > Signed-off-by: Rebecca Cran > --- > edksetup.sh | 40 ++++++++++++++++++++-------------------- > 1 file changed, 20 insertions(+), 20 deletions(-) >=20 > diff --git a/edksetup.sh b/edksetup.sh > index c7b2e1e201..61e988035f 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -108,27 +108,27 @@ function SetupEnv() > function SetupPython3() > { > if [ $origin_version ];then > - origin_version=3D > + origin_version=3D > + fi > + for python in $(whereis python3) > + do > + python=3D$(echo $python | grep "[[:digit:]]$" || true) > + python_version=3D${python##*python} > + if [ -z "${python_version}" ] || (! command -v $python >/dev/null 2>= &1);then > + continue > fi > - for python in $(whereis python3) > - do > - python=3D$(echo $python | grep "[[:digit:]]$" || true) > - python_version=3D${python##*python} > - if [ -z "${python_version}" ] || (! command -v $python >/dev/null = 2>&1);then > - continue > - fi > - if [ -z $origin_version ];then > - origin_version=3D$python_version > - export PYTHON_COMMAND=3D$python > - continue > - fi > - ret=3D`echo "$origin_version < $python_version" |bc` > - if [ "$ret" -eq 1 ]; then > - origin_version=3D$python_version > - export PYTHON_COMMAND=3D$python > - fi > - done > - return 0 > + if [ -z $origin_version ];then > + origin_version=3D$python_version > + export PYTHON_COMMAND=3D$python > + continue > + fi > + ret=3D`echo "$origin_version < $python_version" |bc` > + if [ "$ret" -eq 1 ]; then > + origin_version=3D$python_version > + export PYTHON_COMMAND=3D$python > + fi > + done > + return 0 > } >=20 > function SetupPython() > -- > 2.22.0 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#42903): https://edk2.groups.io/g/devel/message/42903 > Mute This Topic: https://groups.io/mt/32217032/1759384 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D