public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
Date: Thu, 27 Jun 2019 09:38:12 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E55D@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190623135832.48300-1-dandan.bi@intel.com>

Dandan:
  One minor comment. Help message shows two ForceRebuild options. Please remove one. And, this change retire --nt32 option. Please update wiki page on edksetup usage in https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-Writing-Simple-Application. With those change, Reviewed-by: Liming Gao <liming.gao@intel.com>

        Reconfig       Reinstall target.txt, tools_def.txt and build_rule.txt.
        Rebuild        Perform incremental rebuild of BaseTools binaries.
        ForceRebuild   Force a full rebuild of BaseTools binaries.
        ForceRebuild   Force a full rebuild of BaseTools binaries.

Thanks
Liming
> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, June 23, 2019 9:59 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
> 
> Patch 1 remove nt32 related flags in bat files.
> Patch 2 setup for different VS tool chains.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Dandan Bi (2):
>   Edk2: Remove nt32 related flag in bat files
>   Edk2Setup: Support different VS tool chain setup
> 
>  BaseTools/get_vsvars.bat        | 42 +++++++++++++++++++++----
>  BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
>  BaseTools/toolsetup.bat         | 68 ++++++++++++++++++++++++++++++++++-------
>  edksetup.bat                    | 32 ++++++-------------
>  4 files changed, 145 insertions(+), 44 deletions(-)
> 
> --
> 1.9.5.msysgit.1


  parent reply	other threads:[~2019-06-27  9:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-23 13:58 [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Dandan Bi
2019-06-23 13:58 ` [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files Dandan Bi
2019-06-23 13:58 ` [patch 2/2] Edk2Setup: Support different VS tool chain setup Dandan Bi
2019-06-27  9:38 ` Liming Gao [this message]
2019-06-27 11:56 ` [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Bob Feng
2019-06-27 14:47   ` Liming Gao
2019-06-27 15:14     ` Bob Feng
2019-06-27 15:16       ` Liming Gao
2019-06-28  1:10         ` Dandan Bi
2019-06-28  1:11           ` Liming Gao
2019-07-03 12:23             ` Bob Feng
2019-07-04  0:54               ` Dandan Bi
2019-07-04  1:07                 ` Bob Feng
     [not found]           ` <15AC379CC0BB042B.14856@groups.io>
2019-06-28  7:09             ` [edk2-devel] " Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E48E55D@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox