From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Thu, 27 Jun 2019 02:38:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 02:38:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,423,1557212400"; d="scan'208";a="337527203" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 27 Jun 2019 02:38:15 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 02:38:15 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 17:38:13 +0800 From: "Liming Gao" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Feng, Bob C" Subject: Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Topic: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Index: AQHVKcvGXsl1nWjCaUihJ+JVw9ICHqavOErA Date: Thu, 27 Jun 2019 09:38:12 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E55D@SHSMSX104.ccr.corp.intel.com> References: <20190623135832.48300-1-dandan.bi@intel.com> In-Reply-To: <20190623135832.48300-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmIwY2Y3NTYtMWU2NS00MWQzLWJlMGUtZDljNjI0OWUyYjk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ0JIZ3g5SlJlODdpK1wvM0IrY0ZRWjRMZ0l5RXI2dnpiNTd6Z3Nad3lkcXpJUjBCQTVkZTJoMit5eHBvSGNMSnYifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dandan: One minor comment. Help message shows two ForceRebuild options. Please re= move one. And, this change retire --nt32 option. Please update wiki page on= edksetup usage in https://github.com/tianocore/tianocore.github.io/wiki/Ge= tting-Started-Writing-Simple-Application. With those change, Reviewed-by: L= iming Gao Reconfig Reinstall target.txt, tools_def.txt and build_rule.t= xt. Rebuild Perform incremental rebuild of BaseTools binaries. ForceRebuild Force a full rebuild of BaseTools binaries. ForceRebuild Force a full rebuild of BaseTools binaries. Thanks Liming > -----Original Message----- > From: Bi, Dandan > Sent: Sunday, June 23, 2019 9:59 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1693 >=20 > Patch 1 remove nt32 related flags in bat files. > Patch 2 setup for different VS tool chains. >=20 > Cc: Bob Feng > Cc: Liming Gao > Dandan Bi (2): > Edk2: Remove nt32 related flag in bat files > Edk2Setup: Support different VS tool chain setup >=20 > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++---- > BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++--- > BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-= ------ > edksetup.bat | 32 ++++++------------- > 4 files changed, 145 insertions(+), 44 deletions(-) >=20 > -- > 1.9.5.msysgit.1