public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platofrms] [patch] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup
@ 2019-06-28  2:02 Dandan Bi
  2019-06-28  2:15 ` [edk2-devel] " Liming Gao
  0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2019-06-28  2:02 UTC (permalink / raw)
  To: devel; +Cc: Shifei A Lu, Xiaohu Zhou, Isaac W Oram

Since Nt32Pkg has been removed from edk2 repo, and
we will also remove the --nt32 flag in edksetup.bat.
So here update platform to pass build.

Cc: Shifei A Lu <shifei.a.lu@intel.com>
Cc: Xiaohu Zhou <bowen.zhou@intel.com>
Cc: Isaac W Oram <isaac.w.oram@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOlympus.bat   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOlympus.bat b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOlympus.bat
index 02ed458236..6cda954fc9 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOlympus.bat
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOlympus.bat
@@ -46,11 +46,11 @@ set EDK_TOOLS_BIN=%WORKSPACE%\edk2-BaseTools-win32
 
 set EDK_SETUP_OPTION=
 @rem if python is installed, disable the binary base tools.
 if defined PYTHON_HOME (
   set EDK_TOOLS_BIN=
-  set EDK_SETUP_OPTION=--nt32
+  set EDK_SETUP_OPTION=Rebuild
 )
 pushd %WORKSPACE%\edk2
 call edksetup.bat %EDK_SETUP_OPTION%
 popd
 pushd %WORKSPACE%
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] [edk2-platofrms] [patch] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup
  2019-06-28  2:02 [edk2-platofrms] [patch] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup Dandan Bi
@ 2019-06-28  2:15 ` Liming Gao
  0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2019-06-28  2:15 UTC (permalink / raw)
  To: devel@edk2.groups.io, Bi, Dandan; +Cc: Lu, Shifei A, Zhou, Bowen, Oram, Isaac W

If use Rebuild option, below nmake is not required. 

@if defined PYTHON_HOME (
  nmake -f %BASE_TOOLS_PATH%\Makefile
)

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Dandan Bi
>Sent: Friday, June 28, 2019 10:03 AM
>To: devel@edk2.groups.io
>Cc: Lu, Shifei A <shifei.a.lu@intel.com>; Zhou, Bowen
><bowen.zhou@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
>Subject: [edk2-devel] [edk2-platofrms] [patch]
>Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup
>
>Since Nt32Pkg has been removed from edk2 repo, and
>we will also remove the --nt32 flag in edksetup.bat.
>So here update platform to pass build.
>
>Cc: Shifei A Lu <shifei.a.lu@intel.com>
>Cc: Xiaohu Zhou <bowen.zhou@intel.com>
>Cc: Isaac W Oram <isaac.w.oram@intel.com>
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> .../PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOlympus.bat   | 2
>+-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git
>a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly
>mpus.bat
>b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly
>mpus.bat
>index 02ed458236..6cda954fc9 100644
>---
>a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly
>mpus.bat
>+++
>b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly
>mpus.bat
>@@ -46,11 +46,11 @@ set EDK_TOOLS_BIN=%WORKSPACE%\edk2-
>BaseTools-win32
>
> set EDK_SETUP_OPTION=
> @rem if python is installed, disable the binary base tools.
> if defined PYTHON_HOME (
>   set EDK_TOOLS_BIN=
>-  set EDK_SETUP_OPTION=--nt32
>+  set EDK_SETUP_OPTION=Rebuild
> )
> pushd %WORKSPACE%\edk2
> call edksetup.bat %EDK_SETUP_OPTION%
> popd
> pushd %WORKSPACE%
>--
>2.18.0.windows.1
>
>
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-28  2:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-28  2:02 [edk2-platofrms] [patch] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup Dandan Bi
2019-06-28  2:15 ` [edk2-devel] " Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox