From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 27 Jun 2019 19:57:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 19:57:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,426,1557212400"; d="scan'208";a="164535152" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 27 Jun 2019 19:57:20 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 19:57:20 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 19:57:20 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.246]) with mapi id 14.03.0439.000; Fri, 28 Jun 2019 10:57:18 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Bi, Dandan" CC: "Lu, Shifei A" , "Zhou, Bowen" , "Oram, Isaac W" Subject: Re: [edk2-devel] [edk2-platofrms] [patch v2] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup Thread-Topic: [edk2-devel] [edk2-platofrms] [patch v2] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup Thread-Index: AQHVLVzrQKiyrbVfh0S+pW33MwxPxaawXzlQ Date: Fri, 28 Jun 2019 02:57:18 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48ED4B@SHSMSX104.ccr.corp.intel.com> References: <20190628025506.70024-1-dandan.bi@intel.com> In-Reply-To: <20190628025506.70024-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dandan: Don't need to add version info in the commit log. And, please also remov= e pushd %WORKSPACE% & popd. They are not used after nmake is removed. With = those changes, Reviewed-by: Liming Gao Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Dandan Bi >Sent: Friday, June 28, 2019 10:55 AM >To: devel@edk2.groups.io >Cc: Lu, Shifei A ; Zhou, Bowen >; Oram, Isaac W ; Gao, >Liming >Subject: [edk2-devel] [edk2-platofrms] [patch v2] >Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup > >V2: Remove nmake -f %BASE_TOOLS_PATH%\Makefile, since it >has been covered by edksetup.bat Rebuild option. > >Since Nt32Pkg has been removed from edk2 repo, and >we will also remove the --nt32 flag in edksetup.bat. >So here update platform to pass build. > >Cc: Shifei A Lu >Cc: Xiaohu Zhou >Cc: Isaac W Oram >Cc: Liming Gao >Signed-off-by: Dandan Bi >--- > .../BoardMtOlympus/GitEdk2MinMtOlympus.bat | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git >a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >mpus.bat >b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >mpus.bat >index 02ed458236..6b4e90294b 100644 >--- >a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >mpus.bat >+++ >b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >mpus.bat >@@ -46,20 +46,16 @@ set EDK_TOOLS_BIN=3D%WORKSPACE%\edk2- >BaseTools-win32 > > set EDK_SETUP_OPTION=3D > @rem if python is installed, disable the binary base tools. > if defined PYTHON_HOME ( > set EDK_TOOLS_BIN=3D >- set EDK_SETUP_OPTION=3D--nt32 >+ set EDK_SETUP_OPTION=3DRebuild > ) > pushd %WORKSPACE%\edk2 > call edksetup.bat %EDK_SETUP_OPTION% > popd > pushd %WORKSPACE% >-@rem if python is installed, nmake BaseTools source and enable BaseTools >source build >-@if defined PYTHON_HOME ( >- nmake -f %BASE_TOOLS_PATH%\Makefile >-) > popd > > set openssl_path=3D%WORKSPACE% > > popd >-- >2.18.0.windows.1 > > >