From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Fri, 28 Jun 2019 00:09:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 00:09:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,426,1557212400"; d="scan'208";a="314051542" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 28 Jun 2019 00:09:16 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 28 Jun 2019 00:09:16 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 28 Jun 2019 00:09:16 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Fri, 28 Jun 2019 15:09:14 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , "Bi, Dandan" , "Feng, Bob C" Subject: Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Topic: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Index: AQHVKcvGXsl1nWjCaUihJ+JVw9ICHqau5OEAgAC14iD//4FvgIAAhqYAgAAgFQCAAIZLAIAAY9fg Date: Fri, 28 Jun 2019 07:09:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48F098@SHSMSX104.ccr.corp.intel.com> References: <20190623135832.48300-1-dandan.bi@intel.com> <08650203BA1BD64D8AD9B6D5D74A85D160B33E03@SHSMSX105.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E80C@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D160B33EE3@SHSMSX105.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E8A0@SHSMSX104.ccr.corp.intel.com> <3C0D5C461C9E904E8F62152F6274C0BB40C08679@SHSMSX104.ccr.corp.intel.com> <15AC379CC0BB042B.14856@groups.io> In-Reply-To: <15AC379CC0BB042B.14856@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push @d31666211873086c058285f4a4f1933bc3c3428c..6759212fa69d5d266c2854ea6de= 44bfd3f7e370b >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Friday, June 28, 2019 9:12 AM >To: Bi, Dandan ; Feng, Bob C ; >devel@edk2.groups.io >Subject: Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch >files > >Dandan: > > If you find any pre script to use --nt32 option, please remove them firs= t, then >do this change. > >>-----Original Message----- >>From: Bi, Dandan >>Sent: Friday, June 28, 2019 9:11 AM >>To: Gao, Liming ; Feng, Bob C >>; devel@edk2.groups.io >>Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >> >>Hi Liming and Bob, >> >>Thanks for the review. So we reach the agreement that remove the --nt32 >>flag, right? If so, I will address Liming's comments and then push these= two >>patches. >> >> >>Thanks, >>Dandan >> >>> -----Original Message----- >>> From: Gao, Liming >>> Sent: Thursday, June 27, 2019 11:17 PM >>> To: Feng, Bob C ; Bi, Dandan >>> ; devel@edk2.groups.io >>> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >>> >>> Yes. Those script needs to be updated together. >>> >>> > -----Original Message----- >>> > From: Feng, Bob C >>> > Sent: Thursday, June 27, 2019 11:14 PM >>> > To: Gao, Liming ; Bi, Dandan >>> > ; devel@edk2.groups.io >>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >>> > >>> > OK. I think it may break some pre-build script if the pre-build scr= ipt have >>> "edksetup --nt32"... >>> > >>> > -----Original Message----- >>> > From: Gao, Liming >>> > Sent: Thursday, June 27, 2019 10:48 PM >>> > To: Feng, Bob C ; Bi, Dandan >>> > ; devel@edk2.groups.io >>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >>> > >>> > Bob: >>> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. >So, >>> I think it is fine to remove --nt32 option. >>> > >>> > > -----Original Message----- >>> > > From: Feng, Bob C >>> > > Sent: Thursday, June 27, 2019 7:56 PM >>> > > To: Bi, Dandan ; devel@edk2.groups.io >>> > > Cc: Gao, Liming >>> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >>> > > >>> > > The patches look good. >>> > > >>> > > I think removing --nt32 option is incompatible change. What about >keep >>> the --nt32 ? >>> > > >>> > > For the Patch 2 setup for different VS tool chains. >>> > > Reviewed-by: Bob Feng >>> > > >>> > > Thanks, >>> > > Bob >>> > > >>> > > -----Original Message----- >>> > > From: Bi, Dandan >>> > > Sent: Sunday, June 23, 2019 9:59 PM >>> > > To: devel@edk2.groups.io >>> > > Cc: Feng, Bob C ; Gao, Liming >>> > > >>> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >>> > > >>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1693 >>> > > >>> > > Patch 1 remove nt32 related flags in bat files. >>> > > Patch 2 setup for different VS tool chains. >>> > > >>> > > Cc: Bob Feng >>> > > Cc: Liming Gao Dandan Bi (2): >>> > > Edk2: Remove nt32 related flag in bat files >>> > > Edk2Setup: Support different VS tool chain setup >>> > > >>> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++---- >>> > > BaseTools/set_vsprefix_envs.bat | 47 >+++++++++++++++++++++++++- >>- >>> - >>> > > BaseTools/toolsetup.bat | 68 >>> ++++++++++++++++++++++++++++++++++------- >>> > > edksetup.bat | 32 ++++++------------- >>> > > 4 files changed, 145 insertions(+), 44 deletions(-) >>> > > >>> > > -- >>> > > 1.9.5.msysgit.1 > > >