From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Fri, 28 Jun 2019 00:14:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 00:14:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,426,1557212400"; d="scan'208";a="183628938" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2019 00:14:29 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 28 Jun 2019 00:14:30 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Fri, 28 Jun 2019 15:14:28 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , "Bi, Dandan" CC: "Lu, Shifei A" , "Zhou, Bowen" , "Oram, Isaac W" Subject: Re: [edk2-devel] [edk2-platofrms] [patch v2] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup Thread-Topic: [edk2-devel] [edk2-platofrms] [patch v2] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup Thread-Index: AQHVLVzrQKiyrbVfh0S+pW33MwxPxaawXzlQgABIQPA= Date: Fri, 28 Jun 2019 07:14:28 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48F0D6@SHSMSX104.ccr.corp.intel.com> References: <20190628025506.70024-1-dandan.bi@intel.com> <15AC3D5D2C07B354.14856@groups.io> In-Reply-To: <15AC3D5D2C07B354.14856@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push @e7fc97a3f9045c35a077ab0151c696aeba722417 >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Friday, June 28, 2019 10:57 AM >To: devel@edk2.groups.io; Bi, Dandan >Cc: Lu, Shifei A ; Zhou, Bowen >; Oram, Isaac W >Subject: Re: [edk2-devel] [edk2-platofrms] [patch v2] >Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup > >Dandan: > Don't need to add version info in the commit log. And, please also remo= ve >pushd %WORKSPACE% & popd. They are not used after nmake is removed. >With those changes, Reviewed-by: Liming Gao > >Thanks >Liming >>-----Original Message----- >>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>Dandan Bi >>Sent: Friday, June 28, 2019 10:55 AM >>To: devel@edk2.groups.io >>Cc: Lu, Shifei A ; Zhou, Bowen >>; Oram, Isaac W ; Gao, >>Liming >>Subject: [edk2-devel] [edk2-platofrms] [patch v2] >>Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup >> >>V2: Remove nmake -f %BASE_TOOLS_PATH%\Makefile, since it >>has been covered by edksetup.bat Rebuild option. >> >>Since Nt32Pkg has been removed from edk2 repo, and >>we will also remove the --nt32 flag in edksetup.bat. >>So here update platform to pass build. >> >>Cc: Shifei A Lu >>Cc: Xiaohu Zhou >>Cc: Isaac W Oram >>Cc: Liming Gao >>Signed-off-by: Dandan Bi >>--- >> .../BoardMtOlympus/GitEdk2MinMtOlympus.bat | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >>diff --git >>a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >>mpus.bat >>b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >>mpus.bat >>index 02ed458236..6b4e90294b 100644 >>--- >>a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >>mpus.bat >>+++ >>b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOly >>mpus.bat >>@@ -46,20 +46,16 @@ set EDK_TOOLS_BIN=3D%WORKSPACE%\edk2- >>BaseTools-win32 >> >> set EDK_SETUP_OPTION=3D >> @rem if python is installed, disable the binary base tools. >> if defined PYTHON_HOME ( >> set EDK_TOOLS_BIN=3D >>- set EDK_SETUP_OPTION=3D--nt32 >>+ set EDK_SETUP_OPTION=3DRebuild >> ) >> pushd %WORKSPACE%\edk2 >> call edksetup.bat %EDK_SETUP_OPTION% >> popd >> pushd %WORKSPACE% >>-@rem if python is installed, nmake BaseTools source and enable BaseTool= s >>source build >>-@if defined PYTHON_HOME ( >>- nmake -f %BASE_TOOLS_PATH%\Makefile >>-) >> popd >> >> set openssl_path=3D%WORKSPACE% >> >> popd >>-- >>2.18.0.windows.1 >> >> >> > > >