From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@bluestop.org" <rebecca@bluestop.org>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Fan, ZhijuX" <zhijux.fan@intel.com>
Subject: Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3
Date: Fri, 28 Jun 2019 08:04:36 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48F1D3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <8c8cf830-a60b-ad67-0ad4-481df423d7df@bluestop.org>
The change is good. Reviewed-by: Liming Gao <liming.gao@intel.com>
I suggest you run this script in Linux and double confirm.
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>rebecca@bluestop.org
>Sent: Thursday, June 27, 2019 9:05 PM
>To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Feng, Bob C
><bob.c.feng@intel.com>; Fan, ZhijuX <zhijux.fan@intel.com>
>Subject: Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh
>SetupPython3
>
>On 2019-06-27 01:37, Gao, Liming wrote:
>> So, this is just indentation update. There is no functionality impact. What
>test have you done?
>
>
>Yes, it's just whitespace changes. I haven't done any tests, since
>whitespace doesn't affect functionality.
>
>Running "git diff -w" confirms there are no functionality changes.
>
>
>--
>Rebecca Cran
>
>
>
next prev parent reply other threads:[~2019-06-28 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 16:54 [PATCH] Fix indentation in edksetup.sh SetupPython3 rebecca
2019-06-27 7:37 ` [edk2-devel] " Liming Gao
2019-06-27 13:05 ` rebecca
2019-06-28 8:04 ` Liming Gao [this message]
2019-06-28 15:30 ` rebecca
2019-07-01 3:58 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E48F1D3@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox