public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"rebecca@bluestop.org" <rebecca@bluestop.org>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged
Date: Mon, 1 Jul 2019 03:59:30 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E49B13B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF853A2@SHSMSX101.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]

Push@39744883933eea9674ccaf243cbf565966b8fa74

From: Fan, ZhijuX
Sent: Friday, June 28, 2019 3:49 PM
To: devel@edk2.groups.io; rebecca@bluestop.org
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
Subject: RE: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

Hi:

You're right, but at least we won't have to worry about this until “python3.10”

·         And we're comparing directory names, "Python 3.6.6" doesn't appear in the Python version we found

·         We find python applications using “whereis python”   “/usr/bin/python3.6” “/usr/local/bin/python3.6”

·         Later we can compare the form of string length to add a layer of judgment, but we don't need it now.


Any question, please let me know. Thanks.

Best Regards
Fan Zhiju



From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of rebecca@bluestop.org<mailto:rebecca@bluestop.org>
Sent: Wednesday, June 26, 2019 11:48 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Fan, ZhijuX <zhijux.fan@intel.com<mailto:zhijux.fan@intel.com>>
Cc: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>
Subject: Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

On 2019-06-25 22:46, Fan, ZhijuX wrote:

Hi:
Python3.6 and python3.7
After the code removes some common values “python”, we compare “3.6” and “3.7”
origin_version = “3.6”, python_version=”3.7”

I'm going to change it to
if [[ "$origin_version" < "$python_version" ]]; then





That's fine for now, hopefully it'll keep working as long as it needs to.

But once you're comparing for example 3.7 and 3.12:

[bcran@photon ~]$ if [[ "3.7" > "3.12" ]]; then echo "wrong!"; else echo "correct!"; fi
wrong!

--
Rebecca Cran


[-- Attachment #2: Type: text/html, Size: 15841 bytes --]

  reply	other threads:[~2019-07-01  3:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  7:48 [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged Fan, ZhijuX
2019-07-01  3:59 ` Liming Gao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-06-21  2:33 Fan, ZhijuX
2019-06-24  3:25 ` [edk2-devel] " rebecca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E49B13B@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox