From: "Liming Gao" <liming.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] Silicon/Tools: Replace white spaces with tabs in GNUmakefile
Date: Mon, 1 Jul 2019 11:32:12 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E49C63D@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190701070931.12000-1-shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zhang, Shenglei
>Sent: Monday, July 01, 2019 3:10 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [PATCH] Silicon/Tools: Replace white spaces with tabs in
>GNUmakefile
>
>The tools can't be complied successfully because of the white spaces
>in GNUmakefile. So replace them with tabs.
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> Silicon/Intel/Tools/GNUmakefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Silicon/Intel/Tools/GNUmakefile
>b/Silicon/Intel/Tools/GNUmakefile
>index 20abf148b5..6910b6ad0f 100644
>--- a/Silicon/Intel/Tools/GNUmakefile
>+++ b/Silicon/Intel/Tools/GNUmakefile
>@@ -18,11 +18,11 @@ $(APPLICATIONS): $(MAKEROOT)/bin
> .PHONY: subdirs $(SUBDIRS)
> subdirs: $(SUBDIRS)
> $(SUBDIRS):
>- $(MAKE) -C $@
>+ $(MAKE) -C $@
>
> .PHONY: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
> $(patsubst %,%-clean,$(sort $(SUBDIRS))):
>- -$(MAKE) -C $(@:-clean=) clean
>+ -$(MAKE) -C $(@:-clean=) clean
>
> clean: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
>
>--
>2.18.0.windows.1
prev parent reply other threads:[~2019-07-01 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 7:09 [PATCH] Silicon/Tools: Replace white spaces with tabs in GNUmakefile Zhang, Shenglei
2019-07-01 11:32 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E49C63D@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox