public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] Silicon/Tools: Replace white spaces with tabs in GNUmakefile
@ 2019-07-01  7:09 Zhang, Shenglei
  2019-07-01 11:32 ` Liming Gao
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Shenglei @ 2019-07-01  7:09 UTC (permalink / raw)
  To: devel; +Cc: Bob Feng, Liming Gao

The tools can't be complied successfully because of the white spaces
in GNUmakefile. So replace them with tabs.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 Silicon/Intel/Tools/GNUmakefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Intel/Tools/GNUmakefile b/Silicon/Intel/Tools/GNUmakefile
index 20abf148b5..6910b6ad0f 100644
--- a/Silicon/Intel/Tools/GNUmakefile
+++ b/Silicon/Intel/Tools/GNUmakefile
@@ -18,11 +18,11 @@ $(APPLICATIONS): $(MAKEROOT)/bin
 .PHONY: subdirs $(SUBDIRS)
 subdirs: $(SUBDIRS)
 $(SUBDIRS):
-    $(MAKE) -C $@
+	$(MAKE) -C $@
 
 .PHONY: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
 $(patsubst %,%-clean,$(sort $(SUBDIRS))):
-    -$(MAKE) -C $(@:-clean=) clean
+	-$(MAKE) -C $(@:-clean=) clean
 
 clean: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
 
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Silicon/Tools: Replace white spaces with tabs in GNUmakefile
  2019-07-01  7:09 [PATCH] Silicon/Tools: Replace white spaces with tabs in GNUmakefile Zhang, Shenglei
@ 2019-07-01 11:32 ` Liming Gao
  0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2019-07-01 11:32 UTC (permalink / raw)
  To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Feng, Bob C

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhang, Shenglei
>Sent: Monday, July 01, 2019 3:10 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [PATCH] Silicon/Tools: Replace white spaces with tabs in
>GNUmakefile
>
>The tools can't be complied successfully because of the white spaces
>in GNUmakefile. So replace them with tabs.
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> Silicon/Intel/Tools/GNUmakefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Silicon/Intel/Tools/GNUmakefile
>b/Silicon/Intel/Tools/GNUmakefile
>index 20abf148b5..6910b6ad0f 100644
>--- a/Silicon/Intel/Tools/GNUmakefile
>+++ b/Silicon/Intel/Tools/GNUmakefile
>@@ -18,11 +18,11 @@ $(APPLICATIONS): $(MAKEROOT)/bin
> .PHONY: subdirs $(SUBDIRS)
> subdirs: $(SUBDIRS)
> $(SUBDIRS):
>-    $(MAKE) -C $@
>+	$(MAKE) -C $@
>
> .PHONY: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
> $(patsubst %,%-clean,$(sort $(SUBDIRS))):
>-    -$(MAKE) -C $(@:-clean=) clean
>+	-$(MAKE) -C $(@:-clean=) clean
>
> clean: $(patsubst %,%-clean,$(sort $(SUBDIRS)))
>
>--
>2.18.0.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-01 11:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-01  7:09 [PATCH] Silicon/Tools: Replace white spaces with tabs in GNUmakefile Zhang, Shenglei
2019-07-01 11:32 ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox