Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed

["Liming Gao" <liming.gao@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

Thanks for your catch. Yes. This is an issue. I will send the patch to clean it.

For this patch, the change is good. Reviewed-by: Liming Gao <liming.gao@intel.com>

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Hiber He
Sent: Friday, July 5, 2019 7:26 PM
To: devel <devel@edk2.groups.io>; leif.lindholm <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed

Hi,

    I think the license of FCE is not correct(Should be BSD-2-Clause-Patent). And the logic for ARCH("ifndef ARCH") can be deleted.

   I deleted the ARCH related lines and it did built.

Best Regards,
Hiber



On 07/05/2019 18:34, Leif Lindholm<mailto:leif.lindholm@linaro.org> wrote:
Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool
that is always built. Pre-existing tools locate the makefile includes
with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency
on having sourced edksetup.sh before building BaseTools.

Change FCE GNUmakefile to match other tools.

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>>
---

This broke our CI setup, so I'd appreciate if it could be merged quickly.

BaseTools/Source/C/FCE/GNUmakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GNUmakefile
index 3e1b6a85e2..7a7e1ef4b8 100644
--- a/BaseTools/Source/C/FCE/GNUmakefile
+++ b/BaseTools/Source/C/FCE/GNUmakefile
@@ -42,7 +42,7 @@ endif
export ARCH
export HOST_ARCH=$(ARCH)

-MAKEROOT ?= $(EDK_TOOLS_PATH)/Source/C
+MAKEROOT ?= ..

APPNAME = FCE

--
2.11.0




[-- Attachment #2: Type: text/html, Size: 7559 bytes --]